Uh oh!
There was an error while loading. Please reload this page.
Fix false positive rewriteRelativeImportExtensions error on non-TS extensions - #60415
Merged
Andrew Branch (andrewbranch) merged 1 commit intoNov 5, 2024
Merged
Conversation
Andrew Branch (andrewbranch)
requested a review
from Nathan Shively-Sanders (sandersn)November 4, 2024 17:52
Member
Should this be picked over for 5.7 stable? |
Andrew Branch (andrewbranch)
commented
Nov 5, 2024
MemberAuthor
Yes—I thought we hadn’t split off yet? |
Jake Bailey (jakebailey)
approved these changes
Nov 5, 2024
Andrew Branch (andrewbranch)
commented
Nov 5, 2024
MemberAuthor
TypeScript Bot (@typescript-bot) pick to release-5.7 |
Andrew Branch (andrewbranch)
commented
Nov 5, 2024
MemberAuthor
TypeScript Bot (@typescript-bot) cherry-pick to release-5.7 |
Contributor
TypeScript Bot (typescript-bot)
commented
Nov 5, 2024
Contributor
Hey, Andrew Branch (@andrewbranch)! I've created #60424 for you. |
Andrew Branch (andrewbranch) added a commit
that referenced
this pull request
Nov 5, 2024
…e-5.7 (#60424) Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#60392
Fixes#60396
This check was unnecessary for the actual rewriting, but somehow forgot to include it for error checking.