Skip to content

Stub out copilotRelated command - #60488

Merged
Nathan Shively-Sanders (sandersn) merged 4 commits into
microsoft:mainfrom
sandersn:stub-copilotrelated-command
Nov 13, 2024
Merged

Stub out copilotRelated command#60488
Nathan Shively-Sanders (sandersn) merged 4 commits into
microsoft:mainfrom
sandersn:stub-copilotrelated-command

Conversation

@sandersn

@sandersnNathan Shively-Sanders (sandersn) commented Nov 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This feature didn't help, but it took a long time to verify that.
The copilotRelated command will return an empty array in 5.7, and should be removed entirely in Typescript 5.8.

The only client should be VSCode 1.95. Matching PR to remove it from the typescript extension: microsoft/vscode#233729.

@sandersn
Stub out copilotRelated command
e447d16
It will return an empty array in 5.7,
and should be removed entirely in Typescript 5.8.
The only client should be VSCode 1.95.
@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 12, 2024
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Matt Bierner (@mjbvz), Kat Marchán (@zkat), and Joaquin Jares (@joj) for you. Feel free to loop in other consumers/maintainers if necessary.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

This was referenced Nov 12, 2024
Closed
Merged
jakebailey
Jake Bailey (jakebailey) reviewed Nov 12, 2024
View reviewed changes
Comment threadtests/baselines/reference/api/typescript.d.ts Outdated
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 79ea5a5 into microsoft:mainNov 13, 2024
@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 13, 2024

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick this

@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 13, 2024

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick

@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 13, 2024

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) cherry-pick to release-5.7

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
cherry-pick to release-5.7✅ Started✅ Results

TypeScript Bot (typescript-bot) pushed a commit that referenced this pull request Nov 13, 2024
@sandersn@typescript-bot
Stub out copilotRelated command (#60488)
6ca2bcf
@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Nov 13, 2024
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Hey, Nathan Shively-Sanders (@sandersn)! I've created #60495 for you.

Nathan Shively-Sanders (sandersn) added a commit that referenced this pull request Nov 13, 2024
@typescript-bot@sandersn
🤖 Pick PR#60488(Stub out copilotRelated command) into release-5.7 (#…
3140dbb
…60495)
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes

Assignees

@sandersnNathan Shively-Sanders (sandersn)

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandersn@typescript-bot@jakebailey