Skip to content

Fix library inclusions for ES2024 target - #60622

Merged
Ron Buckton (rbuckton) merged 5 commits into
microsoft:mainfrom
billyjanitsch:patch-1
Dec 3, 2024
Merged

Fix library inclusions for ES2024 target#60622
Ron Buckton (rbuckton) merged 5 commits into
microsoft:mainfrom
billyjanitsch:patch-1

Conversation

@billyjanitsch

@billyjanitschBilly Janitsch (billyjanitsch) commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Fixes#60621.

@typescript-botTypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 26, 2024
petamoriken
Kenta Moriuchi (petamoriken) reviewed Nov 27, 2024
View reviewed changes
Comment threadsrc/compiler/utilitiesPublic.ts
@typescript-botTypeScript Bot (typescript-bot) added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 27, 2024
@billyjanitsch

Billy Janitsch (billyjanitsch) commented Nov 27, 2024

Copy link
Copy Markdown
ContributorAuthor

@microsoft-github-policy-service agree

jakebailey
Jake Bailey (jakebailey) approved these changes Nov 27, 2024
View reviewed changes

@jakebaileyJake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me.

petamoriken
Kenta Moriuchi (petamoriken) reviewed Nov 28, 2024
View reviewed changes
Comment threadsrc/compiler/commandLineParser.ts
Comment on lines 148 to +151
// NOTE: We must reevaluate the target for upcoming features when each successive TC39 edition is ratified in
// June of each year. This includes changes to `LanguageFeatureMinimumTarget`, `ScriptTarget`,
// `ScriptTargetFeatures` transformers/esnext.ts, compiler/commandLineParser.ts and the contents of each
// lib/esnext.*.d.ts file.
// `ScriptTargetFeatures` transformers/esnext.ts, compiler/commandLineParser.ts,
// compiler/utilitiesPublic.ts, and the contents of each lib/esnext.*.d.ts file.

@petamorikenKenta Moriuchi (petamoriken)Nov 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Billy Janitsch (@billyjanitsch) Sorry for the lack of information 🙇

NOTE comments exist in multiple files and I would like to have them updated as well:

  • src/compiler/types.ts (two places)
  • src/compiler/utilities.ts
  • src/compiler/transformers/esnext.ts

Also, please add these comments to src/compiler/utilitiesPublic.ts.

@rbuckton

Ron Buckton (rbuckton) commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) should we take this as part of a patch to 5.7 or leave it for 5.8?

@rbuckton
Ron Buckton (rbuckton) merged commit 6f75783 into microsoft:mainDec 3, 2024
@jakebailey

Jake Bailey (jakebailey) commented Dec 4, 2024

Copy link
Copy Markdown
Member

I definitely think we should backport this, given ES2024 is not functional without it.

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.7

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 4, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
cherry-pick this to release-5.7✅ Started✅ Results

TypeScript Bot (typescript-bot) pushed a commit that referenced this pull request Dec 4, 2024
@billyjanitsch@typescript-bot
Fix library inclusions for ES2024 target (#60622)
e3c5cc6
@typescript-botTypeScript Bot (typescript-bot) mentioned this pull request Dec 4, 2024
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Hey, Jake Bailey (@jakebailey)! I've created #60681 for you. This involved updating baselines; please check the diff.

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Dec 6, 2024
@typescript-bot@billyjanitsch
🤖 Pick PR#60622(Fix library inclusions for ES2024 t...) into releas…
c765dce
…e-5.7 (#60681)
Co-authored-by: Billy Janitsch <billyjanitsch@gmail.com>
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes
+2 more reviewers
@petamorikenKenta Moriuchi (petamoriken)petamoriken left review comments
@rbucktonRon Buckton (rbuckton)rbuckton approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rbucktonRon Buckton (rbuckton)

Labels

For Milestone BugPRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

target: 'ES2024' does not include library definitions

6 participants

@billyjanitsch@rbuckton@jakebailey@typescript-bot@petamoriken@sandersn