Uh oh!
There was an error while loading. Please reload this page.
Control flow analysis for element access with variable constant-like index in for statements - #60715
Closed
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Closed
Conversation
…index in for statements
Comment on lines
+29635
to
+29645
| function isSymbolAssignedInForStatementBody(symbol: Symbol) { | ||
| const forStatement = getRootDeclaration(symbol.valueDeclaration!).parent.parent; | ||
| Debug.assert(isForStatement(forStatement)); | ||
| return !isPastLastAssignment(symbol, forStatement.statement); | ||
| } | ||
| function isUsedInForStatementBody(symbol: Symbol, location: Node) { | ||
| const forStatement = getRootDeclaration(symbol.valueDeclaration!).parent.parent; | ||
| Debug.assert(isForStatement(forStatement)); | ||
| return location.pos >= forStatement.statement.pos && location.end <= forStatement.statement.end; | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
I'd love to combine those 2 but I've failed so far to figure out an elegant function name for a function that would do both 😅
Jake Bailey (jakebailey)
commented
Dec 9, 2024
Member
TypeScript Bot (@typescript-bot) test it |
Contributor
TypeScript Bot (typescript-bot)
commented
Dec 9, 2024
Contributor
Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing Everything looks good! |
TypeScript Bot (typescript-bot)
commented
Dec 9, 2024
Contributor
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. Everything looks the same! |
TypeScript Bot (typescript-bot)
commented
Dec 9, 2024
Contributor
Jake Bailey (@jakebailey) Here they are:tscComparison Report - baseline..pr
System info unknown Hosts
Scenarios
Developer Information: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
TypeScript Bot (typescript-bot)
commented
Dec 9, 2024
Contributor
Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
Mateusz Burzyński (Andarist)
commented
Dec 10, 2024
ContributorAuthor
The snabbdom break isn't harmful. It boils down to a code like this: declarefunctionisPrimitive(s: any): s is string|number;exportfunctiontest(){letc: any;for(leti=0;i<c.length;++i){if(isPrimitive(c[i])){consttarget: string|undefined=c[i];}}}The problem is that declarefunctionisPrimitive(s: any): s is string|number;declareconstfoo: any;if(isPrimitive(foo)){foo;// string | number}Since now this constant-like |
TypeScript Bot (typescript-bot)
commented
Mar 24, 2026
Contributor
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small extension of #57847
closes#58803
letvariables in for loops are special, despite them being mutable and "shared" for the loop - each iteration gets its own unique copy of that variable. A mutation in the incrementor has no effect on the loop's body so, to the best of my understanding, it can safely be ignored.