Skip to content

Combined update graph experiments - #60800

Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 5 commits into
mainfrom
combinedUpdateGraphExperiments
Closed

Combined update graph experiments#60800
Daniel Rosenwasser (DanielRosenwasser) wants to merge 5 commits into
mainfrom
combinedUpdateGraphExperiments

Conversation

@DanielRosenwasser

Copy link
Copy Markdown
Member

Merges #60754 and #60755 to see the combined effect on addressing #60633.

@DanielRosenwasser

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
pack this✅ Started✅ Results

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164413/artifacts?artifactName=tgz&fileId=7F1016401FADCAF8EABD4FD550DAA32A0C47E4C9963BB5155861BA888CA2485802&fileName=/typescript-5.8.0-insiders.20241217.tgz"
}
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-60800-2".;

@DanielRosenwasser

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
perf test this✅ Started👀 Results

@typescript-bot

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-Unions - node (v18.15.0, x64)
Errors3434~~~p=1.000 n=6
Symbols62,36362,363~~~p=1.000 n=6
Types50,39550,395~~~p=1.000 n=6
Memory used195,565k (± 0.95%)196,716k (± 0.09%)~196,490k196,854kp=0.471 n=6
Parse Time1.60s (± 2.42%)1.59s (± 0.52%)~1.59s1.61sp=0.513 n=6
Bind Time0.86s (± 0.94%)0.86s (± 1.36%)~0.85s0.88sp=0.315 n=6
Check Time11.78s (± 0.72%)11.74s (± 0.27%)~11.70s11.78sp=0.335 n=6
Emit Time3.27s (± 1.30%)3.39s (± 3.95%)~3.27s3.58sp=0.078 n=6
Total Time17.51s (± 0.65%)17.59s (± 0.69%)~17.48s17.79sp=0.172 n=6
angular-1 - node (v18.15.0, x64)
Errors3737~~~p=1.000 n=6
Symbols947,936947,936~~~p=1.000 n=6
Types410,955410,955~~~p=1.000 n=6
Memory used1,225,998k (± 0.00%)1,225,824k (± 0.01%)-174k (- 0.01%)1,225,707k1,225,915kp=0.005 n=6
Parse Time8.02s (± 0.92%)8.09s (± 0.82%)+0.07s (+ 0.85%)8.03s8.21sp=0.045 n=6
Bind Time2.27s (± 0.71%)2.29s (± 0.66%)+0.03s (+ 1.18%)2.28s2.32sp=0.016 n=6
Check Time38.21s (± 0.30%)38.28s (± 0.19%)~38.21s38.38sp=0.228 n=6
Emit Time18.27s (± 0.42%)18.29s (± 0.27%)~18.22s18.34sp=0.574 n=6
Total Time66.76s (± 0.30%)66.96s (± 0.10%)~66.87s67.02sp=0.065 n=6
mui-docs - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols2,448,6172,448,617~~~p=1.000 n=6
Types896,282896,282~~~p=1.000 n=6
Memory used2,320,747k (± 0.00%)2,320,028k (± 0.01%)-720k (- 0.03%)2,319,804k2,320,194kp=0.005 n=6
Parse Time11.33s (± 0.58%)11.36s (± 0.38%)~11.31s11.43sp=0.470 n=6
Bind Time2.66s (± 0.51%)2.65s (± 0.88%)~2.62s2.69sp=0.869 n=6
Check Time88.72s (± 2.34%)89.93s (± 1.46%)~87.97s91.70sp=0.128 n=6
Emit Time0.34s (± 2.90%)0.36s (± 3.26%)🔻+0.02s (+ 5.91%)0.35s0.38sp=0.015 n=6
Total Time103.04s (± 1.98%)104.30s (± 1.25%)~102.40s106.03sp=0.128 n=6
self-build-src - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,225,3901,225,444+54 (+ 0.00%)~~p=0.001 n=6
Types266,584266,595+11 (+ 0.00%)~~p=0.001 n=6
Memory used2,842,573k (±13.19%)2,842,940k (±13.21%)~2,357,394k3,086,316kp=0.810 n=6
Parse Time6.78s (± 1.66%)6.69s (± 2.08%)~6.50s6.80sp=0.261 n=6
Bind Time2.13s (± 1.09%)2.15s (± 1.55%)~2.10s2.19sp=0.470 n=6
Check Time42.75s (± 0.51%)42.72s (± 0.69%)~42.28s43.05sp=1.000 n=6
Emit Time3.46s (± 3.10%)3.44s (± 1.45%)~3.39s3.51sp=0.748 n=6
Total Time55.13s (± 0.71%)55.01s (± 0.74%)~54.36s55.43sp=0.575 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,225,3901,225,444+54 (+ 0.00%)~~p=0.001 n=6
Types266,584266,595+11 (+ 0.00%)~~p=0.001 n=6
Memory used3,150,446k (± 0.01%)3,029,884k (± 9.78%)~2,424,404k3,151,951kp=0.936 n=6
Parse Time7.03s (± 0.62%)6.99s (± 2.01%)~6.75s7.14sp=0.873 n=6
Bind Time2.13s (± 0.71%)2.13s (± 1.55%)~2.10s2.19sp=0.629 n=6
Check Time43.01s (± 0.36%)42.83s (± 0.49%)~42.43s42.99sp=0.173 n=6
Emit Time3.45s (± 2.03%)3.46s (± 2.60%)~3.33s3.57sp=0.810 n=6
Total Time55.63s (± 0.33%)55.40s (± 0.58%)~54.80s55.72sp=0.230 n=6
self-compiler - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols262,278262,299+21 (+ 0.01%)~~p=0.001 n=6
Types106,628106,636+8 (+ 0.01%)~~p=0.001 n=6
Memory used439,852k (± 0.01%)440,116k (± 0.01%)+264k (+ 0.06%)440,076k440,159kp=0.005 n=6
Parse Time2.88s (± 0.36%)2.89s (± 0.86%)~2.86s2.91sp=0.461 n=6
Bind Time1.10s1.10s~~~p=1.000 n=6
Check Time15.77s (± 0.12%)15.73s (± 0.20%)-0.04s (- 0.29%)15.69s15.77sp=0.028 n=6
Emit Time1.31s (± 0.92%)1.30s (± 1.13%)~1.29s1.33sp=0.133 n=6
Total Time21.06s (± 0.16%)21.02s (± 0.18%)~20.97s21.07sp=0.126 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors7070~~~p=1.000 n=6
Symbols226,062226,062~~~p=1.000 n=6
Types94,48894,488~~~p=1.000 n=6
Memory used371,577k (± 0.01%)371,598k (± 0.02%)~371,525k371,699kp=0.748 n=6
Parse Time2.90s (± 1.33%)2.89s (± 1.22%)~2.86s2.94sp=0.686 n=6
Bind Time1.58s (± 0.65%)1.60s (± 1.42%)+0.02s (+ 1.48%)1.58s1.64sp=0.040 n=6
Check Time16.46s (± 0.44%)16.51s (± 0.24%)~16.44s16.55sp=0.146 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time20.94s (± 0.49%)21.00s (± 0.33%)~20.92s21.09sp=0.199 n=6
vscode - node (v18.15.0, x64)
Errors33~~~p=1.000 n=6
Symbols3,220,2823,220,282~~~p=1.000 n=6
Types1,107,9001,107,900~~~p=1.000 n=6
Memory used3,286,953k (± 0.01%)3,286,265k (± 0.01%)-688k (- 0.02%)3,286,012k3,286,473kp=0.005 n=6
Parse Time14.09s (± 0.21%)14.06s (± 0.29%)~14.00s14.11sp=0.124 n=6
Bind Time4.49s (± 0.44%)4.48s (± 0.39%)~4.46s4.51sp=0.224 n=6
Check Time88.78s (± 1.40%)86.66s (± 0.41%)-2.12s (- 2.39%)86.26s87.10sp=0.031 n=6
Emit Time27.70s (± 1.82%)28.49s (± 0.41%)+0.79s (+ 2.86%)28.35s28.69sp=0.005 n=6
Total Time135.06s (± 0.67%)133.69s (± 0.33%)-1.37s (- 1.02%)133.19s134.34sp=0.037 n=6
webpack - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols291,463291,463~~~p=1.000 n=6
Types118,920118,920~~~p=1.000 n=6
Memory used445,314k (± 0.05%)445,167k (± 0.03%)~444,998k445,349kp=0.230 n=6
Parse Time4.11s (± 0.81%)4.11s (± 1.36%)~4.03s4.17sp=1.000 n=6
Bind Time1.77s (± 0.94%)1.76s (± 1.06%)~1.74s1.79sp=0.684 n=6
Check Time18.89s (± 0.31%)18.77s (± 0.75%)~18.64s19.04sp=0.065 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time24.77s (± 0.36%)24.64s (± 0.69%)~24.42s24.94sp=0.172 n=6
xstate-main - node (v18.15.0, x64)
Errors55~~~p=1.000 n=6
Symbols552,233552,233~~~p=1.000 n=6
Types184,971184,971~~~p=1.000 n=6
Memory used492,394k (± 0.04%)492,235k (± 0.03%)~492,009k492,369kp=0.066 n=6
Parse Time3.43s (± 0.65%)3.43s (± 0.85%)~3.40s3.47sp=1.000 n=6
Bind Time1.18s (± 0.54%)1.19s (± 0.98%)~1.18s1.21sp=0.070 n=6
Check Time19.58s (± 0.97%)19.57s (± 1.04%)~19.39s19.94sp=0.872 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time24.20s (± 0.77%)24.19s (± 0.83%)~24.02s24.56sp=1.000 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

tsserver

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen2,821ms (± 1.15%)2,839ms (± 0.82%)~2,799ms2,857msp=0.471 n=6
Req 2 - geterr7,086ms (±10.93%)6,613ms (± 9.15%)~6,340ms7,849msp=0.128 n=6
Req 3 - references386ms (± 8.51%)350ms (± 2.53%)~343ms367msp=0.128 n=6
Req 4 - navto357ms (± 5.27%)315ms (±13.60%)~273ms377msp=0.108 n=6
Req 5 - completionInfo count1,3571,357~~~p=1.000 n=6
Req 5 - completionInfo125ms (± 9.16%)126ms (±12.01%)~104ms140msp=0.936 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen3,152ms (± 9.20%)2,988ms (± 0.50%)~2,972ms3,009msp=0.470 n=6
Req 2 - geterr5,582ms (±10.27%)5,169ms (±11.64%)~4,776ms5,968msp=0.093 n=6
Req 3 - references425ms (± 9.74%)433ms (± 7.65%)~370ms465msp=1.000 n=6
Req 4 - navto375ms (± 1.75%)379ms (± 3.50%)~355ms390msp=0.230 n=6
Req 5 - completionInfo count1,5191,519~~~p=1.000 n=6
Req 5 - completionInfo117ms (± 9.47%)116ms (± 7.86%)~106ms128msp=0.936 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen6,507ms (± 0.41%)6,803ms (± 6.07%)🔻+296ms (+ 4.55%)6,482ms7,345msp=0.045 n=6
Req 2 - geterr1,552ms (±11.52%)1,613ms (±11.06%)~1,377ms1,757msp=0.298 n=6
Req 3 - references120ms (±12.89%)110ms (± 7.72%)~93ms115msp=0.227 n=6
Req 4 - navto611ms (± 2.70%)602ms (± 2.61%)~582ms630msp=0.226 n=6
Req 5 - completionInfo count3,4503,450~~~p=1.000 n=6
Req 5 - completionInfo1,324ms (± 1.66%)1,344ms (± 2.03%)~1,300ms1,366msp=0.199 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

startup

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
tsc-startup - node (v18.15.0, x64)
Execution time184.78ms (± 0.17%)184.67ms (± 0.19%)-0.12ms (- 0.06%)182.44ms188.12msp=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time287.76ms (± 0.30%)287.80ms (± 0.29%)~280.42ms291.49msp=0.301 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time272.28ms (± 0.30%)272.22ms (± 0.32%)~264.95ms284.87msp=0.092 n=600
typescript-startup - node (v18.15.0, x64)
Execution time272.79ms (± 0.34%)272.62ms (± 0.32%)-0.16ms (- 0.06%)265.00ms278.66msp=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the combinedUpdateGraphExperiments branch January 10, 2025 18:28
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@DanielRosenwasser@typescript-bot@sandersn@andrewbranch