Uh oh!
There was an error while loading. Please reload this page.
Don't emit redundant and invalid extra renamed keyword exports in JS files - #62104
Don't emit redundant and invalid extra renamed keyword exports in JS files#62104Mateusz Burzyński (Andarist) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where TypeScript was emitting redundant and invalid extra renamed keyword exports in JavaScript declaration files. The change addresses a bug where exports using JavaScript keywords as export names (like export { _null as null }) were generating unnecessary additional export declarations.
- Removes logic that created redundant export declarations for keyword exports
- Simplifies the private symbol handling logic by using logical OR assignment
- Cleans up unnecessary variable tracking for export declarations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| jsDeclarationsKeywordExport1.ts | Test case demonstrating exports with keyword names (null, void) |
| jsDeclarationsKeywordExport1.types | Expected type output for the test case |
| jsDeclarationsKeywordExport1.symbols | Expected symbol resolution for the test case |
| jsDeclarationsKeywordExport1.js | Expected compiled output including declaration file |
| checker.ts | Core fix removing redundant export declaration generation logic |
Comments suppressed due to low confidence (1)
| context.approximateLength += 16 + internalSymbolName.length; // `export default internalName;` | ||
| addResult(factory.createExportAssignment(/*modifiers*/ undefined, /*isExportEquals*/ false, factory.createIdentifier(internalSymbolName)), ModifierFlags.None); | ||
| } | ||
| else if (needsExportDeclaration) { |
There was a problem hiding this comment.
this was originally added by Wesley Wigham (@weswigham) in #38982
I tried to think of a potential missing test case, but I couldn't find one. Perhaps this just became handled by other code paths since this was introduced
TypeScript Bot (typescript-bot)
commented
Mar 24, 2026
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
fixes#62081
cc Wesley Wigham (@weswigham)Nathan Shively-Sanders (@sandersn)