Skip to content

Move Iterable/AsyncIterable into main DOM/WebWorker libs - #62111

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:jabaile/dom-es6
Oct 2, 2025
Merged

Move Iterable/AsyncIterable into main DOM/WebWorker libs#62111
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:jabaile/dom-es6

Conversation

@jakebailey

@jakebaileyJake Bailey (jakebailey) commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Related #54500
Fixes#60959

This PR moves the contents of DOM.Iterable and DOM.AsyncIterable into DOM. DOM now references es2015 and es2018.asynciterable. DOM is now effectively evergreen.

(Same applies to webworker)

TODO:

@typescript-botTypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 23, 2025
@jakebailey

Jake Bailey (jakebailey) commented Jul 23, 2025

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) test it
TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
pack this✅ Started✅ Results
test top400✅ Started👀 Results
user test this✅ Started✅ Results
run dt✅ Started👀 Results
perf test this faster✅ Started👀 Results

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/165729/artifacts?artifactName=tgz&fileId=850BA94CBF29B1799E021F58C6D50FAEA15105D55C1C30A291718B1340BEEDF502&fileName=/typescript-5.9.0-insiders.20250723.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.9.0-pr-62111-2".;

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-collections
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
16:11 error TypeScript@local compile error: Duplicate identifier 'IteratorResult' @definitelytyped/expect
41:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
47:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
61:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
67:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
83:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
83:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>' @definitelytyped/expect
96:23 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
97:47 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
98:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
98:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>' @definitelytyped/expect
✖ 11 problems (11 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-shim
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
1:11 error TypeScript@local compile error: Duplicate identifier 'IteratorResult' @definitelytyped/expect
240:5 error TypeScript@local compile error: All declarations of 'EPSILON' must have identical modifiers @definitelytyped/expect
275:5 error TypeScript@local compile error: All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers @definitelytyped/expect
282:5 error TypeScript@local compile error: All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers @definitelytyped/expect
338:5 error TypeScript@local compile error: All declarations of 'flags' must have identical modifiers @definitelytyped/expect
502:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
567:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
576:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
587:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
597:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
612:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
612:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>' @definitelytyped/expect
624:23 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
625:48 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
626:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
626:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>' @definitelytyped/expect
✖ 16 problems (16 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250723/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-Unions - node (v18.15.0, x64)
Errors3434~~~p=1.000 n=6
Symbols62,37062,370~~~p=1.000 n=6
Types50,38650,386~~~p=1.000 n=6
Memory used192,994k (± 0.09%)194,258k (± 0.91%)~192,910k196,553kp=0.173 n=6
Parse Time1.31s (± 0.48%)1.30s (± 0.69%)~1.29s1.31sp=0.070 n=6
Bind Time0.73s0.73s~~~p=1.000 n=6
Check Time9.73s (± 0.31%)9.75s (± 0.22%)~9.72s9.78sp=0.418 n=6
Emit Time2.74s (± 0.48%)2.74s (± 1.00%)~2.71s2.78sp=0.868 n=6
Total Time14.51s (± 0.16%)14.52s (± 0.22%)~14.47s14.55sp=0.570 n=6
angular-1 - node (v18.15.0, x64)
Errors5656~~~p=1.000 n=6
Symbols948,914948,717-197 (- 0.02%)~~p=0.001 n=6
Types410,884410,884~~~p=1.000 n=6
Memory used1,226,383k (± 0.00%)1,226,332k (± 0.00%)~1,226,267k1,226,372kp=0.128 n=6
Parse Time6.51s (± 0.49%)6.52s (± 1.01%)~6.45s6.62sp=0.872 n=6
Bind Time1.87s (± 0.28%)1.88s (± 0.27%)~1.87s1.88sp=0.311 n=6
Check Time32.01s (± 0.25%)32.05s (± 0.54%)~31.84s32.30sp=0.687 n=6
Emit Time14.80s (± 0.89%)14.79s (± 0.41%)~14.70s14.86sp=0.471 n=6
Total Time55.20s (± 0.20%)55.24s (± 0.37%)~54.92s55.45sp=0.521 n=6
mui-docs - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols2,542,8182,542,538-280 (- 0.01%)~~p=0.001 n=6
Types900,360900,360~~~p=1.000 n=6
Memory used2,829,317k (± 0.01%)2,829,140k (± 0.01%)~2,828,874k2,829,347kp=0.173 n=6
Parse Time8.74s (± 0.27%)8.75s (± 0.28%)~8.72s8.79sp=0.295 n=6
Bind Time2.25s (± 0.33%)2.25s (± 0.37%)~2.25s2.27sp=0.652 n=6
Check Time85.86s (± 0.43%)85.86s (± 0.80%)~84.93s86.97sp=0.810 n=6
Emit Time1.32s (±84.36%)0.99s (±96.40%)~0.30s2.37sp=0.624 n=6
Total Time98.17s (± 1.15%)97.87s (± 1.46%)~96.27s100.07sp=0.575 n=6
self-build-src - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,227,0481,227,048~~~p=1.000 n=6
Types267,470267,470~~~p=1.000 n=6
Memory used2,423,932k (± 6.14%)2,667,832k (±13.45%)~2,362,968k3,095,006kp=0.173 n=6
Parse Time5.22s (± 1.09%)5.27s (± 0.94%)~5.21s5.33sp=0.128 n=6
Bind Time1.78s (± 1.36%)1.78s (± 1.16%)~1.74s1.80sp=1.000 n=6
Check Time35.25s (± 0.61%)35.43s (± 0.83%)~35.05s35.84sp=0.335 n=6
Emit Time3.00s (± 0.74%)2.96s (± 2.03%)~2.86s3.02sp=0.295 n=6
Total Time45.27s (± 0.41%)45.44s (± 0.67%)~45.09s45.88sp=0.378 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,227,0481,227,048~~~p=1.000 n=6
Types267,470267,470~~~p=1.000 n=6
Memory used2,797,186k (±14.25%)2,676,014k (±14.05%)~2,431,948k3,161,939kp=1.000 n=6
Parse Time6.81s (± 1.38%)6.76s (± 1.56%)~6.68s6.92sp=0.575 n=6
Bind Time2.23s (± 2.58%)2.20s (± 2.61%)~2.11s2.26sp=0.377 n=6
Check Time42.93s (± 1.05%)42.82s (± 0.54%)~42.55s43.03sp=0.471 n=6
Emit Time3.54s (± 2.51%)3.56s (± 2.92%)~3.45s3.73sp=0.748 n=6
Total Time55.50s (± 0.96%)55.36s (± 0.53%)~54.93s55.62sp=0.471 n=6
self-compiler - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols262,548262,548~~~p=1.000 n=6
Types107,156107,156~~~p=1.000 n=6
Memory used441,936k (± 0.02%)441,918k (± 0.02%)~441,804k441,999kp=0.689 n=6
Parse Time4.40s (± 1.04%)4.36s (± 0.43%)~4.33s4.38sp=0.077 n=6
Bind Time1.63s (± 0.67%)1.62s (± 0.50%)~1.61s1.63sp=0.383 n=6
Check Time23.46s (± 0.36%)23.41s (± 0.29%)~23.33s23.53sp=0.423 n=6
Emit Time1.91s (± 0.39%)1.89s (± 1.04%)~1.86s1.91sp=0.054 n=6
Total Time31.40s (± 0.39%)31.28s (± 0.20%)~31.18s31.35sp=0.149 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors7171~~~p=1.000 n=6
Symbols225,367225,367~~~p=1.000 n=6
Types94,29094,290~~~p=1.000 n=6
Memory used371,134k (± 0.01%)371,108k (± 0.01%)~371,068k371,181kp=0.575 n=6
Parse Time2.90s (± 1.36%)2.88s (± 0.92%)~2.84s2.91sp=0.574 n=6
Bind Time1.60s (± 0.88%)1.60s (± 1.55%)~1.57s1.64sp=0.746 n=6
Check Time16.43s (± 0.36%)16.46s (± 0.21%)~16.40s16.50sp=0.520 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time20.92s (± 0.29%)20.94s (± 0.28%)~20.87s21.01sp=0.936 n=6
vscode - node (v18.15.0, x64)
Errors11~~~p=1.000 n=6
Symbols3,530,6783,530,396-282 (- 0.01%)~~p=0.001 n=6
Types1,191,8461,191,846~~~p=1.000 n=6
Memory used3,579,300k (± 0.00%)3,579,141k (± 0.00%)-159k (- 0.00%)3,579,033k3,579,203kp=0.013 n=6
Parse Time15.13s (± 0.46%)15.21s (± 0.74%)~15.06s15.35sp=0.192 n=6
Bind Time4.90s (± 0.29%)5.14s (±12.65%)~4.86s6.47sp=0.295 n=6
Check Time101.02s (± 1.65%)100.41s (± 4.12%)~95.95s105.91sp=0.378 n=6
Emit Time33.05s (±17.79%)30.63s (± 1.00%)~30.25s31.00sp=0.689 n=6
Total Time154.09s (± 4.08%)151.40s (± 2.53%)~147.85s156.77sp=0.298 n=6
webpack - node (v18.15.0, x64)
Errors22~~~p=1.000 n=6
Symbols320,544321,546+1,002 (+ 0.31%)~~p=0.001 n=6
Types140,017140,553+536 (+ 0.38%)~~p=0.001 n=6
Memory used476,545k (± 0.04%)477,783k (± 0.01%)+1,238k (+ 0.26%)477,692k477,857kp=0.005 n=6
Parse Time4.29s (± 0.34%)4.30s (± 0.61%)~4.26s4.33sp=0.291 n=6
Bind Time1.78s (± 1.35%)1.79s (± 0.76%)~1.78s1.81sp=0.292 n=6
Check Time20.56s (± 0.58%)20.67s (± 0.70%)~20.45s20.80sp=0.199 n=6
Emit Time0.00s (±244.70%)0.00s~~~p=0.405 n=6
Total Time26.64s (± 0.45%)26.76s (± 0.55%)~26.57s26.91sp=0.108 n=6
xstate-main - node (v18.15.0, x64)
Errors3030~~~p=1.000 n=6
Symbols662,663663,032+369 (+ 0.06%)~~p=0.001 n=6
Types197,635197,637+2 (+ 0.00%)~~p=0.001 n=6
Memory used569,753k (± 0.03%)570,525k (± 0.03%)+772k (+ 0.14%)570,334k570,663kp=0.005 n=6
Parse Time4.28s (± 0.71%)4.27s (± 0.65%)~4.23s4.31sp=0.570 n=6
Bind Time1.33s (± 1.46%)1.33s (± 0.78%)~1.31s1.34sp=0.512 n=6
Check Time20.03s (± 1.85%)20.13s (± 1.82%)~19.84s20.60sp=0.229 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time25.64s (± 1.44%)25.73s (± 1.54%)~25.41s26.24sp=0.378 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

BuilderIO/mitosis

17 of 25 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.build.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

test/tsconfig.json

@jakebaileyJake Bailey (jakebailey) changed the title Move DOM.Iterable contents to DOM, make DOM reference ES6/ES2015Move DOM.Iterable/AsyncIterable into DOMSep 26, 2025
@jakebailey

Jake Bailey (jakebailey) commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) test it
TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
pack this✅ Started✅ Results
test top400✅ Started👀 Results
user test this✅ Started✅ Results
run dt✅ Started👀 Results
perf test this faster✅ Started👀 Results

@jakebaileyJake Bailey (jakebailey) mentioned this pull request Sep 26, 2025
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166122/artifacts?artifactName=tgz&fileId=7B6A18782044AA0878CE0A4D17063B28412FDB4CE2EA3B982ABD6A9D2B9ECE1A02&fileName=/typescript-6.0.0-insiders.20250926.tgz"
}
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@6.0.0-pr-62111-9".;

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-shim
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
1:11 error TypeScript@local compile error: Duplicate identifier 'IteratorResult' @definitelytyped/expect
240:5 error TypeScript@local compile error: All declarations of 'EPSILON' must have identical modifiers @definitelytyped/expect
275:5 error TypeScript@local compile error: All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers @definitelytyped/expect
282:5 error TypeScript@local compile error: All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers @definitelytyped/expect
338:5 error TypeScript@local compile error: All declarations of 'flags' must have identical modifiers @definitelytyped/expect
502:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
567:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
576:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
587:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
597:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
612:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
612:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>' @definitelytyped/expect
624:23 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
625:48 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
626:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
626:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>' @definitelytyped/expect
✖ 16 problems (16 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: wicg-file-system-access
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/index.d.ts
149:9 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property '[Symbol.asyncIterator]' must be of type '() => FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>', but here has type '{ (): FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>; (): AsyncIterableIterator<[string, FileSystemFileHandle | FileSystemDirectoryHandle]>; }' @definitelytyped/expect
/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/wicg-file-system-access-tests.ts
56:30 error TypeScript@local compile error: Property 'getFile' does not exist on type 'FileSystemHandle' @definitelytyped/expect
58:43 error TypeScript@local compile error: Argument of type 'FileSystemHandle' is not assignable to parameter of type 'FileSystemDirectoryHandle'.
Type 'FileSystemHandle' is missing the following properties from type 'FileSystemDirectoryHandle': getDirectoryHandle, getFileHandle, removeEntry, resolve, and 7 more @definitelytyped/expect
✖ 3 problems (3 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-collections
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
16:11 error TypeScript@local compile error: Duplicate identifier 'IteratorResult' @definitelytyped/expect
41:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
47:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
61:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
67:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
83:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
83:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>' @definitelytyped/expect
96:23 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
97:47 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
98:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
98:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>' @definitelytyped/expect
✖ 11 problems (11 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20250926/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-Unions - node (v18.15.0, x64)
Errors3434~~~p=1.000 n=6
Symbols62,37062,370~~~p=1.000 n=6
Types50,38650,386~~~p=1.000 n=6
Memory used195,188k (± 1.04%)195,785k (± 0.72%)~192,897k196,455kp=0.810 n=6
Parse Time1.57s (± 1.48%)1.61s (± 1.14%)+0.04s (+ 2.22%)1.58s1.63sp=0.028 n=6
Bind Time0.88s (± 1.18%)0.87s (± 0.93%)~0.86s0.88sp=0.546 n=6
Check Time11.72s (± 0.45%)11.72s (± 0.52%)~11.67s11.81sp=1.000 n=6
Emit Time3.43s (± 4.38%)3.39s (± 4.74%)~3.27s3.61sp=0.936 n=6
Total Time17.60s (± 1.00%)17.59s (± 0.77%)~17.46s17.78sp=0.688 n=6
angular-1 - node (v18.15.0, x64)
Errors11~~~p=1.000 n=6
Symbols948,914948,766-148 (- 0.02%)~~p=0.001 n=6
Types410,884410,928+44 (+ 0.01%)~~p=0.001 n=6
Memory used1,245,615k (± 0.00%)1,245,563k (± 0.01%)~1,245,440k1,245,681kp=0.128 n=6
Parse Time6.54s (± 0.62%)6.53s (± 0.83%)~6.46s6.59sp=1.000 n=6
Bind Time1.87s (± 0.28%)1.87s (± 0.52%)~1.86s1.89sp=0.504 n=6
Check Time32.21s (± 0.35%)32.16s (± 0.25%)~32.06s32.27sp=0.422 n=6
Emit Time14.80s (± 0.35%)14.78s (± 0.43%)~14.67s14.84sp=0.748 n=6
Total Time55.42s (± 0.17%)55.34s (± 0.23%)~55.15s55.48sp=0.378 n=6
mui-docs - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols2,544,6182,544,351-267 (- 0.01%)~~p=0.001 n=6
Types903,213903,216+3 (+ 0.00%)~~p=0.001 n=6
Memory used2,830,018k (± 0.00%)2,829,930k (± 0.01%)~2,829,635k2,830,063kp=0.471 n=6
Parse Time8.72s (± 0.37%)8.71s (± 0.34%)~8.68s8.75sp=0.462 n=6
Bind Time2.21s (± 0.67%)2.19s (± 0.24%)-0.02s (- 0.98%)2.18s2.19sp=0.010 n=6
Check Time86.51s (± 0.98%)86.52s (± 0.95%)~85.73s88.05sp=1.000 n=6
Emit Time0.62s (±124.58%)0.31s (± 1.68%)~0.30s0.31sp=0.784 n=6
Total Time98.06s (± 1.20%)97.73s (± 0.84%)~96.95s99.23sp=0.810 n=6
self-build-src - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,237,0641,237,064~~~p=1.000 n=6
Types259,743259,743~~~p=1.000 n=6
Memory used2,364,171k (± 0.01%)2,485,784k (±11.94%)~2,364,361k3,092,216kp=0.066 n=6
Parse Time5.12s (± 1.05%)5.14s (± 1.32%)~5.03s5.24sp=0.687 n=6
Bind Time1.77s (± 0.62%)1.78s (± 0.77%)~1.76s1.80sp=0.357 n=6
Check Time35.14s (± 0.29%)35.28s (± 0.46%)~35.07s35.57sp=0.054 n=6
Emit Time3.01s (± 1.31%)3.00s (± 1.00%)~2.96s3.04sp=0.747 n=6
Total Time45.05s (± 0.29%)45.20s (± 0.51%)~44.98s45.64sp=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,237,0641,237,064~~~p=1.000 n=6
Types259,743259,743~~~p=1.000 n=6
Memory used3,158,255k (± 0.01%)3,157,422k (± 0.02%)-833k (- 0.03%)3,156,561k3,158,576kp=0.045 n=6
Parse Time6.87s (± 1.05%)6.79s (± 0.66%)-0.08s (- 1.12%)6.73s6.85sp=0.045 n=6
Bind Time2.14s (± 0.87%)2.15s (± 0.90%)~2.12s2.17sp=0.373 n=6
Check Time42.57s (± 0.24%)42.54s (± 0.44%)~42.34s42.83sp=0.936 n=6
Emit Time3.53s (± 1.85%)3.54s (± 1.31%)~3.49s3.61sp=1.000 n=6
Total Time55.10s (± 0.25%)55.03s (± 0.28%)~54.88s55.28sp=0.336 n=6
self-compiler - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols262,412262,412~~~p=1.000 n=6
Types103,924103,924~~~p=1.000 n=6
Memory used440,564k (± 0.04%)440,471k (± 0.02%)~440,349k440,545kp=0.689 n=6
Parse Time2.87s (± 0.65%)2.88s (± 0.36%)~2.86s2.89sp=0.684 n=6
Bind Time1.11s (± 0.73%)1.11s (± 0.46%)~1.11s1.12sp=0.929 n=6
Check Time15.85s (± 0.27%)15.87s (± 0.17%)~15.84s15.90sp=0.685 n=6
Emit Time1.32s (± 0.78%)1.31s (± 0.92%)~1.30s1.33sp=0.675 n=6
Total Time21.16s (± 0.13%)21.17s (± 0.10%)~21.14s21.20sp=0.293 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors7272~~~p=1.000 n=6
Symbols225,367225,367~~~p=1.000 n=6
Types94,29094,290~~~p=1.000 n=6
Memory used370,072k (± 0.05%)370,013k (± 0.05%)~369,881k370,342kp=0.575 n=6
Parse Time2.85s (± 0.54%)2.84s (± 0.73%)~2.81s2.86sp=0.250 n=6
Bind Time1.61s (± 1.09%)1.59s (± 1.41%)~1.56s1.63sp=0.255 n=6
Check Time16.47s (± 0.18%)16.44s (± 0.42%)~16.36s16.54sp=0.335 n=6
Emit Time0.00s (±244.70%)0.00s (±244.70%)~0.00s0.01sp=1.000 n=6
Total Time20.93s (± 0.18%)20.88s (± 0.41%)~20.79s21.01sp=0.229 n=6
vscode - node (v18.15.0, x64)
Errors34🔻+1 (+33.33%)~~p=0.001 n=6
Symbols3,884,5243,884,386-138 (- 0.00%)~~p=0.001 n=6
Types1,222,6241,222,727+103 (+ 0.01%)~~p=0.001 n=6
Memory used3,700,830k (± 0.01%)3,700,824k (± 0.01%)~3,700,446k3,701,079kp=0.873 n=6
Parse Time15.11s (± 0.68%)15.27s (± 0.49%)+0.16s (+ 1.06%)15.15s15.35sp=0.031 n=6
Bind Time4.94s (± 0.59%)4.91s (± 0.54%)~4.87s4.94sp=0.076 n=6
Check Time102.40s (± 3.21%)102.29s (± 3.66%)~98.86s108.10sp=0.810 n=6
Emit Time35.58s (±17.79%)33.23s (±12.25%)~30.45s39.60sp=0.689 n=6
Total Time158.03s (± 3.37%)155.70s (± 4.55%)~149.97s167.93sp=0.378 n=6
webpack - node (v18.15.0, x64)
Errors3838~~~p=1.000 n=6
Symbols361,753362,835+1,082 (+ 0.30%)~~p=0.001 n=6
Types158,862159,472+610 (+ 0.38%)~~p=0.001 n=6
Memory used516,461k (± 0.01%)519,853k (± 0.02%)+3,392k (+ 0.66%)519,784k519,971kp=0.005 n=6
Parse Time4.43s (± 0.48%)4.45s (± 1.02%)~4.40s4.52sp=0.517 n=6
Bind Time1.92s (± 1.89%)1.94s (± 1.75%)~1.90s1.98sp=0.517 n=6
Check Time21.80s (± 0.35%)21.97s (± 0.42%)+0.17s (+ 0.76%)21.83s22.09sp=0.020 n=6
Emit Time0.00s (±244.70%)0.00s (±244.70%)~0.00s0.01sp=1.000 n=6
Total Time28.16s (± 0.39%)28.36s (± 0.40%)+0.21s (+ 0.73%)28.21s28.48sp=0.020 n=6
xstate-main - node (v18.15.0, x64)
Errors3030~~~p=1.000 n=6
Symbols672,791673,174+383 (+ 0.06%)~~p=0.001 n=6
Types201,962201,964+2 (+ 0.00%)~~p=0.001 n=6
Memory used574,873k (± 0.02%)575,586k (± 0.03%)+713k (+ 0.12%)575,336k575,773kp=0.005 n=6
Parse Time4.17s (± 0.61%)4.20s (± 0.70%)+0.03s (+ 0.72%)4.15s4.24sp=0.043 n=6
Bind Time1.35s (± 1.21%)1.34s (± 0.99%)~1.32s1.36sp=0.553 n=6
Check Time20.62s (± 2.10%)20.48s (± 1.46%)~20.20s20.88sp=0.520 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time26.13s (± 1.72%)26.03s (± 1.13%)~25.78s26.41sp=0.689 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@jakebailey

Jake Bailey (jakebailey) commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Kagami Sascha Rosylight (@saschanaz) Just as an FYI, this is something we're planning on taking for 6.0, to settle this all once and for all. So, DOM will once again be evergreen.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Kagami Sascha Rosylight (@saschanaz) Just as an FYI, this is something we're planning on taking for 6.0, to settle this all once and for all. So, DOM will once again be evergreen.

Cool. While we are at it, can we please stop calling it DOM (or at least add an alias)? That's very very small portion of what we have in the lib...

@typescript-bot

TypeScript Bot (typescript-bot) commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

11 of 25 projects failed to build with the old tsc and were ignored

packages/api/tsconfig.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

test/tsconfig.json

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Update DOM-lib-generator to do this

Do you have a plan how to do this? Add another subdirectory in baselines?

@jakebailey

Jake Bailey (jakebailey) commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Yes, same diff as we did for the 5.8/5.6 dirs; I will send a patch soon.

@jakebailey

Jake Bailey (jakebailey) commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Cool. While we are at it, can we please stop calling it DOM (or at least add an alias)? That's very very small portion of what we have in the lib...

I don't see this happening, really ☹️

What would you suggest, if you had to choose? web?

@jakebaileyJake Bailey (jakebailey) mentioned this pull request Sep 26, 2025
Merged
@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What would you suggest, if you had to choose? web?

either web or webapi. I'd be fine having dom as a legacy alias of a new name, but it should really not be the only name 🥺

@jakebaileyJake Bailey (jakebailey) mentioned this pull request Sep 26, 2025
Merged
@jakebailey

Jake Bailey (jakebailey) commented Oct 2, 2025

Copy link
Copy Markdown
MemberAuthor

TypeScript Bot (@typescript-bot) test it

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
test top400✅ Started👀 Results
user test this✅ Started✅ Results
run dt✅ Started👀 Results
perf test this faster✅ Started👀 Results

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-shim
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
1:11 error TypeScript@local compile error: Duplicate identifier 'IteratorResult' @definitelytyped/expect
240:5 error TypeScript@local compile error: All declarations of 'EPSILON' must have identical modifiers @definitelytyped/expect
275:5 error TypeScript@local compile error: All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers @definitelytyped/expect
282:5 error TypeScript@local compile error: All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers @definitelytyped/expect
338:5 error TypeScript@local compile error: All declarations of 'flags' must have identical modifiers @definitelytyped/expect
502:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
567:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
576:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
587:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
597:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
612:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
612:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>' @definitelytyped/expect
624:23 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
625:48 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
626:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
626:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>' @definitelytyped/expect
✖ 16 problems (16 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: wicg-file-system-access
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/index.d.ts
149:9 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property '[Symbol.asyncIterator]' must be of type '() => FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>', but here has type '{ (): FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>; (): AsyncIterableIterator<[string, FileSystemFileHandle | FileSystemDirectoryHandle]>; }' @definitelytyped/expect
/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/wicg-file-system-access-tests.ts
56:30 error TypeScript@local compile error: Property 'getFile' does not exist on type 'FileSystemHandle' @definitelytyped/expect
58:43 error TypeScript@local compile error: Argument of type 'FileSystemHandle' is not assignable to parameter of type 'FileSystemDirectoryHandle'.
Type 'FileSystemHandle' is missing the following properties from type 'FileSystemDirectoryHandle': getDirectoryHandle, getFileHandle, removeEntry, resolve, and 7 more @definitelytyped/expect
✖ 3 problems (3 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-collections
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
16:11 error TypeScript@local compile error: Duplicate identifier 'IteratorResult' @definitelytyped/expect
41:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
47:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
61:5 error TypeScript@local compile error: All declarations of 'size' must have identical modifiers @definitelytyped/expect
67:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
83:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
83:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>' @definitelytyped/expect
96:23 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
97:47 error TypeScript@local compile error: Type 'T' does not satisfy the constraint 'object' @definitelytyped/expect
98:5 error TypeScript@local compile error: All declarations of 'prototype' must have identical modifiers @definitelytyped/expect
98:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>' @definitelytyped/expect
✖ 11 problems (11 errors, 0 warnings)
at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251002/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-Unions - node (v18.15.0, x64)
Errors3434~~~p=1.000 n=6
Symbols62,37062,370~~~p=1.000 n=6
Types50,38650,386~~~p=1.000 n=6
Memory used194,530k (± 1.09%)196,380k (± 0.07%)~196,168k196,554kp=0.471 n=6
Parse Time1.59s (± 1.22%)1.58s (± 1.16%)~1.55s1.60sp=0.607 n=6
Bind Time0.88s (± 0.59%)0.89s (± 1.56%)~0.87s0.91sp=0.242 n=6
Check Time11.73s (± 0.32%)11.71s (± 0.50%)~11.63s11.78sp=0.377 n=6
Emit Time3.41s (± 4.23%)3.32s (± 3.04%)~3.26s3.53sp=0.416 n=6
Total Time17.61s (± 0.66%)17.50s (± 0.78%)~17.40s17.77sp=0.093 n=6
angular-1 - node (v18.15.0, x64)
Errors22~~~p=1.000 n=6
Symbols954,914955,117+203 (+ 0.02%)~~p=0.001 n=6
Types415,571415,619+48 (+ 0.01%)~~p=0.001 n=6
Memory used1,254,044k (± 0.00%)1,254,601k (± 0.00%)+557k (+ 0.04%)1,254,542k1,254,668kp=0.005 n=6
Parse Time6.53s (± 0.64%)6.51s (± 1.29%)~6.45s6.66sp=0.374 n=6
Bind Time1.88s (± 0.48%)1.88s (± 0.29%)~1.88s1.89sp=0.341 n=6
Check Time32.20s (± 0.38%)32.20s (± 0.26%)~32.11s32.35sp=1.000 n=6
Emit Time14.84s (± 0.33%)14.88s (± 0.50%)~14.79s14.97sp=0.336 n=6
Total Time55.46s (± 0.23%)55.47s (± 0.32%)~55.25s55.68sp=0.872 n=6
mui-docs - node (v18.15.0, x64)
Errors11~~~p=1.000 n=6
Symbols557,130556,863-267 (- 0.05%)~~p=0.001 n=6
Types8989~~~p=1.000 n=6
Memory used836,650k (± 0.01%)836,510k (± 0.01%)-139k (- 0.02%)836,464k836,678kp=0.030 n=6
Parse Time10.57s (± 0.35%)10.58s (± 0.30%)~10.52s10.62sp=0.683 n=6
Bind Time2.71s (± 0.75%)2.70s (± 0.56%)~2.68s2.72sp=0.330 n=6
Check Time0.00s0.00s~~~p=1.000 n=6
Emit Time0.34s (± 2.63%)0.34s (± 2.22%)~0.33s0.35sp=0.798 n=6
Total Time13.62s (± 0.24%)13.61s (± 0.24%)~13.56s13.64sp=0.936 n=6
self-build-src - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,237,2201,237,220~~~p=1.000 n=6
Types259,836259,836~~~p=1.000 n=6
Memory used2,852,829k (±13.15%)3,095,493k (± 0.03%)~3,093,975k3,096,126kp=0.173 n=6
Parse Time6.60s (± 1.76%)6.62s (± 0.67%)~6.54s6.66sp=0.689 n=6
Bind Time2.15s (± 1.60%)2.14s (± 1.40%)~2.10s2.18sp=0.687 n=6
Check Time42.40s (± 0.42%)42.56s (± 0.37%)~42.32s42.80sp=0.128 n=6
Emit Time3.48s (± 2.36%)3.49s (± 2.43%)~3.40s3.61sp=0.810 n=6
Total Time54.62s (± 0.53%)54.80s (± 0.44%)~54.44s55.16sp=0.471 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,237,2201,237,220~~~p=1.000 n=6
Types259,836259,836~~~p=1.000 n=6
Memory used3,159,315k (± 0.02%)3,037,652k (± 9.73%)~2,433,785k3,159,291kp=0.093 n=6
Parse Time6.85s (± 0.53%)6.79s (± 1.48%)~6.60s6.89sp=0.261 n=6
Bind Time2.16s (± 0.81%)2.17s (± 0.86%)~2.15s2.19sp=0.676 n=6
Check Time42.55s (± 0.26%)42.48s (± 0.76%)~42.03s42.96sp=0.575 n=6
Emit Time3.53s (± 2.57%)3.54s (± 4.41%)~3.36s3.82sp=0.810 n=6
Total Time55.11s (± 0.30%)54.97s (± 0.83%)~54.35s55.41sp=0.936 n=6
self-compiler - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols262,524262,524~~~p=1.000 n=6
Types104,015104,015~~~p=1.000 n=6
Memory used440,594k (± 0.02%)440,633k (± 0.01%)~440,596k440,696kp=0.336 n=6
Parse Time3.52s (± 1.03%)3.51s (± 1.23%)~3.45s3.57sp=0.686 n=6
Bind Time1.32s (± 0.62%)1.32s (± 1.12%)~1.30s1.34sp=0.508 n=6
Check Time18.99s (± 0.39%)19.02s (± 0.60%)~18.90s19.17sp=0.748 n=6
Emit Time1.52s (± 1.58%)1.53s (± 0.89%)~1.50s1.54sp=0.188 n=6
Total Time25.35s (± 0.21%)25.37s (± 0.58%)~25.20s25.58sp=0.810 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors7272~~~p=1.000 n=6
Symbols225,367225,367~~~p=1.000 n=6
Types94,29094,290~~~p=1.000 n=6
Memory used370,144k (± 0.06%)370,131k (± 0.03%)~370,020k370,265kp=0.936 n=6
Parse Time2.85s (± 1.83%)2.85s (± 0.91%)~2.81s2.87sp=1.000 n=6
Bind Time1.61s (± 1.08%)1.60s (± 0.75%)~1.59s1.62sp=0.188 n=6
Check Time16.45s (± 0.28%)16.45s (± 0.33%)~16.38s16.50sp=1.000 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time20.91s (± 0.31%)20.90s (± 0.31%)~20.79s20.97sp=0.747 n=6
vscode - node (v18.15.0, x64)
Errors56🔻+1 (+20.00%)~~p=0.001 n=6
Symbols3,903,0453,902,896-149 (- 0.00%)~~p=0.001 n=6
Types1,228,3051,228,385+80 (+ 0.01%)~~p=0.001 n=6
Memory used3,715,736k (± 0.01%)3,715,631k (± 0.01%)~3,715,351k3,715,922kp=0.378 n=6
Parse Time15.35s (± 0.21%)15.30s (± 0.51%)~15.21s15.41sp=0.258 n=6
Bind Time4.93s (± 0.70%)4.92s (± 0.33%)~4.91s4.95sp=0.871 n=6
Check Time102.44s (± 3.06%)102.09s (± 2.56%)~99.41s106.35sp=0.810 n=6
Emit Time33.80s (±19.73%)35.77s (± 7.87%)~30.64s37.79sp=0.173 n=6
Total Time156.52s (± 3.58%)158.10s (± 2.46%)~154.08s164.28sp=0.471 n=6
webpack - node (v18.15.0, x64)
Errors3939~~~p=1.000 n=6
Symbols370,006371,088+1,082 (+ 0.29%)~~p=0.001 n=6
Types161,904162,501+597 (+ 0.37%)~~p=0.001 n=6
Memory used524,648k (± 0.02%)526,177k (± 0.01%)+1,528k (+ 0.29%)526,097k526,248kp=0.005 n=6
Parse Time4.46s (± 0.59%)4.47s (± 1.06%)~4.39s4.52sp=0.805 n=6
Bind Time1.91s (± 0.96%)1.92s (± 1.49%)~1.89s1.97sp=0.418 n=6
Check Time21.90s (± 0.48%)22.00s (± 0.19%)~21.95s22.06sp=0.053 n=6
Emit Time0.00s (±244.70%)0.00s~~~p=0.405 n=6
Total Time28.27s (± 0.35%)28.39s (± 0.21%)~28.27s28.43sp=0.077 n=6
xstate-main - node (v18.15.0, x64)
Errors3030~~~p=1.000 n=6
Symbols673,247673,630+383 (+ 0.06%)~~p=0.001 n=6
Types202,036202,036~~~p=1.000 n=6
Memory used575,503k (± 0.02%)576,150k (± 0.03%)+648k (+ 0.11%)576,025k576,370kp=0.005 n=6
Parse Time4.19s (± 0.85%)4.18s (± 0.65%)~4.16s4.23sp=1.000 n=6
Bind Time1.34s (± 1.19%)1.35s (± 1.58%)~1.33s1.38sp=0.462 n=6
Check Time20.61s (± 1.80%)20.75s (± 1.76%)~20.24s21.03sp=0.470 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time26.14s (± 1.40%)26.29s (± 1.49%)~25.75s26.60sp=0.575 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

12 of 25 projects failed to build with the old tsc and were ignored

packages/api/tsconfig.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

test/tsconfig.json

@jakebaileyJake Bailey (jakebailey) changed the title Move DOM.Iterable/AsyncIterable into DOMMove Iterable/AsyncIterable into main DOM/WebWorker libsOct 2, 2025
@jakebailey

Jake Bailey (jakebailey) commented Oct 2, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

DT errors are:

  • shim packages (es6-shim, es6-collections) that try to define old environments. But now DOM loads es6 so they break. Fix is probably to not include dom types in those packages, or just drop them.
  • wicg-file-system-access not matching DOM. Common problem, solvable with fixes or typesVersions.

Perf benchmark shows VS Code regressing. This is also due to wicg-file-system-access.

Top tests:

  • omnivore: not sure what's going on here. Seems unrelated but clearly it's regressing somehow. It's some langchain code so not where where DOM comes into play.
  • react-bootstrap: They are assuming they can index all CSS declaration types into HTMLElement, which doesn't work now that CSSStyleDeclaration has async members.

Neither affect a public API.

But, in general, it's just the addition of *.{,Async}Iterable that are causing this. All of these problems can happen today. So there's nothing super scary here at all.

@jakebailey
Jake Bailey (jakebailey) marked this pull request as ready for review October 2, 2025 20:33
CopilotAI reviewed Oct 2, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jakebailey
Jake Bailey (jakebailey) merged commit ced90d9 into microsoft:mainOct 2, 2025
33 checks passed
@jakebailey
Jake Bailey (jakebailey) deleted the jabaile/dom-es6 branch October 2, 2025 22:52
Closed
@NatoBoramNato Boram (NatoBoram) mentioned this pull request Feb 26, 2026
Merged
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Apr 2, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@andrewbranchAndrew Branch (andrewbranch)andrewbranch approved these changes
@RyanCavanaughRyan Cavanaugh (RyanCavanaugh)RyanCavanaugh approved these changes
@DanielRosenwasserDaniel Rosenwasser (DanielRosenwasser)Awaiting requested review from DanielRosenwasser
@sandersnNathan Shively-Sanders (sandersn)Awaiting requested review from sandersn

Assignees

@jakebaileyJake Bailey (jakebailey)

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tsconfig.json "lib": "dom" should include "dom.iterable"(?)

6 participants

@jakebailey@typescript-bot@saschanaz@andrewbranch@RyanCavanaugh