Deprecate --moduleResolution node10

[Andrew Branch (andrewbranch)]

Fixes#62200

• Adds deprecation message
• Changes default moduleResolution for --module commonjs to bundler
• Updates tests not relying on explicit node10 behavior
• Fixes a module specifier completions bug affecting everything butnode10

[TypeScript Bot (typescript-bot)]

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

[TypeScript Bot (typescript-bot)]

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Matt Bierner (@mjbvz), Kat Marchán (@zkat), and Joaquin Jares (@joj) for you. Feel free to loop in other consumers/maintainers if necessary.

[Kat Marchán (zkat)]

Looks like something you might want to stop pinging me on btw. Hope all is well! ❤️

[Andrew Branch (andrewbranch)]

Kat Marchán (@zkat) I was just working on that 😄❤️ Same to you!

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Jake Bailey (jakebailey)]

Before we do this we'll need to update DT to support non node10 resolution :(

[Andrew Branch (andrewbranch)]

I'm not sure what you mean; AFAICT nothing in DT relies on node10. You’re never allowed to specify moduleResolution; instead, it’s enforced that module is either node16 or commonjs, and in the latter case the default module resolution will silently swap from node10 to bundler, which is what we want. We should just make sure, ahead of the 6.0 release, that we handle any breakages that causes.

[Andrew Branch (andrewbranch)]

656 of 9071 currently use --module commonjs. For most of them, IIRC that means a few years ago they couldn’t be automatically migrated to node16. bundler should be an easier migration for them, though there could still be errors from misconfigured upstream package.json "exports".

[Jake Bailey (jakebailey)]

Yeah, you're right.

[Sheetal Nandi (sheetalkamat)]

I think we also need to change resolution mode in resolveLibrary options ? https://github.com/microsoft/TypeScript/blob/main/src/compiler/moduleNameResolver.ts#L1388C32-L1388C52

[Andrew Branch (andrewbranch)]

TypeScript Bot (@typescript-bot) cherry-pick this to tsgo-port

[TypeScript Bot (typescript-bot)]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick this to tsgo-port	✅ Started	✅ Results

[TypeScript Bot (typescript-bot)]

Hey, Andrew Branch (@andrewbranch)! I've created #62637 for you.