Uh oh!
There was an error while loading. Please reload this page.
Explicitly set strict: false for project tests, eval tests, and more programmatic fourslash tests - #63024
Conversation
There was a problem hiding this comment.
Pull request overview
This PR explicitly sets strict: false for existing tests that rely on non-strict mode behavior, as part of the larger effort (#62333) to make --strict the default in TypeScript. The changes ensure these tests continue to work correctly once the default is changed.
Changes:
- Added
"strict": falseto 72 project test configuration JSON files - Updated corresponding baseline JSON files to reflect the new configuration
- Added
// @strict: falsedirective to 10 fourslash test files - Added
strict: falseto theevaluateTypeScriptfunction's default compiler options
Reviewed changes
Copilot reviewed 260 out of 260 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/project/*.json (72 files) | Added "strict": false to project test configurations |
| tests/baselines/reference/project//.json (144 files) | Updated baseline files to reflect the new strict:false setting |
| tests/cases/fourslash/*.ts (10 files) | Added // @strict: false compiler directive |
| src/harness/evaluatorImpl.ts | Added strict: false to default compiler options for eval tests |
Jake Bailey (jakebailey)
left a comment
There was a problem hiding this comment.
Do the evaluator tests really need strict? Or just alwaysStrict?
Uh oh!
There was an error while loading. Please reload this page.
I believe they do - I think they consider any diagnostics to be a "syntax error". |
Part of #62333.
"strict": falseline added to each project file.evaluateTypeScripttests assumestrictis implicitly off.// @strict: falseI think with this PR and #63023, we may be able to just flip the
strictswitch, accept baselines, and have tests pass.