Adds the visitor API foundation for tree transformations. by rbuckton · Pull Request #6892 · microsoft/TypeScript

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) · 2016-02-04T02:25:10Z

This provides the basic foundation for tree transformations. The additions include:

factory.ts - Which will include a growing list of node factory functions used by various transformations.
visitor.ts - The various visitor functions used for visiting the tree.

The visitNode function is used to visit single-node branches of a tree. It also provides a facility for converting an array of nodes (in the form of a NodeArrayNode) into a single node, for cases such as converting a single-statement branch of an IterationStatement into a Block.

The visitNodes function is used to visit an array of nodes. If there are no changes to any node in the array (all visited nodes have the same reference and the same number of nodes were written), then the original array is returned. This allows for faster change detection in visitEachChild by way of reference equality checks.

The visitEachNode function is used as a fallback mechanism to recursively apply a visitor to each branch of the tree. This function leverages nodeEdgeTraversalMap, which is used to describe which properties should be traversed as well as how to verify the tree.

The LexicalEnvironment interface will be leveraged in a later revision to provide a mechanism for hoisting temporary variables and function declarations.

Examples

The following is an example of a visitor that could be used with these helpers:

functionvisitor(node: Node){switch(node.kind){caseSyntaxKind.BinaryExpression:
returnvisitBinaryExpression(<BinaryExpression>node);
...
default:
returnvisitEachChild(node,visitor);}}functionvisitBinaryExpression(node: BinaryExpression){if(node.operatorToken.kind===SyntaxKind.AsteriskAsteriskToken){returncreateCall(createPropertyAccess(createIdentifier("Math"),"pow"),[visitNode(node.left,visitor,isExpressionNode),visitNode(node.right,visitor,isExpressionNode)]);}else{returnvisitEachChild(node,visitor);}}

Related Pull Requests:

Adds the visitor API foundation for tree transformations. #6892 - Adds the visitor API foundation for tree transformations.
Adds the Transform Flags concept for tree transformations #6983 - Adds the Transform Flags concept for tree transformations.
Adds the transformFiles API for tree transformations #6986 - Adds the transformFiles API for tree transformations.
Adds a simplified pretty printer for tree transformations #6987 - Adds a simplified pretty printer for tree transformations.
Adds the TypeScript transformer #7191 - Adds the TypeScript transformer.
Adds the JSX transformer #7192 - Adds the JSX transformer.
Adds the ES7 transformer #7193 - Adds the ES7 transformer.
Adds the ES6 transformer #7194 - Adds the ES6 transformer.
Adds the Module transformers #7206 - Adds the Module transformer.

Ron Buckton (rbuckton) · 2016-02-04T02:29:45Z

Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) I will be publishing a series of pull requests targeting the transforms branch, which is a recent branch of master. This way I am able to break up this work into smaller, more easily reviewed chunks. I also will regularly merge from master into transforms to keep it in sync. Once the transformation work is fully integrated into transforms, there will be a single PR to merge transforms into master.

Ron Buckton (rbuckton) · 2016-02-04T02:31:04Z

Another PR with the second layer of the transformations API will be published tomorrow.

Ron Buckton (rbuckton) · 2016-02-04T02:32:18Z

CC: Yui (@yuit), Daniel Rosenwasser (@DanielRosenwasser), Ryan Cavanaugh (@RyanCavanaugh), Vladimir Matveev (@vladima)

I want to make sure I have a lot of eyes on this implementation as we move forward.

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-04T04:52:04Z

+ }
+
+ export function createNodeArrayNode<T extends Node>(elements?: (T | NodeArrayNode<T>)[]): NodeArrayNode<T> {
+ const array = <NodeArrayNode<T>>createNodeArray(elements);


Can you feed NodeArrayNode<T> as a type argument instead?

It would end up being createNodeArray<T | NodeArrayNode<T>, NodeArrayNode<T>>(elements)), which isn't as clear.

…baselines.

Ron Buckton (rbuckton) · 2016-02-08T20:43:20Z

CC: Nathan Shively-Sanders (@sandersn)

Daniel Rosenwasser (DanielRosenwasser) · 2016-02-09T00:57:26Z

+/* @internal */
+namespace ts {
+ let NodeConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;
+ let SourceFileConstructor: new (kind: SyntaxKind, pos: number, end: number) => Node;


Is there any reason you need to do this again instead of leveraging ts.createNode?

This is partly performance related, as the ts namespace is horribly deoptimized in v8, but also due to the fact I have a slightly different call signature.

…-es7

…-es6

…-module

Adds the Module transformers

Adds the ES6 transformer

Adds the ES7 transformer

Adds the JSX transformer

Adds the TypeScript transformer

Adds a simplified pretty printer for tree transformations

Adds the transformFiles API for tree transformations

Adds the Transform Flags concept for tree transformations

Adds the visitor API foundation for tree transformations.

Added visitor API
c3faf0f

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Feb 4, 2016

removed unused function
3855261

DanielRosenwasser reviewed Feb 4, 2016
View reviewed changes

Ron Buckton (rbuckton) added 8 commits February 4, 2016 11:57

Adds transform flags aggregation to binder and visitor
cadda66

Added ArrayKind, moved createNode, changed JSDocParsing tests to use …
f8e574f
…baselines.

Cleanup and reorganization of node tests
8bf176a

Merge branch 'transforms-visitor' into transforms-flags
ba9181c

Adds the transformFiles API
1e35593

Moved createNode back to parser, added local createNode to factory
b3e9d26

Merge branch 'transforms-visitor' into transforms-flags
34489a4

Merge branch 'transforms-flags' into transforms-transformer
cbb910a

DanielRosenwasser reviewed Feb 9, 2016
View reviewed changes

Ron Buckton (rbuckton) added 2 commits February 9, 2016 11:01

PR Feedback
af24b16

Merge branch 'transforms-visitor' into transforms-flags
1a0b877

Ron Buckton (rbuckton) mentioned this pull request Feb 9, 2016
Adds the Transform Flags concept for tree transformations #6983
Merged

Ron Buckton (rbuckton) added 3 commits February 9, 2016 11:43

Moved TreansformFlags assertions after markers
51dd27a

Merge branch 'transforms-flags' into transforms-transformer
6fa4002

Moved LexicalEnvironment to types.ts, minor fixes
0f2bbb1

Ron Buckton (rbuckton) mentioned this pull request Feb 9, 2016
Adds the transformFiles API for tree transformations #6986
Merged

Ron Buckton (rbuckton) added 3 commits February 9, 2016 13:43

Added printer
6b381ec

Fixed linter error
fb19e81

Merge branch 'transforms-transformer' into transforms-printer
e545f1b

Ron Buckton (rbuckton)and others added 26 commits March 2, 2016 15:20

Merge branch 'transforms-printer' into transforms-transformer-ts
e66e51d

Switched to onEmitNode
8b35af4

Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
1fdaf74

Merge branch 'transforms-transformer-jsx' into transforms-transformer…
593fbd4
…-es7

Merge branch 'transforms-transformer-es7' into transforms-transformer…
7b28b48
…-es6

Switched to onEmitNode
1c73818

Merge branch 'transforms-transformer-es6' into transforms-transformer…
c4a75ba
…-module

Switched to onEmitNode
72eebdb

Fixed invalid assertion in ts transformer
1cf183b

General fixes and cleanup
d89e21a

Moved modifier related flags to separate enum
5b8cf96

Removed ModifiersArray
99e6ad8

Add support for array return values from visitors
47cdfbe

Removed NodeArrayNode in favor of arrays
2699bf9

cleaned up assertions and removed flattenNodes.
94018a1

Fixed perf issue in binder, plus PR feedback
ad0dd4e

Updated baselines
44ca7d4

PR Feedback
ae7843d

Merge pull request#7206from Microsoft/transforms-transformer-module
3c5f170
Adds the Module transformers

Merge pull request#7194from Microsoft/transforms-transformer-es6
07a3d18
Adds the ES6 transformer

Merge pull request#7193from Microsoft/transforms-transformer-es7
cc00f4c
Adds the ES7 transformer

Merge pull request#7192from Microsoft/transforms-transformer-jsx
829a9df
Adds the JSX transformer

Merge pull request#7191from Microsoft/transforms-transformer-ts
ca9148e
Adds the TypeScript transformer

Merge pull request#6987from Microsoft/transforms-printer
85ae53d
Adds a simplified pretty printer for tree transformations

Merge pull request#6986from Microsoft/transforms-transformer
a212e2b
Adds the transformFiles API for tree transformations

Merge pull request#6983from Microsoft/transforms-flags
f9cb493
Adds the Transform Flags concept for tree transformations

Ron Buckton (rbuckton) added a commit that referenced this pull request Mar 18, 2016
Merge pull request#6892from Microsoft/transforms-visitor
5732a60
Adds the visitor API foundation for tree transformations.

Ron Buckton (rbuckton) merged commit 5732a60 into transformsMar 18, 2016

Ron Buckton (rbuckton) deleted the transforms-visitor branch March 18, 2016 23:40

Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018