Skip to content

Lanugage Service support for union types - #861

Merged
Mohamed Hegazy (mhegazy) merged 12 commits into
unionTypesfrom
unionTypesLS
Oct 11, 2014
Merged

Lanugage Service support for union types#861
Mohamed Hegazy (mhegazy) merged 12 commits into
unionTypesfrom
unionTypesLS

Conversation

@mhegazy

Copy link
Copy Markdown
Contributor

Completions kind, Quick Info, go to def, and find all refss

@danquirk

Copy link
Copy Markdown
Member

Probably could use some fourslash tests for generic type inference and type guards

…ies of the union type but are properties on of one of its constituant types
@DanielRosenwasser

Copy link
Copy Markdown
Member

👍

Comment threadsrc/services/services.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Mohamed Hegazy (mhegazy) added a commit that referenced this pull request Oct 11, 2014
Lanugage Service support for union types
@mhegazy
Mohamed Hegazy (mhegazy) merged commit eee1602 into unionTypesOct 11, 2014
@mhegazy
Mohamed Hegazy (mhegazy) deleted the unionTypesLS branch October 14, 2014 00:15
@microsoftMicrosoft (microsoft) locked and limited conversation to collaborators Jun 18, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mhegazy@danquirk@DanielRosenwasser@CyrusNajmabadi@JsonFreeman