Update of glob-style pattern matching by riknoll · Pull Request #8841 · microsoft/TypeScript

Richard Knoll (riknoll) · 2016-05-26T17:33:59Z

This is a resubmission of #5980 that has been brought up to date with master (the old PR had a lot of non-trivial merge conflicts with the current master). The behavior differs somewhat from the specification in #5980 to better reflect the current behavior of the compiler. Excluded patterns now default to the common package directories (node_modules, bower_components, etc.) when "exclude" is not found in tsconfig.json. Additionally, the out directory is always excluded unless explicitly included in "files".

Mohamed Hegazy (@mhegazy)Ron Buckton (@rbuckton)Bill Ticehurst (@billti) please take a look when you have a moment!

…ry' API.

Conflicts: Jakefile.js src/compiler/commandLineParser.ts src/compiler/core.ts src/compiler/sys.ts src/harness/harness.ts src/server/editorServices.ts src/services/shims.ts tests/cases/unittests/cachingInServerLSHost.ts

Conflicts: src/compiler/sys.ts src/harness/harnessLanguageService.ts tests/cases/unittests/cachingInServerLSHost.ts tests/cases/unittests/tsconfigParsing.ts

Microsoft Contribution License Agreements (msftclas) · 2016-05-26T17:34:04Z

Hi Richard Knoll (@riknoll), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Richard Knoll). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Richard Knoll (riknoll) · 2016-06-17T17:56:10Z

Ron Buckton (@rbuckton) could you take a look when you have a moment?

Ron Buckton (rbuckton) · 2016-06-17T21:52:54Z

+ continue;
+ }
+
+ if (IgnoreFileNamePattern.test(file)) {


nit: capitalization - ignoreFileNamePattern

Richard Knoll (riknoll) · 2016-06-20T21:06:18Z

Ron Buckton (@rbuckton) thanks!

Basarat Ali Syed (basarat) · 2016-06-20T23:05:25Z

wow 🎉 🌹

Mohamed Hegazy (mhegazy) · 2016-06-20T23:31:19Z

//CC: Basarat Ali Syed (@basarat), Johannes Rieken (@jrieken), Blake Embrey (@blakeembrey)James Brantly (@jbrantly), Adi Dahiya (@adidahiya), Alex Eagle (@alexeagle), martine

this change has a breaking change to the public API, changing the arguments to ParseConfigHost.readDirectory and System.readDirectory, from

readDirectory(rootDir: string,extension: string,exclude: string[]): string[];

to:

readDirectory(rootDir: string,extensions: string[],excludes: string[],includes: string[]): string[];

Please do let us know if this is something that manageable on your side or more changes needs to be done on the TS side.

John Reilly (johnnyreilly) · 2016-06-22T19:40:37Z

Awesome!😃

Evan Martin (evmar) · 2016-06-22T19:53:09Z

Mohamed Hegazy (@mhegazy) thanks for thinking of me! I didn't see any use/impl of readDirectory in Google code.

In Angular2 I found one use Alex Eagle (@alexeagle) , but it's likely easy to update:
https://github.com/angular/angular/blob/3d5bb2318454ba428b816f6aee6e6aaf427d70a7/tools/%40angular/tsc-wrapped/src/tsc.ts#L51

In general I think we (Google) don't mind too much when you change APIs, especially when it's a small change that the compiler can easily spot when we update. And usually the only reason to change an API in a large way is because it's important so we'll likely be able to make that work as well.

Mohamed Hegazy (mhegazy) · 2016-06-22T21:12:41Z

thanks martine for getting to us back on this.

This is required due to breaking change in TS, see microsoft/TypeScript#8841 (comment)

Texas Toland (texastoland) · 2016-07-07T21:29:24Z

I'm having trouble excluding arbitrarily deep node_modules. Should **/node_modules or **/node_modules/**/* do the trick?

Basarat Ali Syed (basarat) · 2016-07-07T21:35:06Z

I'm having trouble excluding arbitrarily deep node_modules.

they might still get pulled in because of import statements 🌹

Richard Knoll (riknoll) · 2016-07-07T21:42:18Z

**/node_modules should work, but Basarat Ali Syed (@basarat)'s comment about imports is also correct

Ron Buckton (rbuckton)and others added 19 commits December 3, 2015 10:44

Initial support for globs in tsconfig.json
f9ae3e4

Added caching, more tests
30575db

Merge branch 'master' into glob2
5de2fcc

Added stubs to ChakraHost interface for readDirectoryNames/readFileNames
def3ba1

Fixed typos in comments
c3c3bca

Changed name of 'reduce' method added to FileSet
bf9af46

Heavily revised implementation that relies on an updated 'readDirecto…
d857250
…ry' API.

Merge branch 'master' into glob2
247657f

more tests
94a5327

Minor update to shims.ts for forthcoming VS support for globs.
6f85fe9

Detailed comments for regular expressions and renamed some files.
d23df34

Comment cleanup
c224917

Merge branch 'master' into glob2
cde12ef

Fixed new linter warnings
c1205eb

Merge branch 'master' into glob2
084b94c
Conflicts: Jakefile.js src/compiler/commandLineParser.ts src/compiler/core.ts src/compiler/sys.ts src/harness/harness.ts src/server/editorServices.ts src/services/shims.ts tests/cases/unittests/cachingInServerLSHost.ts

Fixing linter and test errors
db85643

Bringing back excludes error and fixing faulty test
c340c88

Merge branch 'master' into glob2_merged
50f0033
Conflicts: src/compiler/sys.ts src/harness/harnessLanguageService.ts tests/cases/unittests/cachingInServerLSHost.ts tests/cases/unittests/tsconfigParsing.ts

Fixing lint errors
aa5c51c

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label May 26, 2016

Dirk Bäumer (dbaeumer) mentioned this pull request May 31, 2016
Intellisense stuck indexing when file is in an uncommon path microsoft/vscode#7017
Closed

Passing regular expressions to native hosts
0415b95

Mohamed Hegazy (mhegazy) mentioned this pull request Jun 9, 2016
Add upper limit for the program size to prevent tsserver from crashing #7486
Merged

Richard Knoll (riknoll) mentioned this pull request Jun 14, 2016
Update tsconfig schema to include glob support SchemaStore/schemastore#186
Merged

rbuckton reviewed Jun 17, 2016
View reviewed changes

Merge branch 'master' into glob2_merged
b49acd5

Richard Knoll (riknoll) merged commit 6d99b2f into masterJun 20, 2016

Mohamed Hegazy (mhegazy) deleted the glob2_merged branch June 20, 2016 23:25

Mohamed Hegazy (mhegazy) added the Breaking Change Would introduce errors in existing code label Jun 20, 2016

Mohamed Hegazy (mhegazy) modified the milestones: Community, TypeScript 2.0 Jun 20, 2016

Mohamed Hegazy (mhegazy) added the Domain: API Relates to the public API for TypeScript label Jun 20, 2016

Mohamed Hegazy (mhegazy) mentioned this pull request Jun 22, 2016
support globs in tsconfig.json files property (or just file/directory exclusions) #1927
Closed

Alex Eagle (alexeagle) added a commit to alexeagle/angular that referenced this pull request Jun 23, 2016
fix(ngc): work with typescript@next
5eddbd3
This is required due to breaking change in TS, see microsoft/TypeScript#8841 (comment)

Alex Eagle (alexeagle) added a commit to angular/angular that referenced this pull request Jun 24, 2016
fix(ngc): work with typescript@next
f463e09
This is required due to breaking change in TS, see microsoft/TypeScript#8841 (comment)

Anantha Kumaran (ananthakumaran) mentioned this pull request Jun 25, 2016
tide does not pick up .d.ts file in tsconfig.json ananthakumaran/tide#37
Closed

Glen (glen-84) mentioned this pull request Jun 25, 2016
Add an equivalent to gulp.watch on tsprojectivogabe/gulp-typescript#191
Open

Glen (glen-84) mentioned this pull request Jul 3, 2016
Add support for the glob-style pattern matching in TypeScript 2.0 ivogabe/gulp-typescript#375
Closed

Victor Costan (pwnall) mentioned this pull request Jul 5, 2016
Since TypeScript now supports filesGlob natively we definitely shouldn't expand it by default TypeStrong/atom-typescript#992
Closed

Glen (glen-84) mentioned this pull request Jul 9, 2016
Support for tsconfig.json palantir/eclipse-typescript#268
Closed

Jason Grout (jasongrout) mentioned this pull request Jul 21, 2016
Use markdown-it for rendering markdown jupyterlab/jupyterlab#499
Closed

Nathan Shively-Sanders (sandersn) mentioned this pull request Apr 27, 2017
Exclude node_modules in module resolution vuejs/vetur#161
Merged

Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018

Navigation Menu

Uh oh!

Update of glob-style pattern matching - #8841

Update of glob-style pattern matching#8841
Richard Knoll (riknoll) merged 26 commits into
masterfrom
glob2_merged

Richard Knoll (riknoll) commented May 26, 2016

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented May 26, 2016

Uh oh!

Richard Knoll (riknoll) commented Jun 17, 2016

Uh oh!

Ron Buckton (rbuckton)Jun 17, 2016

Uh oh!

Richard Knoll (riknoll) commented Jun 20, 2016

Uh oh!

Basarat Ali Syed (basarat) commented Jun 20, 2016

Uh oh!

Mohamed Hegazy (mhegazy) commented Jun 20, 2016

Uh oh!

John Reilly (johnnyreilly) commented Jun 22, 2016

Uh oh!

Evan Martin (evmar) commented Jun 22, 2016

Uh oh!

Mohamed Hegazy (mhegazy) commented Jun 22, 2016

Uh oh!

Texas Toland (texastoland) commented Jul 7, 2016

Uh oh!

Basarat Ali Syed (basarat) commented Jul 7, 2016

Uh oh!

Richard Knoll (riknoll) commented Jul 7, 2016•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Richard Knoll (riknoll) commented May 26, 2016

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented May 26, 2016

Uh oh!

Richard Knoll (riknoll) commented Jun 17, 2016

Uh oh!

Ron Buckton (rbuckton)Jun 17, 2016

Choose a reason for hiding this comment

Uh oh!

Richard Knoll (riknoll) commented Jun 20, 2016

Uh oh!

Basarat Ali Syed (basarat) commented Jun 20, 2016

Uh oh!

Mohamed Hegazy (mhegazy) commented Jun 20, 2016

Uh oh!

John Reilly (johnnyreilly) commented Jun 22, 2016

Uh oh!

Evan Martin (evmar) commented Jun 22, 2016

Uh oh!

Mohamed Hegazy (mhegazy) commented Jun 22, 2016

Uh oh!

Texas Toland (texastoland) commented Jul 7, 2016

Uh oh!

Basarat Ali Syed (basarat) commented Jul 7, 2016

Uh oh!

Richard Knoll (riknoll) commented Jul 7, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Richard Knoll (riknoll) commented Jul 7, 2016•
edited
Loading