Skip to content

Add option to bail out of jake runtests when a test fails - #8925

Closed
Deleted user (ghost) wants to merge 3 commits into
masterfrom
runtests_bail
Closed

Add option to bail out of jake runtests when a test fails#8925
Deleted user (ghost) wants to merge 3 commits into
masterfrom
runtests_bail

Conversation

@ghost

@ghostDeleted user (ghost) commented Jun 1, 2016

Copy link
Copy Markdown

Currently serial only. For parallel we would need a way to notify all other running processes to stop.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jun 1, 2016

Copy link
Copy Markdown

Hi Andy (Andrewkraft) (@Andy-MS), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Andy Hanson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@ghostghost changed the title Add option to bail out of jake runtests on when a test failsAdd option to bail out of jake runtests when a test failsJun 1, 2016
@ghost
ghost force-pushed the runtests_bail branch from 505c164 to 67e6687CompareJune 1, 2016 20:06
@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 1, 2016

Copy link
Copy Markdown
Member

👍

For parallel runs, finishWorker used to call fail for all cases when errorStatus !== undefined. Now it only does so for the last worker. It would be easy to restore that fail call behind a check on --bail.

sandersn
sandersn reviewed Jun 3, 2016
View reviewed changes
Comment threadJakefile.js Outdated
counter--;

if (bail && errorStatus !== undefined) {
failWithStatus(firstErrorStatus);

@sandersnNathan Shively-Sanders (sandersn)Jun 3, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fail with the correct number of errors? I don't think firstErrorStatus would be assigned until after the next if block.

I guess the fix would be to move below the next if block or just return errorStatus

@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 3, 2016

Copy link
Copy Markdown
Member

I commented on the commit by mistake so it doesn't show up on this page.

@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 10, 2016

Copy link
Copy Markdown
Member

Do you want to just drop the parallel commit? The parallel code is now very complex and it runs in 30-60 seconds, so there's not much point in bailing anyway.

@ghost

Deleted user (ghost) commented Jun 13, 2016

Copy link
Copy Markdown
Author

Good idea. Replacing with #9146

@ghostghost closed this Jun 13, 2016
@mhegazy
Mohamed Hegazy (mhegazy) deleted the runtests_bail branch November 2, 2017 21:02
@microsoftMicrosoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@sandersnNathan Shively-Sanders (sandersn)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msftclas@sandersn