Uh oh!
There was an error while loading. Please reload this page.
Primitive type guards are order independent - #9036
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoJun 13, 2016
Merged
Primitive type guards are order independent#9036Nathan Shively-Sanders (sandersn) merged 4 commits into
Nathan Shively-Sanders (sandersn) merged 4 commits into
Conversation
Previously, only type guards of the form `typeof x === 'string'` were allowed. Now you can write `'string' === typeof x`.
Anders Hejlsberg (ahejlsberg)
commented
Jun 8, 2016
Member
Shouldn't this also include checks of the form |
Also add a test with baselines.
Nathan Shively-Sanders (sandersn)
commented
Jun 9, 2016
MemberAuthor
Good idea. Done. |
Mohamed Hegazy (mhegazy)
commented
Jun 13, 2016
Contributor
👍 |
Nathan Shively-Sanders (sandersn)
deleted the
primitive-type-guards-are-order-independent
branch
June 13, 2016 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9020