Uh oh!
There was an error while loading. Please reload this page.
Fix emit for shorthand properties when they refer to CommonJS exports. - #9151
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 4 commits intoJun 14, 2016
Merged
Conversation
Contributor
Daniel Rosenwasser (@DanielRosenwasser) I will not merge it yet as this will have to be completely redo in transform branch. Trying to clean up "transforms" branch right now |
| function isExportReference(node: Identifier) { | ||
| const container = resolver.getReferencedExportContainer(node); | ||
| return container && container.kind !== SyntaxKind.SourceFile; | ||
| return !!container; |
Contributor
There was a problem hiding this comment.
how can the container not be a sourceFile here?
There was a problem hiding this comment.
If you had a namespace, then the container is probably a namespace (i.e. ModuleDeclaration or ModuleBlock).
Are there any other containers I need to be aware of? Potentially statics on a class?
Mohamed Hegazy (mhegazy)
commented
Jun 14, 2016
Contributor
👍 |
MemberAuthor
Yui (@yuit), Mohamed Hegazy (@mhegazy) and I feel that since this is an emit bug and that the fix is small enough, that it can be ported to the transforms branch relatively easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8826 so Yui can be more productive.