Skip to content

Emit 'Promise' decorator metadata return type for async methods - #9156

Merged
2 commits merged into
masterfrom
decorator_metadata_async
Jun 14, 2016
Merged

Emit 'Promise' decorator metadata return type for async methods#9156
2 commits merged into
masterfrom
decorator_metadata_async

Conversation

@ghost

Copy link
Copy Markdown

Fixes#8351

Comment threadsrc/compiler/emitter.ts Outdated
emitSerializedTypeNode((<FunctionLikeDeclaration>node).type);
return;
if (node && isFunctionLike(node)) {
const fn = <FunctionLikeDeclaration>node;

@yuitYui (yuit)Jun 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you inline this instead? I don't think there is a need to create another variable declaration

@yuit

Copy link
Copy Markdown
Contributor

👍

@ghost
ghost merged commit c33df01 into masterJun 14, 2016
@ghost
ghost deleted the decorator_metadata_async branch June 14, 2016 15:14
Yui (yuit) pushed a commit that referenced this pull request Jun 14, 2016
@microsoftMicrosoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yuit@msftclas