Skip to content

Please change the definitions in winrt/Microsoft.UI.Interop.h from internal linkage to inline #6563

Description

I am one of the authors of the C++/WinRT 3.0 C++ module. The current NuGet package Microsoft.WindowsAppSDK.InteractiveExperiences.2.0.13 provides a winrt/Microsoft.UI.Interop.h that uses internal linkage rather than inline. This causes every translation unit that consumes it to redundantly emit its own definitions, increasing binary size and And prevents modules from exporting these functions. Furthermore, since it is not open source, I am legally prohibited from studying its implementation. These two issues combined prevent me from modularizing it. Switching from internal linkage to inline would not constitute a breaking change for WAS.

For reference, UCRT once declared functions with internal linkage, which prevented the STL from being modularized microsoft/STL#5805. The bug report for this can be found at https://developercommunity.visualstudio.com/t/Visual-Studio-cant-find-time-function/1126857.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions