Uh oh!
There was an error while loading. Please reload this page.
Remove UserInputRequests methods - #70
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the UserInputRequests() methods from the Message, Response, ResponseUpdate, and Contents types, replacing them with a more generic Contents() method on the Response type. The motivation is to simplify the API, as demonstrated by the updated examples and alignment with the .NET implementation.
Changes:
- Removed filtering helper methods (
UserInputRequests()) that only returnedFunctionApprovalRequestContentitems - Added a generic
Contents()method on Response that returns all content types - Updated example code to iterate over all contents and filter for the desired type
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| message/content.go | Removed UserInputRequests() method from Contents type and unused iter import |
| message/message.go | Removed UserInputRequests() from Message and ResponseUpdate; added generic Contents() method to Response |
| examples/getting_started/azure_openai/step04_using_function_tools_with_approvals/main.go | Updated to use Contents() instead of UserInputRequests() |
| examples/getting_started/agent/step04_using_function_tools_with_approvals/main.go | Updated to use Contents() instead of UserInputRequests() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
It doesn't add any value, as demonstrated by the examples changes in this PR. .NET just remove it in microsoft/agent-framework#3682.