Uh oh!
There was an error while loading. Please reload this page.
Python: Fix HIL regression - #2167
Merged
Merged
Conversation
…vui HIL input does not handle stringified json strings correctly.
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a DevUI regression from #2021 where all input was stringified, but the HIL (Human-in-Loop) response extraction logic didn't handle stringified JSON correctly.
Key Changes:
- Added JSON string parsing logic to
_extract_workflow_hil_responsesmethod to handle stringified list inputs - The fix properly validates that parsed JSON is in the expected list format (ResponseInputParam) for HIL responses
- Returns
Nonefor invalid JSON, non-list parsed values, or plain text strings
Victor Dibia (victordibia)
requested review from
Dmytro Struk (dmytrostruk) and Evan Mattson (moonbox3)November 13, 2025 05:17
Victor Dibia (victordibia)
enabled auto-merge
November 13, 2025 05:17
Evan Mattson (moonbox3)
approved these changes
Nov 13, 2025
Dmytro Struk (dmytrostruk)
approved these changes
Nov 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
Aris Nguyen (arisng) pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
* fix devui regression from microsoft#2021 where all input is stringified but devui HIL input does not handle stringified json strings correctly. * update incorrect test * add devui hil input tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fix devui regression from #2021 where all input is stringified but devui HIL input does not handle stringified json strings correctly.
closes#2158
Description
Contribution Checklist