Uh oh!
There was an error while loading. Please reload this page.
.NET: Prevent streamed updates loss when resuming streaming - #2516
Merged
SergeyMenshykh merged 9 commits intoNov 28, 2025
Conversation
…anaged store or/and context provider
SergeyMenshykhtemporarily deployed
to
integration
November 28, 2025 10:01 — with 
GitHub Actions
Inactive
SergeyMenshykhtemporarily deployed
to
integration
November 28, 2025 10:01 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a critical issue with message loss during streaming resumption by adding validation to prevent unsupported scenarios. The changes ensure that continuation tokens cannot be used with custom message stores or context providers during streaming operations, where collected updates could be lost.
Key changes:
- Added validation in
ValidateStreamResumptionAllowedto prevent streaming resumption with MessageStore or AIContextProvider - Added validation to prevent continuation tokens from being used on initial runs (when thread has no ConversationId and no MessageStore)
- Updated existing tests to include ConversationId in thread and response objects to ensure tests represent realistic continuation scenarios
- Added comprehensive test coverage for all new validation scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs | Implements new validation logic to prevent streaming resumption with MessageStore or AIContextProvider, and prevents continuation tokens on initial runs |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgentTests.cs | Updates existing tests to use ConversationId and adds four new test cases covering all validation scenarios for continuation token usage |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SergeyMenshykhhad a problem deploying
to
integration
November 28, 2025 10:29 — with GitHub Actions
Error
SergeyMenshykhhad a problem deploying
to
integration
November 28, 2025 10:29 — with GitHub Actions
Error
SergeyMenshykhtemporarily deployed
to
integration
November 28, 2025 10:39 — with GitHub Actions
Inactive
SergeyMenshykhtemporarily deployed
to
integration
November 28, 2025 10:39 — with GitHub Actions
Inactive
SergeyMenshykh
enabled auto-merge
November 28, 2025 10:40
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
SergeyMenshykhhad a problem deploying
to
integration
November 28, 2025 11:34 — with GitHub Actions
Error
SergeyMenshykhhad a problem deploying
to
integration
November 28, 2025 11:34 — with GitHub Actions
Error
Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
SergeyMenshykhhad a problem deploying
to
integration
November 28, 2025 11:35 — with GitHub Actions
Failure
SergeyMenshykhhad a problem deploying
to
integration
November 28, 2025 11:35 — with GitHub Actions
Failure
This was referenced Dec 22, 2025
This was referenced Jan 9, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
Aris Nguyen (arisng) pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
…t#2516) * prevent stremed updates loss when resuming streaming with non-agent managed store or/and context provider * Update dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * throw not supported exception instead invalid operation * Update dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Co-authored-by: westey <164392973+westey-m@users.noreply.github.com> * Update dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Co-authored-by: westey <164392973+westey-m@users.noreply.github.com> * use conversation id to check if chat history is managed by agent service or not * extract background responses tests into a separate file --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
This was referenced Mar 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables scenarios that would experience message loss, such as streaming resumption with threads configured with either a custom message store or a context provider.
Closes: #1760