Uh oh!
There was an error while loading. Please reload this page.
[BREAKING] Obsoleting ReflectingExecutor in favor of source gen - #3380
Merged
Ben Thomas (alliscode) merged 17 commits intoFeb 4, 2026
Conversation
…d. Also updated Diagnostics Ids to format of MAFGENWF{NUM}…branch. This commit separates the generator core functionality from the deprecation of ReflectingExecutor. The removed changes will be re-added in a dependent branch (wf-obsolete-reflector). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit deprecates the reflection-based handler discovery approach in favor of the new [MessageHandler] attribute with source generation. Changes: - Add [Obsolete] to ReflectingExecutor<T>, IMessageHandler<T>, IMessageHandler<T,R> - Add #pragma to suppress warnings in internal reflection code - Update Concurrent sample to use new [MessageHandler] pattern - Add Directory.Build.props for samples to include generator - Add documentation files explaining the migration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ce Generators and updating some samples to use new pattern. This commit deprecates the reflection-based handler discovery approach in favor of the new [MessageHandler] attribute with source generation. Changes: - Add [Obsolete] to ReflectingExecutor<T>, IMessageHandler<T>, IMessageHandler<T,R> - Add #pragma to suppress warnings in internal reflection code - Update Concurrent sample to use new [MessageHandler] pattern - Add Directory.Build.props for samples to include generator - Add documentation files explaining the migration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ben Thomas (alliscode)temporarily deployed
to
integration
January 22, 2026 17:47 — with 
GitHub Actions
Inactive
Ben Thomas (alliscode)temporarily deployed
to
integration
January 22, 2026 17:47 — with GitHub Actions
Inactive
Ben Thomas (alliscode)
marked this pull request as ready for review
January 22, 2026 17:59
Ben Thomas (alliscode)temporarily deployed
to
integration
January 22, 2026 18:00 — with GitHub Actions
Inactive
Ben Thomas (alliscode)temporarily deployed
to
integration
January 22, 2026 18:00 — with GitHub Actions
Inactive
Ben Thomas (alliscode)
commented
Jan 22, 2026
MemberAuthor
I will hold off on merging this until the docs are updated to clearly explain the new pattern. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR obsoletes the reflection-based ReflectingExecutor<TExecutor> pattern in favor of a source generation approach using the [MessageHandler] attribute. The changes ensure backward compatibility while guiding developers to the new recommended pattern.
Changes:
- Marked
ReflectingExecutor<TExecutor>andIMessageHandler<T>interfaces as obsolete with clear migration guidance - Added pragma warnings to suppress obsolete warnings in internal code and tests that need backward compatibility
- Updated one sample executor to demonstrate the new
[MessageHandler]pattern - Added source generator project reference to the Workflows samples Directory.Build.props
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ReflectingExecutor.cs | Added [Obsolete] attribute with migration guidance to use [MessageHandler] attribute |
IMessageHandler.cs | Marked both IMessageHandler<TMessage> and IMessageHandler<TMessage, TResult> interfaces as obsolete |
Executor.cs | Added pragma to suppress obsolete warnings for internal backward compatibility |
StatefulExecutor.cs | Added pragma to suppress obsolete warnings for internal backward compatibility |
RouteBuilderExtensions.cs | Added pragma to suppress obsolete warnings for internal backward compatibility |
MessageHandlerInfo.cs | Added pragma to suppress obsolete warnings for internal backward compatibility |
01_Simple_Workflow_Sequential.cs | Added pragma to suppress obsolete warnings when testing legacy reflection-based pattern |
02_Simple_Workflow_Condition.cs | Added pragma to suppress obsolete warnings when testing legacy reflection-based pattern |
03_Simple_Workflow_Loop.cs | Added pragma to suppress obsolete warnings when testing legacy reflection-based pattern |
ReflectionSmokeTest.cs | Added pragma to suppress obsolete warnings when testing legacy reflection-based pattern |
Directory.Build.props | Added source generator project reference for samples using [MessageHandler] attribute |
Concurrent/Program.cs | Migrated ConcurrentStartExecutor from Executor<string> to base Executor with [MessageHandler] attribute |
Tao Chen (TaoChenOSU)
approved these changes
Jan 22, 2026
Peter Ibekwe (peibekwe)
approved these changes
Jan 22, 2026
This was referenced Mar 16, 2026
This was referenced Mar 23, 2026
This was referenced May 2, 2026
This was referenced May 9, 2026
Closed
Closed
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist