Uh oh!
There was an error while loading. Please reload this page.
.NET Workflows - Add unit tests for ConditionGroupExecutor - #3893
Conversation
Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
…comments Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds missing unit test coverage for ConditionGroupExecutor in the declarative workflows object model, and refactors existing tests to reuse a shared IsDiscreteAction assertion helper.
Changes:
- Add
ConditionGroupExecutorTestcovering condition evaluation, branching, and step naming. - Refactor
WorkflowActionExecutorTest/ForeachExecutorTestto centralizeIsDiscreteActionverification. - Modify
ConditionGroupExecutor.Steps.Elsebehavior (removes the prior fallback name).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/WorkflowActionExecutorTest.cs | Adjusts test execution helpers and adds a shared VerifyIsDiscrete assertion. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ForeachExecutorTest.cs | Switches inline reflection assertion to the shared VerifyIsDiscrete helper. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs | New unit tests for ConditionGroupExecutor behavior and naming conventions. |
| dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ConditionGroupExecutor.cs | Changes else-step naming behavior by removing the default fallback. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Motivation and Context
Unit test coverage for
ConditionGroupExecutorwas missing.Description
Adds
ConditionGroupExecutorTestwith 100% line coverage ofConditionGroupExecutor.Contribution Checklist