Uh oh!
There was an error while loading. Please reload this page.
.NET: fix: pass IServiceProvider to ChatClientAgent in AddAIAgent overloads - #4483
Closed
Max Montes Soza (max-montes) wants to merge 3 commits into
Closed
Conversation
Max Montes Soza (max-montes)temporarily deployed
to
integration
March 4, 2026 22:12 — with 
GitHub Actions
Inactive
Max Montes Soza (max-montes)temporarily deployed
to
integration
March 4, 2026 22:12 — with GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug (#4453) where AddAIAgent overloads in AgentHostingServiceCollectionExtensions were not forwarding the IServiceProvider to ChatClientAgent, causing tools registered via dependency injection to fail to resolve their dependencies at invocation time.
Changes:
- Pass
services: spto each of the fourChatClientAgentconstructor calls inAddAIAgentoverloads so theFunctionInvokingChatClientmiddleware receives the application's service provider. - Add four regression tests (one per overload) and a
MockChatClienthelper class to verify that theFunctionInvokingChatClientis present in the chat client pipeline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dotnet/src/Microsoft.Agents.AI.Hosting/AgentHostingServiceCollectionExtensions.cs | Adds services: sp to all four ChatClientAgent constructor calls to forward the DI container's IServiceProvider. |
dotnet/tests/Microsoft.Agents.AI.Hosting.UnitTests/AgentHostingServiceCollectionExtensionsTests.cs | Adds four regression tests and a MockChatClient class to verify the service provider is passed through each AddAIAgent overload. |
Uh oh!
There was an error while loading. Please reload this page.
Max Montes Soza (max-montes)force-pushed
the
fix/hosting-service-provider-passthrough
branch
from
March 5, 2026 00:40
cd40c83 to
8906f26CompareMax Montes Soza (max-montes)temporarily deployed
to
integration
March 5, 2026 00:40 — with GitHub Actions
Inactive
Max Montes Soza (max-montes)temporarily deployed
to
integration
March 5, 2026 00:40 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
Max Montes Soza (max-montes)force-pushed
the
fix/hosting-service-provider-passthrough
branch
from
March 5, 2026 04:39
8906f26 to
a3d7b31CompareMax Montes Soza (max-montes)temporarily deployed
to
integration
March 5, 2026 04:40 — with GitHub Actions
Inactive
Max Montes Soza (max-montes)temporarily deployed
to
integration
March 5, 2026 04:40 — with GitHub Actions
Inactive
All four AddAIAgent overloads in AgentHostingServiceCollectionExtensions were creating ChatClientAgent without forwarding the IServiceProvider. This meant tools registered via dependency injection could not resolve their dependencies at invocation time. Pass services: sp to each ChatClientAgent constructor call so that the FunctionInvokingChatClient middleware receives the application's service provider and can resolve tool dependencies correctly. Fixesmicrosoft#4453 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Montes Soza (max-montes)force-pushed
the
fix/hosting-service-provider-passthrough
branch
from
March 23, 2026 04:10
a3d7b31 to
458d4ddCompareMax Montes Soza (max-montes)temporarily deployed
to
integration
March 23, 2026 04:10 — with GitHub Actions
Inactive
Max Montes Soza (max-montes)temporarily deployed
to
integration
March 23, 2026 04:10 — with GitHub Actions
Inactive
westey (westey-m)
requested review from
SergeyMenshykh, chetantoshniwal, Peter Ibekwe (peibekwe), Roger Barreto (rogerbarreto) and westey (westey-m)
as code ownersAugust 18, 2026 17:04
westey (westey-m)temporarily deployed
to
github-app-auth
August 18, 2026 17:04 — with GitHub Actions
Inactive
westey (westey-m)had a problem deploying
to
integration
August 18, 2026 17:06 — with GitHub Actions
Error
westey (westey-m)had a problem deploying
to
integration
August 18, 2026 17:06 — with GitHub Actions
Error
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
westey (westey-m)temporarily deployed
to
github-app-auth
August 18, 2026 17:08 — with GitHub Actions
Inactive
westey (westey-m)
approved these changes
Aug 18, 2026
westey (westey-m)
enabled auto-merge
August 18, 2026 17:08
westey (westey-m)had a problem deploying
to
integration
August 18, 2026 17:11 — with GitHub Actions
Failure
westey (westey-m)temporarily deployed
to
integration
August 18, 2026 17:11 — with GitHub Actions
Inactive
SergeyMenshykh
approved these changes
Aug 18, 2026
5 tasks
westey (westey-m)
commented
Aug 18, 2026
Contributor
Closing in favour of #7737 with some test improvements. |
auto-merge was automatically disabled
August 18, 2026 17:50
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
All four AddAIAgent overloads in AgentHostingServiceCollectionExtensions were creating ChatClientAgent without forwarding the IServiceProvider. This meant tools registered via dependency injection could not resolve their dependencies at invocation time.
Description
Pass services: sp to each ChatClientAgent constructor call so that the FunctionInvokingChatClient middleware receives the application's service provider and can resolve tool dependencies correctly.
Fixes#4453
Contribution Checklist