Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Python: fix declarative workflow DevUI sample and JoinExecutor Messag… - #7206

Closed
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input
Closed

Python: fix declarative workflow DevUI sample and JoinExecutor Messag…#7206
Amit Dhawan (amit12cool) wants to merge 8 commits into
microsoft:mainfrom
amit12cool:fix/python-declarative-workflow-devui-input

Conversation

@amit12cool

@amit12coolAmit Dhawan (amit12cool) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

The workflow_declarative DevUI sample under python/samples/02-agents/devui/workflow_declarative/ was broken when run via the DevUI chat interface. Entering any age value always returned the "child" category. Four bugs caused this:

  1. workflow.yaml used =inputs.age — this only works when the workflow is invoked with a structured dict input (e.g. {"age": 25}). The DevUI sends user messages as chat text, which populates System.LastMessage.Text, not Inputs.age. As a result =inputs.age was always Blank (treated as 0 by PowerFx), causing 0 < 13 to always evaluate True → "child" for any input.

  2. workflow.yaml used turn.* namespaceturn is a .NET/Bot Framework convention. In the Python runtime, per-turn variables belong in the Local.* namespace.

  3. workflow.yaml used workflow.outputs.category (lowercase w) — the Python state engine is case-sensitive; the correct namespace is Workflow.Outputs.*.

  4. JoinExecutor did not handle a single Message trigger — when a Message (not list[Message]) was passed as the trigger, _ensure_state_initialized could not extract the user text into System.LastMessage.Text, compounding issue 1.

Description & Review Guide

  • What are the major changes?

    • workflow.yaml: replace =inputs.age with =Int(System.LastMessage.Text); replace turn.* with Local.*; fix workflow.outputs.categoryWorkflow.Outputs.category; remove the now-unused inputs: schema block
    • workflow.py: add logging.basicConfig so DevUI startup output is readable
    • _executors_control_flow.py (JoinExecutor): normalize a single Message trigger to list[Message] before passing to _ensure_state_initialized, so user text is correctly surfaced in System.LastMessage.Text
  • What is the impact of these changes?
    The DevUI sample now works correctly end-to-end. JoinExecutor also correctly handles single-message triggers in all workflows that use it.

  • What do you want reviewers to focus on?
    The JoinExecutor change in _executors_control_flow.py and whether any other executors have the same single-Message gap.

Related Issue

Fixes#7285

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

CopilotAI review requested due to automatic review settings July 20, 2026 09:36
@giles17Giles Odigwe (giles17) added the python Usage: [Issues, PRs], Target: Python label Jul 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python declarative-workflow DevUI sample so it correctly categorizes users based on age entered via the chat UI (using System.LastMessage.Text / Local.* / Workflow.Outputs.*), and updates the declarative workflow runtime so JoinExecutor properly initializes state when triggered with a single Message.

Changes:

  • Updated the DevUI sample workflow.yaml to read age from chat text, use Local.* variables, and correctly write outputs to Workflow.Outputs.*.
  • Improved DevUI sample startup logging readability by configuring logging.basicConfig(...).
  • Updated JoinExecutor to normalize a single Message trigger to list[Message] before state initialization.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
python/samples/02-agents/devui/workflow_declarative/workflow.yamlFixes expression namespaces and input source so DevUI chat input drives correct branching and output state.
python/samples/02-agents/devui/workflow_declarative/workflow.pyAdds simple logging configuration to make DevUI startup output easier to read.
python/packages/declarative/agent_framework_declarative/_workflows/_executors_control_flow.pyEnsures JoinExecutor correctly initializes state for single-Message triggers (DevUI-style).

@moonbox3

Copy link
Copy Markdown
Contributor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Per the PR guidelines, please link an issue to this PR.

PRs that are not linked to an issue may be closed, no matter how valid the change is.

Done

@github-actions

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/declarative/agent_framework_declarative/_workflows
_declarative_base.py5547287%51, 54, 119–123, 255, 370, 384, 404, 504, 572–573, 580–581, 596, 633, 675, 677–680, 684, 687–688, 690, 751–753, 755–757, 759, 762, 769, 798, 824–830, 832–833, 835–843, 864–865, 867–868, 916, 1182–1185, 1207–1208, 1215–1216, 1221, 1230–1231, 1237
_executors_control_flow.py139397%82, 90, 253
TOTAL45732426090%

Python Unit Test Overview

TestsSkippedFailuresErrorsTime
929536 💤0 ❌0 🔥2m 31s ⏱️

@moonbox3Evan Mattson (moonbox3) added the declarative Usage: [Issues, PRs], Target: declarative agents and workflows label Aug 17, 2026
@moonbox3

Copy link
Copy Markdown
Contributor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

@amit12cool

Copy link
Copy Markdown
ContributorAuthor

Please re-open when you'e ready to address the remaining open item and take this forward. Thanks.

Evan Mattson (@moonbox3) I don't seem to have the option to reopen this PR on my end. I've pushed the fixes based on your latest feedback—could you please reopen it so we can proceed with the review?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarativeUsage: [Issues, PRs], Target: declarative agents and workflowspythonUsage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Python: declarative workflow DevUI sample broken — wrong expression namespaces and JoinExecutor single-Message gap

5 participants

@amit12cool@moonbox3@peibekwe@giles17