Uh oh!
There was an error while loading. Please reload this page.
Python: Add Foundry-Features header to toolbox requests - #7696
Open
Willow Lopez (Oxygen56) wants to merge 2 commits into
Open
Python: Add Foundry-Features header to toolbox requests#7696Willow Lopez (Oxygen56) wants to merge 2 commits into
Willow Lopez (Oxygen56) wants to merge 2 commits into
Conversation
Willow Lopez (Oxygen56)
requested review from
Tao Chen (TaoChenOSU), chetantoshniwal and Eduard van Valkenburg (eavanvalkenburg)
as code ownersAugust 17, 2026 15:44
Willow Lopez (Oxygen56)temporarily deployed
to
github-app-auth
August 17, 2026 15:44 — with 
GitHub Actions
Inactive
Willow Lopez (Oxygen56)temporarily deployed
to
github-app-auth
August 17, 2026 15:44 — with GitHub Actions
Inactive
Willow Lopez (Oxygen56)temporarily deployed
to
github-app-auth
August 17, 2026 15:44 — with GitHub Actions
Inactive
Willow Lopez (Oxygen56)had a problem deploying
to
github-app-auth
August 17, 2026 15:45 — with GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for sending a mandatory Foundry toolbox preview feature flag via a Foundry-Features request header, optionally merged with platform-provided feature flags from an environment variable.
Changes:
- Add
_build_toolbox_features_header()to mergeToolboxes=V1PreviewwithFOUNDRY_AGENT_TOOLSET_FEATURES. - Update
_ToolboxAuthto inject theFoundry-Featuresheader on every request. - Add async auth-flow tests covering header composition behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
python/packages/foundry_hosting/agent_framework_foundry_hosting/_toolbox.py | Builds and injects the mandatory preview feature header into toolbox requests. |
python/packages/foundry_hosting/tests/test_toolbox.py | Adds parameterized tests validating Foundry-Features header behavior in async auth flow. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+116
to
+122
| self._features_header = _build_toolbox_features_header(os.environ.get("FOUNDRY_AGENT_TOOLSET_FEATURES")) | ||
| def _apply_headers(self, request: httpx.Request, token: AccessToken) -> None: | ||
| request.headers["Authorization"] = f"Bearer {token.token}" | ||
| for key, value in get_request_context().platform_headers().items(): | ||
| request.headers[key] = value | ||
| request.headers["Foundry-Features"] = self._features_header |
| def __init__(self, credential: AzureCredentialTypes, scope: str) -> None: | ||
| self._credential = credential | ||
| self._scope = scope | ||
| self._features_header = _build_toolbox_features_header(os.environ.get("FOUNDRY_AGENT_TOOLSET_FEATURES")) |
Comment on lines
118
to
+122
| def _apply_headers(self, request: httpx.Request, token: AccessToken) -> None: | ||
| request.headers["Authorization"] = f"Bearer {token.token}" | ||
| for key, value in get_request_context().platform_headers().items(): | ||
| request.headers[key] = value | ||
| request.headers["Foundry-Features"] = self._features_header |
Willow Lopez (Oxygen56)temporarily deployed
to
github-app-auth
August 17, 2026 16:42 — with GitHub Actions
Inactive
Willow Lopez (Oxygen56)temporarily deployed
to
github-app-auth
August 17, 2026 16:43 — with GitHub Actions
Inactive
| # Environment variable used to inject platform-provided toolbox feature flags. | ||
| _TOOLSET_FEATURES_ENV_VAR = "FOUNDRY_AGENT_TOOLSET_FEATURES" | ||
| # Mandatory preview feature flag for Foundry toolbox requests. | ||
| _MANDATORY_TOOLBOX_FEATURE = "Toolboxes=V1Preview" |
Contributor
There was a problem hiding this comment.
I believe the preview flag is obsolete. Where did you see it's still required?
Contributor
Python Test Coverage Report •
Python Unit Test Overview
| ||||||||||||||||||||||||||||||
| self._credential = credential | ||
| self._scope = scope | ||
| # Feature flags are startup configuration, matching the .NET toolbox service. | ||
| self._features_header = _build_toolbox_features_header(os.environ.get(_TOOLSET_FEATURES_ENV_VAR)) |
Contributor
There was a problem hiding this comment.
Could we capture this value once in FoundryToolbox.__init__ and pass it into each _ToolboxAuth instance? Currently _ToolboxAuth.__init__ reads FOUNDRY_AGENT_TOOLSET_FEATURES, and reconnecting after close() creates a new _ToolboxAuth. Consequently, the same FoundryToolbox instance can silently change feature flags across connections. Holding the merged value on FoundryToolbox would preserve the stated startup-configuration semantics and match the .NET service's lifetime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Python
FoundryToolboxrequests currently omit the mandatoryFoundry-Features: Toolboxes=V1Previewheader and ignoreFOUNDRY_AGENT_TOOLSET_FEATURES. This can prevent platform-provided feature flags from reaching the toolbox service and leaves Python behavior inconsistent with .NET.Description & Review Guide
FoundryToolboxrequest now carries the expected feature header without changing the public API.Related Issue
Fixes#7689
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.