Skip to content

.NET: fix: inspect for delemiter value before adding headers - #8301

Merged
Vincent Biret (baywet) merged 4 commits into
mainfrom
fix/crlf-workflow-client
Sep 11, 2026
Merged

Vincent Biret (baywet) merged 4 commits into
mainfrom
fix/crlf-workflow-client

Conversation

@baywet

Copy link
Copy Markdown
Member

adding headers without validation can lead to corrupted http requests. This fixes the issue by inspecting for end of line characters

Copilot AI balanced review requested due to automatic review settings September 11, 2026 14:17
@agent-framework-automation agent-framework-automation Bot added .NET Usage: [Issues, PRs], Target: .Net workflows Usage: [Issues, PRs], Target: Workflows labels Sep 11, 2026
@github-actions github-actions Bot changed the title fix: inspect for delemiter value before adding headers .NET: fix: inspect for delemiter value before adding headers Sep 11, 2026
@baywet
Vincent Biret (baywet) marked this pull request as draft September 11, 2026 14:19

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>

This comment was marked as outdated.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 241dc909-4fc9-4e7c-8f7c-fb969e4ce2e9
@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit 5cc25ed in the fix/crlf-workflow-cl... branch is 84%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main fix/crlf-workflow-cl... 5cc25ed +/-
/home/runner/wo...valConverter.cs 100%
/home/runner/wo...entsProvider.cs 99%
/home/runner/wo...nticAnalyzer.cs 94%
/home/runner/wo...tClientAgent.cs 91%
/home/runner/wo...putConverter.cs 90%
/home/runner/wo...kflowBuilder.cs 90%
/home/runner/wo...kflowSession.cs 87%
/home/runner/wo...SkillsSource.cs 86%
/home/runner/wo...onExtensions.cs 81%
/home/runner/wo...ctionVisitor.cs 70%

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The validation covers all unvalidated header paths and includes focused regression tests.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@baywet
Vincent Biret (baywet) marked this pull request as ready for review September 11, 2026 18:30
@baywet
Vincent Biret (baywet) added this pull request to the merge queue Sep 11, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 2

Result: No findings
Scope: 3 net-new commit(s): 630ae1922ffa, 617ecacf9667, 5cc25ed5d678
Model: gpt-5.6-sol-fast

Overview

This increment removes attacker-controlled header names from the invalid-name exception, adds direct coverage for CRLF in BodyContentType, and preserves listener cleanup across modern .NET and .NET Framework. Validation still occurs before unchecked header insertion and transport, and the added test verifies the body content-type path cannot reach the message handler. No Critical, High, or Medium defect is supported by the changed lines.

Reviewed the supplied incremental change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net workflows Usage: [Issues, PRs], Target: Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants