Uh oh!
There was an error while loading. Please reload this page.
feat: move /goal-dependent skills into app-cli and compose the skills behavior bundle - #276
Merged
Merged
Conversation
Move goal-batch and ten-lane-highway skills alongside goalify and the /goal command they depend on. This ensures amplifier-app-cli ships these skills as a self-consistent unit without requiring external bundles. These skills reference the `monitor` skill (soft/guidance dependency) which lives in amplifier-bundle-skills and is available separately. Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
app-cli now always composes amplifier-bundle-skills' behaviors/skills.yaml (tool-skills module, curated Microsoft skills collection, visibility & context instructions) regardless of which base bundle the user selects. This follows the same _build_modes_behaviors() convention established in foundation. This guarantees a tool-skills entry always exists, so the existing _ensure_default_skills_dirs() can append app-cli's own packaged data/skills directory. As a result: - app-cli's own /goal-family skills (goalify, goal-batch, ten-lane-highway) always load - amplifier-bundle-skills' curated skills (monitor, etc.) always load - Cross-source deps like ten-lane-highway → monitor resolve correctly - User gets a complete, stable skills foundation on top of any base bundle Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the
/goal-family skills to live beside the/goalcommand they depend on, and make app-cli always compose the shared skills behavior so a stock install still gets the full curated skills collection.goal-batchandten-lane-highwaytoamplifier_app_cli/data/skills/(goalifyalready shipped here)._build_skills_behaviors()inruntime/config.py(same convention as_build_modes_behaviors()), so app-cli always composesamplifier-bundle-skills'behaviors/skills.yaml— tool-skills module + curated Microsoft skills collection + visibility + context instructions — regardless of the base bundle. The existing_ensure_default_skills_dirs()then appends app-cli's own packageddata/skillsdir.Why
These skills require the
/goalcommand, which lives in app-cli. Shipping them here keeps them version-locked to the CLI that provides/goal. Composing the skills behavior guarantees atool-skillsentry always exists so both app-cli's packaged skills AND the curated collection load together, and cross-source dependencies (e.g.ten-lane-highway→monitor, which stays in amplifier-bundle-skills) resolve.Paired change
Paired with microsoft/amplifier-bundle-skills PR that removes these
/goal-dependent skills from the bundle (keepingmonitor, which has no/goaldependency). That PR link will be added as a comment.Validation
Verified end-to-end in a Digital Twin Universe (modified app-cli + modified skills-bundle, url-rewritten to the modified bundle): fresh stock install loads BOTH sources,
goalify/goal-batch/ten-lane-highwayappear exactly once each (from app-cli's wheel),monitor+ten-lane-highwayco-load in one session,/highwayshortcut present. 6/6 checks passed, zero duplicates.