fix for wrong OpenAIClientOptions used with keyed OpenAIClient(s)

[Jürgen Steinblock (Steinblock)]

with keyed OpenAIClients

builder.AddKeyedOpenAIClient("openai");
builder.AddKeyedOpenAIClient("ionos");

assuming that at least one keyed OpenAIClient has a differnt endpoint,

{
"ConnectionStrings": {
"openai": "Key={account_key};"
"ionos": "Endpoint=https://{openai_rest_api_url};Key={account_key};"
}
}

getting the client with

var client = serviceProvider.GetRequiredKeyedService<OpenAIClient>("ionos")

the client uses the key from the connectionstring but it still has the default enpoint https://api.openai.com/v1

The issue is that ConfigureOpenAI ignores the serviceKey and always get's the default OpenAIClientOptions instead of the one created with optionsName = servicekey.

This makes using keyed OpenAIClients virtually impossible because the main reason having multiple OpenAIClients is having different endpoints.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue (consider using one of the following templates):
      • New (or update) doc-idea template
      • New breaking-change template
      • New diagnostic template
  • No

[Jürgen Steinblock (Steinblock)]

@dotnet-policy-service agree

[Eric Erhardt (eerhardt)]

Can you add tests for this?

[Kumima (Kumima)]

Fixing #9543
Is this better? And did you take a look at the azure related stuff?

options=serviceProvider.GetRequiredService<IOptionsMonitor<OpenAIClientOptions>>().Get(serviceKey??Options.DefaultName);

According to: openai/openai-dotnet#215
Tests can be tricky using reflection.

[Jürgen Steinblock (Steinblock)]

Eric Erhardt (@eerhardt) I added a test case that is failing without my changes and passing afterwards.

As Kumima (@Kumima) mentioned, testing this is tricky because OpenAIClient doesn't expose the endpoint.

I don't really like the test because I usually only test the public interface of a class but I could not figure out how to workaround this so I opted for using reflection to get the endpoint.

Kumima (@Kumima)

This would work as well.

var options = serviceProvider
.GetRequiredService<IOptionsMonitor<OpenAIClientOptions>>()
.Get(serviceKey ?? Options.Options.DefaultName);

[Eric Erhardt (eerhardt)]

LGTM. Thanks for the fix!