Skip to content

[release/9.5] Fix globalPackagesFolder path to be platform-agnostic in NuGetConfigMerger - #11626

Merged
Jose Perez Rodriguez (joperezr) merged 2 commits into
release/9.5from
backport/pr-11624-to-release/9.5
Sep 29, 2025
Merged

[release/9.5] Fix globalPackagesFolder path to be platform-agnostic in NuGetConfigMerger#11626
Jose Perez Rodriguez (joperezr) merged 2 commits into
release/9.5from
backport/pr-11624-to-release/9.5

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Backport of #11624 to release/9.5

/cc Mitch Denny (@mitchdenny)Copilot

Customer Impact

Fixes a bug which makes the staging feed mechanism in the CLI break on Linux and probably macOS machines as well. Basically, NuGet doesn't do the OS translation on the globalPackagesFolder config path separator, so it ends up being something that needs to be escaped which breaks restore.

This changes what we write to this setting from .nuget\packages to .nugetpackages to sidestep this issue.

Testing

Manual, and unit test updated (found whilst dogfooding on Linux).

Risk

Low.

Regression?

CopilotAIand others added 2 commits September 24, 2025 04:39
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
ContributorAuthor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11626

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11626"

@davidfowlDavid Fowler (davidfowl) added the Servicing-approved Approved for servicing release label Sep 24, 2025
@davidfowl

Copy link
Copy Markdown
Collaborator

This is good to go.I just ran into this!

@davidfowlDavid Fowler (davidfowl) removed the Servicing-approved Approved for servicing release label Sep 24, 2025
@joperezrJose Perez Rodriguez (joperezr) added the Servicing-approved Approved for servicing release label Sep 29, 2025
@joperezr

Copy link
Copy Markdown
Member

Completing a feature added in 9.5.0, low risk. approved.

This was referenced Oct 27, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Oct 30, 2025
@sebastienros
Sébastien Ros (sebastienros) deleted the backport/pr-11624-to-release/9.5 branch January 15, 2026 23:44
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Re-opened Github-Action PRServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@davidfowl@joperezr@mitchdenny