Uh oh!
There was an error while loading. Please reload this page.
Allow for nested children in the dashboard - #7604
Merged
Eric Erhardt (eerhardt) merged 2 commits intoFeb 14, 2025
Merged
Conversation
Originally the parent-child lookup contained the "root" parent and all the descendants in a flat list. This doesn't show up well in the dashboard because grandchildren are parented directly under their root. Fix this by making the parent-child lookup only contain direct children, and recursively parent the descendants on their direct parent. Fixmicrosoft#7580
Eric Erhardt (eerhardt)
requested review from
James Newton-King (JamesNK), Copilot and David Fowler (davidfowl)February 13, 2025 19:51
Eric Erhardt (eerhardt)
requested a review
from Mitch Denny (mitchdenny)
as a code ownerFebruary 13, 2025 19:51
James Newton-King (JamesNK)
approved these changes
Feb 14, 2025
James Newton-King (JamesNK)
left a comment
Member
There was a problem hiding this comment.
Tested in TestShop and cosmos E2E and they both work:
| // the parent name needs to be an instance name, not the resource name. | ||
| // parent the children of the child under the first resource instance. | ||
| await SetChildResourceAsync(child, child.GetResolvedResourceNames()[0], state, startTimeStamp, stopTimeStamp) |
There was a problem hiding this comment.
This isn't going to work well with replicas. But I don't think that's new.
MemberAuthor
There was a problem hiding this comment.
How would you expect it to work with replicas? Which replica should the child go under?
There was a problem hiding this comment.
I don't think it can work today. Lets see if it comes up before worrying about it.
James Newton-King (JamesNK)
commented
Feb 14, 2025
Member
It would be nice if there were some unit tests of |
David Fowler (davidfowl)
commented
Feb 14, 2025
Collaborator
Backport plz |
Eric Erhardt (eerhardt)
enabled auto-merge (squash)
February 14, 2025 15:33
Eric Erhardt (eerhardt)
commented
Feb 14, 2025
MemberAuthor
/backport to release/9.1 |
Contributor
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13332369112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally the parent-child lookup contained the "root" parent and all the descendants in a flat list. This doesn't show up well in the dashboard because grandchildren are parented directly under their root.
Fix this by making the parent-child lookup only contain direct children, and recursively parent the descendants on their direct parent.
Fix#7580
Checklist