Skip to content

Bump timeout for non-helix tests - #7669

Merged
Ankit Jain (radical) merged 3 commits into
microsoft:mainfrom
radical:tests-timeout
Feb 19, 2025
Merged

Bump timeout for non-helix tests#7669
Ankit Jain (radical) merged 3 commits into
microsoft:mainfrom
radical:tests-timeout

Conversation

@radical

Copy link
Copy Markdown
Member
  • Bump timeout for non-helix tests
  • Use blame hang timeout for tests same as used for PRs

CopilotAI review requested due to automatic review settings February 19, 2025 00:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/testing/.runsettings: Language not supported

@radical

Copy link
Copy Markdown
MemberAuthor

<!-- Enables blame -->
<DataCollector friendlyName="blame" enabled="True">
<Configuration>
<CollectDumpOnTestSessionHang TestTimeout="7min" HangDumpType="Full" />

@danmoseleyDan Moseley (danmoseley)Feb 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about <CollectDump> element (for crashes)?

is "Blame" Logger element also needed?

Just looking at https://learn.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022#blame-data-collector

@radical
Ankit Jain (radical) merged commit bc07c8a into microsoft:mainFeb 19, 2025
@radical
Ankit Jain (radical) deleted the tests-timeout branch February 19, 2025 18:55
@github-actionsgithub-actionsBot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 10, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systemsinfrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@danmoseley@karolz-ms