Skip to content

Don't skip event hub health checks - #7670

Merged
Eric Erhardt (eerhardt) merged 2 commits into
mainfrom
sebros/noskiphc
Feb 19, 2025
Merged

Don't skip event hub health checks#7670
Eric Erhardt (eerhardt) merged 2 commits into
mainfrom
sebros/noskiphc

Conversation

@sebastienros

@sebastienrosSébastien Ros (sebastienros) commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Description

Event Hub singleton health check would be skipped if health checks were not supported. We don't want to not support them so removing this skipping logic.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

CopilotAI review requested due to automatic review settings February 19, 2025 00:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/Aspire.Azure.Messaging.EventHubs.Tests/ConformanceTestsBase.cs:71

  • Ensure that the behavior of running health checks regardless of support is covered by tests.
public void HealthChecksClientsAreReused()

Comment threadtests/Aspire.Azure.Messaging.EventHubs.Tests/ConformanceTestsBase.cs Outdated

@eerhardtEric Erhardt (eerhardt) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eerhardt
Eric Erhardt (eerhardt) deleted the sebros/noskiphc branch February 19, 2025 03:07
@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastienros@eerhardt