Uh oh!
There was an error while loading. Please reload this page.
[release/9.1] Follow up to WaitForResourceHealthyAsync changes. - #7673
Merged
David Fowler (davidfowl) merged 3 commits intoFeb 19, 2025
Merged
Conversation
github-actionsBot
requested a review
from Mitch Denny (mitchdenny)
as a code ownerFebruary 19, 2025 01:19
Dan Moseley (danmoseley)
approved these changes
Feb 19, 2025
Mitch Denny (mitchdenny)
approved these changes
Feb 19, 2025
Mitch Denny (mitchdenny)
commented
Feb 19, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7668 to release/9.1
/cc Mitch Denny (@mitchdenny)
Customer Impact
This is a follow up to #7664. We decided to rename the enumeration values and made some changes to the logic (adopted from a prototype branch that David Fowler (@davidfowl) put together).
Testing
Same test cases that already exist. This just renames the enumerations and tweaks the internal implementation of the method to use an inner method.
Risk
Low.
Regression?