Uh oh!
There was an error while loading. Please reload this page.
Update WaitForResourceHealthyAsync to use DefaultWaitBehavior - #7709
Merged
Mitch Denny (mitchdenny) merged 1 commit intoFeb 22, 2025
Conversation
Alex Crome (afscrome)
marked this pull request as draft
February 20, 2025 08:57
Alex Crome (afscrome)force-pushed
the
WaitForResourceHealthyAsyncDefaultWaitBehavior
branch
from
February 20, 2025 09:13
c987af5 to
a29edfdCompareAlex Crome (afscrome)
marked this pull request as ready for review
February 20, 2025 09:30
Alex Crome (afscrome)
requested a review
from Mitch Denny (mitchdenny)
as a code ownerFebruary 20, 2025 09:30
Mitch Denny (mitchdenny)
commented
Feb 22, 2025
Member
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Mitch Denny (mitchdenny)
commented
Feb 22, 2025
Member
Rerunning all jobs just to verify that this is compatible with all latest changes and then I'll merge in. |
Mitch Denny (mitchdenny)
approved these changes
Feb 22, 2025
Mitch Denny (mitchdenny)
commented
Feb 22, 2025
Member
/backport to release/9.1 |
Contributor
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13467677933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow on to #7650 - this changes makes the default behaviour if you call
WaitForResourceHealthyAsyncwithout aWaitBehaviorto useDefaultWaitBehaviorrather than hardcodeWaitOnResourceUnavailable.This makes the behaviour match
WaitForDependenciesAsyncwhenWaitForis called without aWaitBehavior, as well as improving the testing (or other dashboardless) experience by makingWaitForResourceHealthyAsyncfail fast in tests when you don't have a way to recover resources if they fail, without needing to explicitly set theWaitBehaviorIf this change is not wanted, the default test templates should be updated to include
WaitBehavior.StopOnResourceUnavailableas a follow on to #7619Fixes#7601
(Pushing this as is to see if any tests break and need adapting to this change in defaults - if any do, I'm expecting them to be tests deep in aspire internals that are unlikely to affect real end user usage, but need to confirm.)Update: Only one test failed first time, but it passes locally and succeeded on the second run
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):