Skip to content

Move shared test utilities from Aspire.Components.Common.Tests to Aspire.TestUtilities - #8279

Merged
Igor Velikorossov (RussKie) merged 2 commits into
microsoft:mainfrom
RussKie:chore_testutils
Mar 27, 2025
Merged

Move shared test utilities from Aspire.Components.Common.Tests to Aspire.TestUtilities#8279
Igor Velikorossov (RussKie) merged 2 commits into
microsoft:mainfrom
RussKie:chore_testutils

Conversation

@RussKie

@RussKieIgor Velikorossov (RussKie) commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

CopilotAI review requested due to automatic review settings March 25, 2025 02:21
CopilotAI reviewed Mar 25, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 36 out of 56 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • Aspire.sln: Language not supported
  • tests/Aspire.Azure.AI.OpenAI.Tests/Aspire.Azure.AI.OpenAI.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Data.Tables.Tests/Aspire.Azure.Data.Tables.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Messaging.EventHubs.Tests/Aspire.Azure.Messaging.EventHubs.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Messaging.ServiceBus.Tests/Aspire.Azure.Messaging.ServiceBus.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Messaging.WebPubSub.Tests/Aspire.Azure.Messaging.WebPubSub.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Search.Documents.Tests/Aspire.Azure.Search.Documents.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Security.KeyVault.Tests/Aspire.Azure.Security.KeyVault.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Storage.Blobs.Tests/Aspire.Azure.Storage.Blobs.Tests.csproj: Language not supported
  • tests/Aspire.Azure.Storage.Queues.Tests/Aspire.Azure.Storage.Queues.Tests.csproj: Language not supported
  • tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj: Language not supported
  • tests/Aspire.Components.Common.Tests/Aspire.Components.Common.Tests.csproj: Language not supported
  • tests/Aspire.Confluent.Kafka.Tests/Aspire.Confluent.Kafka.Tests.csproj: Language not supported
  • tests/Aspire.Dashboard.Tests/Aspire.Dashboard.Tests.csproj: Language not supported
  • tests/Aspire.Elastic.Clients.Elasticsearch.Tests/Aspire.Elastic.Clients.Elasticsearch.Tests.csproj: Language not supported
  • tests/Aspire.Hosting.Containers.Tests/Aspire.Hosting.Containers.Tests.csproj: Language not supported
  • tests/Aspire.Hosting.Testing.Tests/Aspire.Hosting.Testing.Tests.csproj: Language not supported
  • tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj: Language not supported
  • tests/Aspire.Keycloak.Authentication.Tests/Aspire.Keycloak.Authentication.Tests.csproj: Language not supported
  • tests/Aspire.Microsoft.Azure.Cosmos.Tests/Aspire.Microsoft.Azure.Cosmos.Tests.csproj: Language not supported

@github-actionsgithub-actionsBot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 25, 2025
@RussKie
Igor Velikorossov (RussKie)force-pushed the chore_testutils branch 3 times, most recently from 1fda196 to 4977698CompareMarch 25, 2025 04:48
radical
Ankit Jain (radical) reviewed Mar 25, 2025
View reviewed changes
Comment thread...onfigurationSchemaGenerator/RuntimeSource/Configuration.Binder/Parser/ConfigurationBinder.cs
Comment threadtests/Aspire.Microsoft.Azure.Cosmos.Tests/Aspire.Microsoft.Azure.Cosmos.Tests.csproj Outdated
Comment threadtests/Aspire.Microsoft.Data.SqlClient.Tests/Aspire.Microsoft.Data.SqlClient.Tests.csproj Outdated
@RussKie
Igor Velikorossov (RussKie)force-pushed the chore_testutils branch 4 times, most recently from c1d24c0 to 5dff61bCompareMarch 26, 2025 01:09
@radical

Ankit Jain (radical) commented Mar 26, 2025

Copy link
Copy Markdown
Member

Can you run the azdo pipeline also for this?

radical
Ankit Jain (radical) reviewed Mar 26, 2025
View reviewed changes
Comment threadtests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj
@RussKie
Igor Velikorossov (RussKie)force-pushed the chore_testutils branch 3 times, most recently from a19f352 to 1662bb3CompareMarch 27, 2025 04:02
radical
Ankit Jain (radical) reviewed Mar 27, 2025
View reviewed changes
Comment threadtests/Aspire.TestUtilities/ActivityNotifier.cs
radical
Ankit Jain (radical) approved these changes Mar 27, 2025
View reviewed changes

@radicalAnkit Jain (radical) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you! LGTM 👍

@RussKie
Igor Velikorossov (RussKie) merged commit 46b238d into microsoft:mainMar 27, 2025
@RussKie
Igor Velikorossov (RussKie) deleted the chore_testutils branch March 27, 2025 05:47
@RussKieIgor Velikorossov (RussKie) mentioned this pull request Mar 27, 2025
Merged
joperezr
Jose Perez Rodriguez (joperezr) reviewed Apr 4, 2025
View reviewed changes
Comment threadsrc/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj
<ItemGroup>
<PackageReference Include="AspNetCore.HealthChecks.SqlServer" />
<PackageReference Include="Microsoft.Data.SqlClient" />
<PackageReference Include="Microsoft.DotNet.RemoteExecutor" />

@joperezrJose Perez Rodriguez (joperezr)Apr 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igor Velikorossov (@RussKie) Assuming this was unintentional and likely a find/replace or similar issue? We need to undo this as it is obviously not okay to depend on this from the product code.

@RussKieIgor Velikorossov (RussKie)Apr 7, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing; this doesn't look correct.

@radicalAnkit Jain (radical) mentioned this pull request Apr 4, 2025
Merged
18 tasks
Igor Velikorossov (RussKie) added a commit to RussKie/aspire that referenced this pull request Apr 7, 2025
@RussKie
Constrain test-only dependencies to /tests folder
d8f96af
Follow up on microsoft#8279
@RussKieIgor Velikorossov (RussKie) mentioned this pull request Apr 7, 2025
Merged
Igor Velikorossov (RussKie) added a commit that referenced this pull request Apr 7, 2025
@RussKie
Constrain test-only dependencies to /tests folder (#8576)
4a9578a
Follow up on #8279
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardtEric Erhardt (eerhardt)eerhardt left review comments
@joperezrJose Perez Rodriguez (joperezr)joperezr left review comments
Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@radicalAnkit Jain (radical)radical approved these changes
@mitchdennyMitch Denny (mitchdenny)Awaiting requested review from mitchdennymitchdenny is a code owner
@ReubenBondReuben Bond (ReubenBond)Awaiting requested review from ReubenBond
@sebastienrosSébastien Ros (sebastienros)Awaiting requested review from sebastienrossebastienros is a code owner

Assignees

No one assigned

Labels

area-integrationsIssues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RussKie@radical@eerhardt@joperezr