Uh oh!
There was an error while loading. Please reload this page.
[release/9.2] Adding descriptions to all args/options in CLI. (#8544) - #8552
Merged
Dan Moseley (danmoseley) merged 2 commits intoApr 4, 2025
Merged
Conversation
* Adding descriptions to all args/options in CLI. * Revert project arg to option. * PR feedback. * Rename resource to integration. * Update src/Aspire.Cli/Commands/RunCommand.cs Co-authored-by: David Fowler <davidfowl@gmail.com> --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Aspire.Cli/Commands/RootCommand.cs:18
- [nitpick] The updated constructor for RootCommand now passes a lengthy help string to the base constructor instead of a short command identifier. Confirm that this change is intentional to ensure consistency with similar commands.
: base("The Aspire CLI can be used to create, run, and publish Aspire-based applications.")
David Fowler (davidfowl)
approved these changes
Apr 4, 2025
Dan Moseley (danmoseley)
approved these changes
Apr 4, 2025
Eric Erhardt (eerhardt)
commented
Apr 4, 2025
Member
I'm fixing the merge conflict |
Dan Moseley (danmoseley)
commented
Apr 4, 2025
Contributor
I was fixing it too, then github got really confused :) |
Eric Erhardt (eerhardt)
approved these changes
Apr 4, 2025
Dan Moseley (danmoseley)
enabled auto-merge (squash)
April 4, 2025 15:34
Dan Moseley (danmoseley)
deleted the
mitchdenny/cherry-pick-8544-to-release-9.2
branch
April 4, 2025 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8544 to release/9.2
/cc Mitch Denny (@mitchdenny)
Customer Impact / Notes
This PR adds improved help text to the CLI. Note that this PR also reverts one aspect of a change in pending backport #8543. That one should be merged first, then this one. A merge conflict could occur. If I am not around to resolve it myself and someone else wants to have a go - the conflict will be around the --project option on the run command being an option or an argument in S.CL.
... we want it to be an option after some further discussion.
Testing
Manually tested.
Risk
Low.
Regression?
No.