Skip to content

[tests] Re-enable some quarantined tests that haven't been failing - #8615

Merged
Ankit Jain (radical) merged 4 commits into
microsoft:mainfrom
radical:re-enable-quarantined-tests
Apr 8, 2025
Merged

[tests] Re-enable some quarantined tests that haven't been failing#8615
Ankit Jain (radical) merged 4 commits into
microsoft:mainfrom
radical:re-enable-quarantined-tests

Conversation

@radical

@radicalAnkit Jain (radical) commented Apr 8, 2025•
edited
Loading

Copy link
Copy Markdown
Member

The following issues are for tests that haven't failed in the last ~50 runs of the Outerloop Tests workflow.

Fixes#7930
Fixes#7943
Fixes#8103
Fixes#8192
Fixes#8200
Fixes#8326
Fixes#8400
Fixes#8511
Fixes#8512
Fixes#8513
Fixes#8514

Also, Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests

All these tests were using the same issue url. And haven't failed
recently in github actions.

Issue: #4651

Bump default test session timeout from 10mins to 15mins

Prompted by Aspire.Hosting.Tests taking longer.

@github-actionsgithub-actionsBot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 8, 2025
CopilotAI reviewed Apr 8, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

@radical
fix build
072c8a9
@radical
Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests
36b583c
All these tests were using the same issue url. And haven't failed
recently in github actions.
Issue: microsoft#4651
RussKie
Igor Velikorossov (RussKie) approved these changes Apr 8, 2025
View reviewed changes

@RussKieIgor Velikorossov (RussKie) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@RussKieIgor Velikorossov (RussKie) added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Apr 8, 2025
@radical
Ankit Jain (radical) enabled auto-merge (squash) April 8, 2025 07:10
@radical

Ankit Jain (radical) commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

Aspire.Hosting.Tests are taking longer than 10minutes to run.

Aborting test run: test run timeout of 600000 milliseconds exceeded.
Test Run Aborted.
Total tests: Unknown
Passed: 574
Total time: 10.0023 Minutes

@radical
Aspire.Hosting.Tests is taking longer than 10mins to run. Bump the se…
71917c1
…ssion timeout for Integration tests to 15mins
@radical

Ankit Jain (radical) commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

Bumped the default session timeout to 15mins.

@radical
Ankit Jain (radical) merged commit f9035bc into microsoft:mainApr 8, 2025
@radical
Ankit Jain (radical) deleted the re-enable-quarantined-tests branch April 8, 2025 07:42
This was referenced Apr 8, 2025
Merged
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@danmoseleyDan Moseley (danmoseley)Awaiting requested review from danmoseley
@joperezrJose Perez Rodriguez (joperezr)Awaiting requested review from joperezr
@mitchdennyMitch Denny (mitchdenny)Awaiting requested review from mitchdennymitchdenny is a code owner
@ReubenBondReuben Bond (ReubenBond)Awaiting requested review from ReubenBond
+1 more reviewer
@RussKieIgor Velikorossov (RussKie)RussKie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-engineering-systemsinfrastructure helix infra engineering repo stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: WithHttpCommand_CallsGetResponseCallback_AfterSendingRequest Flaky test: WithHttpCommandTests.WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingRequest ResourcesWithHealthCheck_StopsAndRestartsMonitoringWithResource flaky [Failing test] Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme_ReloadPage Failing test - Windows/GA - Aspire.Hosting.Testing.Tests.TestingBuilderTests.ArgsPropagateToAppHostConfiguration
[Failing test]: ResourceHealthCheckServiceTests.ResourcesWithHealthCheck_CreationErrorIsReported [Failing test]: Aspire.Hosting.Tests.OperationModesTests.VerifyBackwardsCompatableRunModeInvocation [Flaky test] Aspire.Hosting.Tests.SlimTestProgramTests.TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatch [failing test] Aspire.Hosting.Tests.SlimTestProgramTests.TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatchForReplicatedServices [failing test] Aspire.Hosting.Tests.SlimTestProgramTests.TestProjectStartsAndStopsCleanly

3 participants

@radical@RussKie