Uh oh!
There was an error while loading. Please reload this page.
Look for shipping artifacts according to the build configuration - #8616
Merged
Igor Velikorossov (RussKie) merged 1 commit intoApr 8, 2025
Merged
Conversation
Igor Velikorossov (RussKie)
requested review from
Eric Erhardt (eerhardt) and Ankit Jain (radical)
as code ownersApril 8, 2025 06:06
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/Shared/TemplatesTesting/EnvironmentVariables.cs:12
- Removing the BuildConfiguration environment variable may impact other parts of the test suite that rely on dynamic configuration. Ensure that all code paths referencing this variable are updated to reflect the new compile-time approach.
public static readonly string BuildConfiguration = Environment.GetEnvironmentVariable("BUILD_CONFIGURATION") ?? "Debug";
Uh oh!
There was an error while loading. Please reload this page.
Igor Velikorossov (RussKie)
commented
Apr 8, 2025
ContributorAuthor
Ankit Jain (radical)
approved these changes
Apr 8, 2025
Igor Velikorossov (RussKie)
enabled auto-merge (squash)
April 8, 2025 06:46
Igor Velikorossov (RussKie)
deleted the
igveliko/fix_shipping_artifacts_resolution
branch
April 8, 2025 07:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E and the Template tests look for Shipping artifacts in incorrect location, unless it is explicitly configured.
E.g., I'm build and running tests explicitly in RELEASE build, but the tests look under a Debug path...
We should expect a developer to set an additional env var, when the developer has already explicitly built in specific configuration.
Since we only have two build configs, I resorted to only #if..#else. When/if we decide to support more build configurations, we can revisit the code to extend the condition.