Skip to content

ig: add package v0.25.0 - #7777

Merged
Muhammad Falak R Wani (mfrw) merged 1 commit into
microsoft:3.0-devfrom
eiffel-fl:francis/marinade-ig
Mar 12, 2024
Merged

ig: add package v0.25.0#7777
Muhammad Falak R Wani (mfrw) merged 1 commit into
microsoft:3.0-devfrom
eiffel-fl:francis/marinade-ig

Conversation

@eiffel-fl

@eiffel-fleiffel-fl commented Feb 8, 2024•
edited by mfrw
Loading

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

This PR adds ig, the CLI flavor of Inspektor Gadget to Mariner.

Change Log
  • Add ig v0.25.0
Does this affect the toolchain?

NO

Test Methodology
$ rpm2cpio ./out/RPMS/x86_64/ig-0.25.0-1.azl3.x86_64.rpm | cpio -idmv
./usr/bin/ig
./usr/share/licenses/ig
./usr/share/licenses/ig/LICENSE
./usr/share/licenses/ig/LICENSE-bpf.txt
149181 blocs
$ ./usr/bin/ig version francis/marinade-ig *% u+1-1
v0.25.0
$ sudo ./usr/bin/ig trace exec -c foobar francis/marinade-ig *% u+1-1
RUNTIME.CONTAINERNAME PID PPID COMM RET ARGS
foobar 332783 332762 bash 0 /usr/bin/bash
foobar 332806 332783 ls 0 /usr/bin/ls

With an existing VM in the pipeline:

mariner

@eiffel-fl
eiffel-fl requested review from a team as code ownersFebruary 8, 2024 10:54
@eiffel-fl
eiffel-fl requested a review from a teamFebruary 8, 2024 10:54
@eiffel-fl
eiffel-fl requested review from a team as code ownersFebruary 8, 2024 10:54
@mfrwMuhammad Falak R Wani (mfrw) added the 3.0-dev PRs Destined for AzureLinux 3.0 label Feb 8, 2024
@mfrw
Muhammad Falak R Wani (mfrw) marked this pull request as draft February 8, 2024 12:30
@eiffel-fl
eiffel-flforce-pushed the francis/marinade-ig branch 2 times, most recently from 019b50e to 7bc0872CompareFebruary 9, 2024 05:41
@eiffel-fl
eiffel-fl marked this pull request as ready for review February 22, 2024 06:37
mfrw
Muhammad Falak R Wani (mfrw) reviewed Feb 22, 2024
View reviewed changes

@mfrwMuhammad Falak R Wani (mfrw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me :)

Comment threadSPECS/ig/ig.spec
@eiffel-fl
eiffel-flforce-pushed the francis/marinade-ig branch 2 times, most recently from 6f49d73 to 42fcaadCompareFebruary 22, 2024 10:17
mfrw
Muhammad Falak R Wani (mfrw) reviewed Feb 22, 2024
View reviewed changes
Comment threadSPECS/ig/ig.spec Outdated
@eiffel-fl
eiffel-fl requested review from a team as code ownersFebruary 23, 2024 06:42
mfrw
Muhammad Falak R Wani (mfrw) reviewed Feb 27, 2024
View reviewed changes

@mfrwMuhammad Falak R Wani (mfrw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase might be needed with the latest 3.0-dev

Comment threadSPECS/ig/ig.signatures.json Outdated
@eiffel-fleiffel-fl mentioned this pull request Feb 29, 2024
Closed
12 tasks
@mfrwMuhammad Falak R Wani (mfrw) changed the title Add ig packageig: add package v0.25.0Mar 4, 2024
mfrw
Muhammad Falak R Wani (mfrw) reviewed Mar 4, 2024
View reviewed changes

@mfrwMuhammad Falak R Wani (mfrw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need one more rebase :)
eiffel-fl

@eiffel-fl
ig: add package v0.25.0
535ff99
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
PawelWMS
Pawel Winogrodzki (PawelWMS) reviewed Mar 11, 2024
View reviewed changes
Comment threadSPECS/LICENSES-AND-NOTICES/data/licenses.json
mfrw
Muhammad Falak R Wani (mfrw) approved these changes Mar 12, 2024
View reviewed changes

@mfrwMuhammad Falak R Wani (mfrw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mfrw

Muhammad Falak R Wani (mfrw) commented Mar 12, 2024

Copy link
Copy Markdown
Member

Close & Reopen To trigger PR checks

@mfrw
Muhammad Falak R Wani (mfrw) merged commit f102317 into microsoft:3.0-devMar 12, 2024
@eiffel-fl
eiffel-fl deleted the francis/marinade-ig branch March 12, 2024 08:43
eiffel-fl added a commit to eiffel-fl/CBL-Mariner that referenced this pull request Mar 13, 2024
@eiffel-fl
ig: fix %check.
5923327
%check is not run with "set -e", so we need to ensure everything is correct
throughout the test.
Fixes: f102317 ("ig: add package v0.25.0 (microsoft#7777)")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Betty (BettyRain) pushed a commit that referenced this pull request Mar 13, 2024
@eiffel-fl@mfrwBetty Lakes
ig: add package v0.25.0 (#7777)
28ab996
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl added a commit to eiffel-fl/CBL-Mariner that referenced this pull request Mar 14, 2024
@eiffel-fl
ig: fix %check.
06d320f
%check is not run with "set -e", so we need to ensure everything is correct
throughout the test.
Fixes: f102317 ("ig: add package v0.25.0 (microsoft#7777)")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl added a commit to eiffel-fl/CBL-Mariner that referenced this pull request Mar 15, 2024
@eiffel-fl
ig: fix %check.
e293251
%check is not run with "set -e", so we need to ensure everything is correct
throughout the test.
Fixes: f102317 ("ig: add package v0.25.0 (microsoft#7777)")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl added a commit to eiffel-fl/CBL-Mariner that referenced this pull request Mar 19, 2024
@eiffel-fl
ig: fix %check.
0e1653a
%check is not run with "set -e", so we need to ensure everything is correct
throughout the test.
Fixes: f102317 ("ig: add package v0.25.0 (microsoft#7777)")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl added a commit to eiffel-fl/CBL-Mariner that referenced this pull request Mar 20, 2024
@eiffel-fl
ig: fix %check.
4bf3a09
%check is not run with "set -e", so we need to ensure everything is correct
throughout the test.
Fixes: f102317 ("ig: add package v0.25.0 (microsoft#7777)")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl added a commit to eiffel-fl/CBL-Mariner that referenced this pull request Apr 5, 2024
@eiffel-fl
ig: fix %check.
0059ab0
%check is not run with "set -e", so we need to ensure everything is correct
throughout the test.
Fixes: f102317 ("ig: add package v0.25.0 (microsoft#7777)")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
xiaohong (Xiaohong-Deng) pushed a commit to Xiaohong-Deng/azurelinux that referenced this pull request Nov 23, 2024
@eiffel-fl@mfrwxiaohongdeng
ig: add package v0.25.0 (microsoft#7777)
92633a3
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PawelWMSPawel Winogrodzki (PawelWMS)PawelWMS left review comments
@mfrwMuhammad Falak R Wani (mfrw)mfrw approved these changes

Assignees

@mfrwMuhammad Falak R Wani (mfrw)

Labels

3.0-devPRs Destined for AzureLinux 3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eiffel-fl@mfrw@PawelWMS