Consume ISOSDacInterface17 for structured stress-log reading - #1492

Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom
max-charlamb:stresslog-is17
Jul 2, 2026
Merged

Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom
max-charlamb:stresslog-is17

Conversation

@max-charlamb

@max-charlambMax Charlamb (max-charlamb) commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.

Design

StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:

  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).

ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.

Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.

Relies on dotnet/runtime#130038 for enumerating stress log memory

Max Charlamband others added 2 commits June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb) marked this pull request as ready for review June 30, 2026 17:22
CopilotAI reviewed Jun 30, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.

Changes:

  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs Outdated
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs Outdated
Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver) reviewed Jun 30, 2026
View reviewed changes

@leculverLee Culver (leculver) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.

Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs Outdated
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs Outdated
Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed the stresslog-is17 branch 2 times, most recently from e812c27 to 6201ee8CompareJune 30, 2026 18:52
Max Charlamband others added 2 commits June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb) merged commit b4e15f0 into microsoft:mainJul 2, 2026
10 checks passed
@max-charlamb
Max Charlamb (max-charlamb) deleted the stresslog-is17 branch July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Consume ISOSDacInterface17 for structured stress-log reading - #1492
Merged
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Jul 2, 2026
Merged
Consume ISOSDacInterface17 for structured stress-log reading#1492
Max Charlamb (max-charlamb) merged 5 commits into
microsoft:mainfrom 
max-charlamb:stresslog-is17
Conversation
@max-charlamb
@max-charlambMax Charlamb (max-charlamb)
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Makes ClrMD consume ISOSDacInterface17 (IS17) for stress-log reading. When the cDAC is loaded, the stress-log header, threads, messages (with resolved arguments), and chunk memory ranges come from the structured DAC contract instead of ClrMD re-parsing raw target memory. Older runtimes / the legacy C++ DAC transparently fall back to the existing raw-memory parser.
Design
StressLog becomes an abstract base (no public ABI break) with two concrete subclasses:
  • LegacyStressLog -- the original raw-memory parser (this is the renamed StressLog.cs; the first commit is a pure rename so history/blame follow through). Used for the legacy DAC / older runtimes and behind the address-based StressLog.TryOpen overloads.
  • ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via a new IAbstractStressLog DAC service (DacStressLog).
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is available and falls back to the raw parser otherwise.
Also adds the SosDac17 COM wrapper + stress-log enumerators and a parity test that verifies the IS17 path and the raw parser produce identical messages and memory ranges for the same dump.
Relies on dotnet/runtime#130038 for enumerating stress log memory
Max Charlamband others
added 2 commits
June 29, 2026 23:27
Max Charlamb
Rename StressLog.cs to LegacyStressLog.cs
40af36a
Pure file rename with no content changes, so git records it as a 100%
rename and history/blame follow through to the new path. The subsequent
commit turns StressLog into an abstract base and reworks the moved file
into the LegacyStressLog subclass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Consume ISOSDacInterface17 for structured stress-log reading
905e8cc
Make StressLog an abstract base with two concrete subclasses:
* LegacyStressLog -- the original raw-memory parser (the renamed file),
used for the legacy DAC / older runtimes and behind the address-based
StressLog.TryOpen overloads.
* ContractStressLog -- backed by the cDAC's ISOSDacInterface17 via the
IAbstractStressLog DAC service; threads, messages, resolved arguments,
and chunk memory ranges all come from the structured contract.
ClrRuntime.TryGetStressLog prefers the IS17 contract when the cDAC is
loaded and transparently falls back to the raw parser otherwise. Adds the
SosDac17 COM wrapper + enumerators, the IAbstractStressLog abstraction and
its DacStressLog implementation, and an IS17/raw parity test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
marked this pull request as ready for review
June 30, 2026 17:22
CopilotAI
reviewed
Jun 30, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR updates ClrMD’s stress-log reader to prefer the structured DAC contract (ISOSDacInterface17) when a cDAC is loaded, while keeping the existing raw-memory parser as a fallback for older runtimes / legacy DAC scenarios. It introduces an abstract StressLog base with separate legacy vs contract-backed implementations and adds DAC plumbing + tests to validate parity.
Changes:
  • Refactors StressLog into an abstract base class and moves the existing raw parser into LegacyStressLog.
  • Adds a cDAC-backed stress-log implementation (ContractStressLog) built on a new IAbstractStressLog service implemented via DacStressLog + new ISOSDac17 COM wrappers.
  • Adds a parity test to compare IS17 vs raw parser outputs on the same dump (when a usable cDAC is present).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
FileDescription
src/Microsoft.Diagnostics.Runtime/StressLog/StressLog.csRefactors public surface into an abstract base and redirects address-based opens to the legacy parser.
src/Microsoft.Diagnostics.Runtime/StressLog/LegacyStressLog.csContains the original raw-memory stress-log parser implementation (moved/renamed).
src/Microsoft.Diagnostics.Runtime/StressLog/Internal/StressLogEnumerationContext.csGeneralizes per-enumeration state to support both iterator-based and contract-provided arguments.
src/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.csAdds the cDAC/IS17-backed stress-log reader that merges per-thread message streams.
src/Microsoft.Diagnostics.Runtime/DacInterface/SosDac17.csIntroduces COM wrappers/enumerators for ISOSDacInterface17 stress-log APIs.
src/Microsoft.Diagnostics.Runtime/DacInterface/ISOSDac17.csDefines interop structs and the internal ISOSDac17 wrapper interface.
src/Microsoft.Diagnostics.Runtime/DacInterface/ClrDataProcess.csAdds CreateSOSDacInterface17 to QI for the IS17 interface.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.csImplements IAbstractStressLog by translating IS17 COM enumerators into managed contract types.
src/Microsoft.Diagnostics.Runtime/DacImplementation/DacServiceProvider.csWires up IAbstractStressLog service creation and disposes the IS17 wrapper.
src/Microsoft.Diagnostics.Runtime/ClrRuntime.csPrefers the contract-backed stress-log path during probing (with fallback considerations).
src/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.csAdds the public abstract DAC contract for stress-log access and associated data structs.
src/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.csAdds parity tests to validate IS17 vs legacy parser output equivalence (when cDAC available).
Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime/AbstractDac/IAbstractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
leculver
Lee Culver (leculver)
reviewed
Jun 30, 2026
View reviewed changes
@leculverLee Culver (leculver)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, a few bits of feedback.
Comment threadsrc/Microsoft.Diagnostics.Runtime/DacImplementation/DacStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/StressLog/ContractStressLog.cs
Outdated

Comment threadsrc/Microsoft.Diagnostics.Runtime/ClrRuntime.cs
Comment threadsrc/Microsoft.Diagnostics.Runtime.Tests/src/StressLogIs17ParityTests.cs
@max-charlamb
Max Charlamb (max-charlamb)force-pushed
the
stresslog-is17
branch
2 times, most recently
from
e812c27 to
6201ee8CompareJune 30, 2026 18:52
Max Charlamband others
added 2 commits
June 30, 2026 15:24
Max Charlamb
Address PR review feedback
f54bf2a
* ContractStressLog.EnumerateMemoryRanges: validate each range and raise a
CorruptChunk diagnostic (then skip) when start + size overflows, matching
the raw path's ChunkFits guard instead of yielding an invalid range.
* ContractStressLog.EnumerateMessages: raise a LimitExceeded diagnostic when
the MaxThreads cap is hit, matching the raw path, rather than silently
dropping later threads' messages.
* DacStressLog.EnumerateMessages: clamp each message's argument count to
StressLogConstants.MaxArgumentCount and use a fixed buffer so corrupt data
cannot drive an unbounded allocation.
* IAbstractStressLog: fix doc typo (used read -> used to read).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Max Charlamb
Make IS17 parity tests platform-agnostic ([Fact] not [WindowsFact])
9b59a94
These tests load a Core full dump and compare the IS17 and raw stress-log
paths -- nothing Windows-specific, matching the sibling [Fact]
CanOpenStressLog_Core_Workstation/_Server integration tests. On platforms
without a co-located cDAC they simply take the existing no-op path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
Max Charlamb (max-charlamb)
merged commit b4e15f0
into
microsoft:mainJul 2, 2026

10 checks passed

@max-charlamb
Max Charlamb (max-charlamb)
deleted the

stresslog-is17

branch
July 2, 2026 17:30
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@leculverLee Culver (leculver)leculver approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@leculver