Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Disable api calls - #851

Merged
Djordje (DordeDimitrijev) merged 13 commits into
masterfrom
disable-api-calls
Dec 16, 2024
Merged

Disable api calls#851
Djordje (DordeDimitrijev) merged 13 commits into
masterfrom
disable-api-calls

Conversation

@DordeDimitrijev

@DordeDimitrijevDjordje (DordeDimitrijev) commented Nov 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Implemented feature for stopping api calls from being sent after unsuccessful response. This behavior is aligned with other appcenter SDKs. Disabling of api calls occurs only per session after first failed request.

Related PRs or issues

AB#107980

DmitriyKirakosyan
Dmitriy Kirakosyan (DmitriyKirakosyan) reviewed Nov 18, 2024
View reviewed changes
Comment threadsrc/test/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
DmitriyKirakosyan
Dmitriy Kirakosyan (DmitriyKirakosyan) reviewed Nov 18, 2024
View reviewed changes
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/test/acquisition-sdk.ts
Comment threadsrc/script/acquisition-sdk.ts Outdated
@DordeDimitrijev
Djordje (DordeDimitrijev) marked this pull request as ready for review November 19, 2024 08:39
DmitriyKirakosyan
Dmitriy Kirakosyan (DmitriyKirakosyan) reviewed Nov 20, 2024
View reviewed changes
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts
Comment threadsrc/test/acquisition-sdk.ts
Comment threadsrc/test/acquisition-sdk.ts
DmitriyKirakosyan
Dmitriy Kirakosyan (DmitriyKirakosyan) reviewed Nov 20, 2024
View reviewed changes
Comment threadsrc/script/acquisition-sdk.ts
DmitriyKirakosyan
Dmitriy Kirakosyan (DmitriyKirakosyan) reviewed Nov 21, 2024
View reviewed changes
Comment threadsrc/script/acquisition-sdk.ts
Comment threadsrc/test/acquisition-sdk.ts Outdated
Comment threadsrc/test/acquisition-sdk.ts Outdated
Comment threadsrc/test/acquisition-sdk.ts
DmitriyKirakosyan
Dmitriy Kirakosyan (DmitriyKirakosyan) reviewed Dec 2, 2024
View reviewed changes
Comment threadsrc/test/acquisition-rest-mock.ts
Comment threadsrc/test/acquisition-rest-mock.ts
Comment threadsrc/test/acquisition-rest-mock.ts Outdated
Comment threadsrc/test/acquisition-sdk.ts
Comment threadsrc/test/acquisition-sdk.ts Outdated
Comment threadsrc/test/acquisition-sdk.ts
@IlyaBausovAkvelon

Ilya Bausov (IlyaBausovAkvelon) commented Dec 4, 2024

Copy link
Copy Markdown

I've built and tested this PR on my machine. Everything seems fine.

IlyaBausovAkvelon
Ilya Bausov (IlyaBausovAkvelon) approved these changes Dec 5, 2024
View reviewed changes
Comment threadsrc/script/acquisition-sdk.ts Outdated
Comment threadsrc/script/acquisition-sdk.ts Outdated
lucen-ms
Lukas Cenovsky (lucen-ms) reviewed Dec 13, 2024
View reviewed changes
Comment threadsrc/script/acquisition-sdk.ts
this._ignoreAppVersion = configuration.ignoreAppVersion;
}

private isRecoverable = (statusCode: number): boolean => statusCode >= 500 || statusCode === 408 || statusCode === 429;

@lucen-msLukas Cenovsky (lucen-ms)Dec 13, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You check this when response code is not 200 - what about other 2xx or 3xx responses - are they recoverable or not?

@DordeDimitrijev
Djordje (DordeDimitrijev) deleted the disable-api-calls branch December 16, 2024 11:14
This was referenced Dec 16, 2024
Merged
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IlyaBausovAkvelonIlya Bausov (IlyaBausovAkvelon)Awaiting requested review from IlyaBausovAkvelon
2 more reviewers
@DmitriyKirakosyanDmitriy Kirakosyan (DmitriyKirakosyan)DmitriyKirakosyan approved these changes
@lucen-msLukas Cenovsky (lucen-ms)lucen-ms approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DordeDimitrijev@IlyaBausovAkvelon@DmitriyKirakosyan@lucen-ms