Uh oh!
There was an error while loading. Please reload this page.
fix(web): guarantee a checkpoint on dashboard Stop/Kill (#245) - #254
Merged
Conversation
Jason Robert (jrob5756)force-pushed
the
fix/245-web-stop-checkpoint
branch
2 times, most recently
from
June 16, 2026 21:25
d14351b to
eaf95daCompareA dashboard Kill while an agent was actively running — and the Stop startup-race fallback — cancelled the engine task from the CLI wrapper, unwinding through the engine's `except asyncio.CancelledError` arm which intentionally emits no `workflow_failed` and saves no checkpoint. The wrapper then raised `ExecutionError` outside the engine, so progress was lost silently with no UI feedback. - engine: add idempotent `handle_dashboard_stop()` that writes a best-effort checkpoint and emits `workflow_failed` (flagged `stopped_by_user`, with `checkpoint_path` or `checkpoint_unavailable_reason`) plus `checkpoint_saved`. Flag the in-loop `InterruptError` path `stopped_by_user` for parity; correct the misleading `CancelledError` comment. - cli: thread `engine` into `_execute_with_stop_signal`; call `handle_dashboard_stop` on a stop-driven cancel, and re-raise a self-raised `InterruptError` (pause->Kill) untouched. - web/server: queue `POST /api/stop` (`_pending_stop`) until the engine binds the interrupt event instead of falling back to a hard stop. - dashboard: dedicated "Workflow Stopped" banner showing the checkpoint outcome; clearer Stop/Kill tooltips; rebuilt static bundle. - tests + docs (CHANGELOG, cli-reference, AGENTS). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jason Robert (jrob5756)force-pushed
the
fix/245-web-stop-checkpoint
branch
from
June 16, 2026 21:29
eaf95da to
a932513CompareUh oh!
There was an error while loading. Please reload this page.
Jason Robert (jrob5756) added a commit
that referenced
this pull request
Jun 17, 2026
Resolve conflicts from #252 (context_tier), #253 (script stdin), #254/#245 (dashboard-stop checkpoint), and #255 (periodic checkpoints): - cli/run.py: keep both the validator event cases and the new checkpoint_save_failed console case in the on_event chain. - AGENTS.md / examples/README.md: keep both features' sections. - Dashboard bundle: rebuilt from merged frontend source (one bundle reflects main's ErrorBanner/Header/store changes and the validator events/handlers). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#245.
Problem
A dashboard Kill while an agent was actively running — and the Stop startup-race fallback — cancelled the engine task from the CLI wrapper, unwinding through the engine's
except asyncio.CancelledErrorarm, which intentionally emits noworkflow_failedand saves no checkpoint. The wrapper then raisedExecutionErroroutside the engine, so progress was lost silently with no UI feedback. The pause→Kill path only worked because it raisedInterruptErrorinside the engine.Changes
Backend
engine/workflow.py: new idempotenthandle_dashboard_stop()— writes a best-effort checkpoint and emits a singleworkflow_failed(flaggedstopped_by_user, carryingcheckpoint_pathorcheckpoint_unavailable_reason) pluscheckpoint_saved. Flags the in-loopInterruptErrorpathstopped_by_userfor parity; corrects the misleadingCancelledErrorcomment.cli/run.py: threadsengineinto_execute_with_stop_signal; on a stop-driven cancel it callshandle_dashboard_stop, while a self-raisedInterruptError(pause→Kill) is re-raised untouched (no double-handling).web/server.py:POST /api/stopnow queues (_pending_stop) untilset_interrupt_eventbinds the engine event, replacing the progress-losing hard-stop fallback.Frontend (React bundle rebuilt + committed under
web/static/)Checkpoint saved: <path>orNo checkpoint could be saved — <reason>; store/types updated; clearer Stop/Kill tooltips.Tests & docs
TestHandleDashboardStop(4),_execute_with_stop_signalwiring (2), server-queue rewrite (3), integration Kill-mid-step (1).test_web+test_cli+test_enginesweep: 1244 passed, 4 skipped. Ruff lint +tytypecheck clean; frontendtsc -bclean.docs/cli-reference.md,AGENTS.md.Out of scope: #244 (periodic checkpoints) — complementary, tracked separately.