Uh oh!
There was an error while loading. Please reload this page.
ci: give the test step room for the Fleet Manager's suite - #434
Merged
Conversation
The Windows job has been failing on main since #431 landed. Not a test failure -- 7,164 passed, 0 failed -- the step hit its 10-minute limit at 9m56s and was killed. #431 added ~600 tests, most of them Textual `App.run_test()` pilots, and Windows runs the suite at roughly twice the Linux wall time: the step went from ~5m to ~10m and landed right on the boundary. It passed at 9m42s on the PR and failed at 9m56s on main, which is the same run either side of a coin flip. There is no single slow test to fix -- `tests/test_fleet` is 522 tests in ~90s locally, ~0.17s each, which is ordinary for pilot tests. So this raises the limit rather than pretending the suite did not grow. 20 minutes is ~2x headroom on Windows and ~3x on Linux: still short enough to catch a genuine hang, instead of the current setting failing a green run. Also caches the AST parse in `test_markup_guards.py`. Its ten source scans were each re-parsing all 116 files under `src/conductor`, sixteen full passes in total (14.6s -> 11.6s). The trees are only read, so one parse serves every rule. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has been failing on
mainsince #431 landed. It is not a test failure — the Windows job reports7164 passed, 64 skipped, 41 deselectedand then:The step ran for 9m56s against a 10-minute limit and was killed while writing its summary.
Why now
#431 added ~600 tests, most of them Textual
App.run_test()pilots, and Windows runs the suite at roughly twice the Linux wall time. The Windows test step went from ~5m (measured on the two runs before the merge) to ~10m, landing exactly on the boundary — it passed at 9m42s on the PR and failed at 9m56s onmain. Same code, opposite result.What this changes
Raises the test step's
timeout-minutesfrom 10 to 20.I looked for a slow test to fix instead and there isn't one:
tests/test_fleetis 522 tests in ~90s locally, about 0.17s each, which is ordinary for pilot tests. The slowest single test in the whole suite is 7.4s and predates this work. The suite genuinely got bigger, so the limit should reflect that rather than the limit pretending it didn't.20 minutes is ~2x headroom on Windows and ~3x on Linux — still short enough to catch a genuine hang rather than burning the full job timeout on one.
Also
Caches the AST parse in
test_markup_guards.py. Its ten source-scanning rules were each re-parsing all 116 files undersrc/conductor, sixteen full passes in total. The trees are only read, never mutated, so one parse serves every rule (14.6s → 11.6s).