Uh oh!
There was an error while loading. Please reload this page.
fix(fleet-tui): fix empty kill confirmation modal box - #451
Merged
Jason Robert (jrob5756) merged 2 commits intoAug 16, 2026
Conversation
`#confirm-dialog` was a Vertical with `width: auto`, and both its Static children fell back to Textual's base `1fr` width (Static.DEFAULT_CSS only sets height: auto). An auto-width container whose children are all 1fr resolves to 0, so the dialog collapsed to 0x0 and painted as nothing but its `border: thick $error` -- an empty red box. Give #confirm-dialog a fixed width (capped at 90% for small terminals), wrap the message in a VerticalScroll capped at max-height so long messages scroll instead of overflowing or truncating silently, and dock the hint to the bottom so it can't be pushed off screen. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…dering PR #451 review: no test asserted on the confirm-kill dialog's fixed 60-width/max-width:90% CSS, so the fix could be reverted to width:auto with the suite still green. Add dialog-width and inset assertions to test_the_dialog_paints_its_message, a new wrapping regression test for the ~100-char foreground warning line, and a new narrow-terminal test pinning the max-width:90% branch at 40x12. test_the_hint_stays_on_screen_with_many_foreground_runs never queried #confirm-hint or #confirm-message-scroll and its named assertion passed against the pre-fix 0-height dialog; it now checks the hint's own region, that it actually painted, and that it doesn't overlap the scroll viewport. Also apply reviewer recommendations: scope the foreground-warning test to the message widget's own region instead of a full-screen substring match that incidentally matches the RunsScreen table underneath; support an optional clip_to region on _painted_within for widgets whose content overflows their scroll viewport, and delete the now-unused full-screen _painted helper; document why ConfirmKillModal's VerticalScroll is left focusable (no OptionList competing for focus, unlike GateOptionsModal); explicit size=(80, 24) on tests that relied on Textual's default terminal size; and correct docstring claims that overstated what two focus-forwarding tests actually assert. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jason Robert (jrob5756)
marked this pull request as ready for review
August 16, 2026 17:46
Uh oh!
There was an error while loading. Please reload this page.
Jason Robert (jrob5756)
deleted the
fix/449-fleet-tui-kill-modal-empty-box
branch
August 16, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#confirm-dialogwas aVerticalwithwidth: auto, and both itsStaticchildren fell back to Textual's base1frwidth (Static.DEFAULT_CSSonly setsheight: auto). An auto-width container whose children are all1frresolves to 0, so the dialog collapsed to 0x0 and painted as nothing but itsborder: thick $error— an empty red box.Changes
#confirm-dialoga fixed width (60, capped atmax-width: 90%for small terminals) instead ofauto.VerticalScroll(#confirm-message-scroll) capped atmax-height: 100%so a long message scrolls instead of overflowing or being silently truncated.#confirm-hintwidget to the bottom so it can't be pushed off screen by a long message.ConfirmKillModal.__init__.Closes#449