CI pipeline failure

[natalieparry]

The CI pipeline for C/C++ on Windows (defined here) reports success even when several builds fail. See this example where I recently broke the win32-dll build but the pipeline reported success (search "(Rebuild target(s)) -- FAILED" to easily find the issues). It also appears common for the sqllite build to be broken (as seen in this PR which did not introduce a bug the way mine did).

[lalitb]

Thanks for reporting it. Seems this line

cpp_client_telemetry/.github/workflows/build-windows-vs2019.yaml

Line 26 in c5e79bf

continue-on-error: true

is preventing failure to be flagged. It was added as part of #768. Tagging Max Golovanov (@maxgolov) if he still remember why this was done :)

[lalitb]

Ok my bad, Seems the above change is only to prevent submodules checkout failures to be flagged, need to investigate more here.

[bmehta001]

This is fixed by #1458, which restructures the Windows build scripts to propagate build failures end-to-end.

Root cause: the old build-all.bat ran many tools\RunMsBuild.bat invocations sequentially with no error check between them, so the job's exit code reflected only the last invocation — masking earlier failures (the win32-dll and sqlite cases you saw). The continue-on-error on the checkout step was unrelated, as noted above.

In #1458:

• tools\RunMsBuild.bat ends with exit /b %ERRORLEVEL%, returning msbuild's exit code.
• build-all-windows.bat runs if errorlevel 1 exit /b 1 after every target build (fail-fast).
• The build-all-v142/v143/v145.bat wrappers and the build-all.bat compatibility shim end with call build-all-windows.bat, propagating its exit code.
• The VS2022 CI workflow runs build-all-windows.bat, so any target failure now fails the job.

This will auto-close when #1458 merges.