Default Win32 transport to WinHTTP and harden request lifetimes - #1520

Open

bmehta001 wants to merge 277 commits into

microsoft:mainfrom

bmehta001:bhamehta/winhttp-default-windows-transport

This pull request is big! We're only showing the most recent 250 commits

Commits on Jun 13, 2026

Declare ITaskDispatcher::QueueWithResult after Cancel (preserve vtable ABI)

bmehta001
and
Copilot
committed
797ede0
Address Copilot round 2 on #1481: include <new>, handle nothrow-new failure

bmehta001
and
Copilot
committed
b10fa89
Address Copilot on #1429: don't claim binary/ABI compatibility in vtable comment

bmehta001
and
Copilot
committed
9762f94
Address Copilot round 3 on #1481: avoid atomic<thread::id>, fix lifetime comments

bmehta001
and
Copilot
committed
3dda53b
Address Copilot round 4 on #1481: precise self-join comment, reset flag on reuse

bmehta001
and
Copilot
committed
7e22ed2

Commits on Jun 22, 2026

HttpClient_WinInet: close session handle even when request handle is null

bmehta001
and
Copilot
committed
b5ba867
Offline storage: guard empty-filter delete + propagate SQLite store failure

bmehta001
and
Copilot
committed
652e5e5
Add MemoryStorage empty-filter delete regression test

bmehta001
and
Copilot
committed
325c55b
Address review comment: propagate synchronous disk store failures

bmehta001
and
Copilot
committed
d9640b7

Commits on Jun 23, 2026

Prevent event loss when a disk write fails during Flush()

bmehta001
and
Copilot
committed
f1b3381
Address Copilot comment: NoopTaskDispatcher::Cancel returns found-state

bmehta001
and
Copilot
committed
45e9d55
Address Copilot comments: rename flush test for precision

bmehta001
and
Copilot
committed
bab7b42
Merge remote-tracking branch 'msft/main' into bhamehta/fix-storage-data-safety
bmehta001
committed
e9c7ee3
Fold the SQLite batch-flush optimization into the data-safety change (was PR #1497)

bmehta001
and
Copilot
committed
84e49a6
Address Copilot: make StoreRecords fully all-or-nothing on invalid records

bmehta001
and
Copilot
committed
e1e7c4e
Address Copilot: re-queue the flush batch only on a zero store result

bmehta001
and
Copilot
committed
40fd118

Commits on Jun 24, 2026

Merge branch 'main' into bhamehta/fix-storage-data-safety
bmehta001
authored
97fee8e

Commits on Jun 30, 2026

Commits on Jul 2, 2026

Fix PrivacyGuard JNI UAF, RoInitialize leak, and missing low_battery profile

bmehta001
and
Copilot
committed
937d3ac
Fix GetAndReserveRecords data race (#1221) and SQLite shutdown leak (#1134)

bmehta001
and
Copilot
committed
82cffa1
Balance RoInitialize with an RAII guard (Copilot round-1)

bmehta001
and
Copilot
committed
03cf210
Add test for low_battery transmit-profile powerState (#312)

bmehta001
and
Copilot
committed
2905ca7
Guard checkpoint-on-flush against null disk storage (Copilot round-3)

bmehta001
and
Copilot
committed
e8db589
Merge branch 'main' into bhamehta/fix-storage-data-safety
bmehta001
authored
62ffbbd

Commits on Jul 6, 2026

Add teardown-during-in-flight-upload smoke test

bmehta001
and
Copilot
committed
dd9e023

Commits on Jul 8, 2026

Commits on Jul 9, 2026

Cast chrono counts to long long in %lld LOG_TRACE calls

bmehta001
and
Copilot
committed
cc8ece8
Address Copilot round 5 on #1481: <limits> include, broaden thread-start catch, fix test comment

bmehta001
and
Copilot
committed
f9262e0
Address Copilot round 6 on #1481: guard shared_from_this() in SendAsync

bmehta001
and
Copilot
committed
a1da06f
Correct the body-move comment in SendRequestAsync (#1481 review round 7)

bmehta001
and
Copilot
committed
23b6f9a
Harden NoSelfJoin test timeout path (#1481 review round 8)

bmehta001
and
Copilot
committed
62395c7
Move worker-lambda construction inside the try in SendAsync (#1481 review round 9)

bmehta001
and
Copilot
committed
9ae7dd5
Drop issue-number references from code comments

bmehta001
and
Copilot
committed
1ff4b52
Drop issue-number reference from teardown smoke-test comment

bmehta001
and
Copilot
committed
c10f636
Drop issue-number reference from metastats opt-in comments

bmehta001
and
Copilot
committed
21233a6
Guarantee the callback fires even when Send() throws

bmehta001
and
Copilot
committed
b1e03d8
Merge branch 'main' into bhamehta/fix-storage-data-safety
bmehta001
authored
31877df

Commits on Jul 10, 2026

Fix data-loss and queue-wedge in SQLite batched flush

bmehta001
and
Copilot
committed
689b61a
Fix out-of-bounds timer access in transmit-profile debug logging

bmehta001
and
Copilot
committed
6d2dd1a
Address Copilot review: correct Flush comment and size_t format specifier

bmehta001
and
Copilot
committed
f200af9
Fix use-after-free dispatching OnDestroy after the completion callback

bmehta001
and
Copilot
committed
cf9bc95
Address review: include <utility>, correct OnDestroy comment, harden test

bmehta001
and
Copilot
committed
f2af5ec
Merge remote-tracking branch 'msft/main' into bhamehta/runtime-fixes
bmehta001
committed
46e8b1d
Fix use-after-free when the last worker reference is released on its own thread

bmehta001
and
Copilot
committed
099348f
Fix two curl-client lifetime issues found in review

bmehta001
and
Copilot
committed
4af8401
Harden curl-client shutdown: complete-on-send and skip unsafe global cleanup

bmehta001
and
Copilot
committed
89491fd
Harden the completion-guard regression test against the timeout path

bmehta001
and
Copilot
committed
9d69b19
Clarify ~CurlHttpOperation comment for never-sent and synchronous-fallback cases

bmehta001
and
Copilot
committed
bfabf8c
Correct the OnDestroy comment: suppressed once a send is attempted

bmehta001
and
Copilot
committed
e25c43c
Wait for the operation to be destroyed in the self-join test's timeout path

bmehta001
and
Copilot
committed
8e6575b
Wait for the operation to be destroyed on the self-join test's success path

bmehta001
and
Copilot
committed
d2c69dd
Guarantee async ops are destroyed before teardown in both self-join tests

bmehta001
and
Copilot
committed
8650ce1
Hard-stop if a detached curl worker refuses to drain before teardown

bmehta001
and
Copilot
committed
bd49de4

Commits on Jul 11, 2026

Make worker self-dispose detection survive a prior detach()

bmehta001
and
Copilot
committed
be00ea0

Commits on Jul 12, 2026

Address review: portable worker-id storage and fix thread-id logging UB

bmehta001
and
Copilot
committed
9dd565a

Commits on Jul 13, 2026

Fix curl worker shutdown lifetime

bmehta001
and
Copilot
committed
42d448c
Avoid public queue-result dispatcher virtual

bmehta001
and
Copilot
committed
b9d9d03
Harden batched flush retry handling

bmehta001
and
Copilot
committed
c86e954

Commits on Jul 30, 2026

Simplify curl worker lifetime handling

bmehta001
and
Copilot
committed
6b793ad
Preserve curl completion semantics on worker failures

bmehta001
and
Copilot
committed
88f5c8f
Merge microsoft/main into the curl self-join fix

bmehta001
and
Copilot
committed
48ad566

Commits on Jul 31, 2026

Handle latency-off drops and share disk validation
bmehta001
committed
7cdf393
Fix deferred task lifetime tracking and shutdown cleanup
bmehta001
committed
7ef8109

Commits on Aug 1, 2026

Guard OfflineStorageHandler::Flush against leaking StartActivity on exception

bmehta001
and
Copilot
committed
d325700
Default Win32 desktop transport to WinHTTP instead of WinInet

bmehta001
and
Copilot
committed
6a1c050
Leak LogManagerFactory and PAL singletons to avoid static-destruction-order hazard
bmehta001
committed
074c6e4

Commits on Aug 3, 2026

fix winhttp teardown hang on cancellation

bmehta001
and
Copilot
committed
e28ae45
Merge branch 'main' into bhamehta/fix-storage-data-safety
bmehta001
authored
0885742
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
b73beec

Commits on Aug 4, 2026

Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
2ef5a64
Fix WinHTTP cancellation completion race

bmehta001
and
Copilot
committed
035d2d4
Merge upstream main into runtime fixes
bmehta001
committed
aae640e

Commits on Aug 5, 2026

Fix shutdown and flush review findings
bmehta001
committed
d803615
Guard flush exception completion
bmehta001
committed
fece2b2
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
f227d3f
Join stress-test upload workers before teardown

bmehta001
and
Copilot
committed
287dbc8
Prevent WinHTTP request wrapper use-after-free

bmehta001
and
Copilot
committed
f7fb6f4
Merge branch 'main' into bhamehta/runtime-fixes
bmehta001
authored
36e4927

Commits on Aug 6, 2026

Align vcpkg iOS deployment target
bmehta001
committed
b2bd27b
Harden Apple packaging integration
bmehta001
committed
ca440fc

Commits on Aug 7, 2026

Migrate Apple builds to canonical CMake variables
bmehta001
committed
c96f7de
Harden teardown and preserve failed flush records
bmehta001
committed
bfc2f6a
Merge remote-tracking branch 'origin/bhamehta/runtime-fixes' into bhamehta/runtime-fixes
bmehta001
committed
e942b93
Remove unused Windows transport dependencies
bmehta001
committed
50d283a
Harden flush and worker teardown recovery
bmehta001
committed
159645b
Merge PR #1491 batched offline storage flush
bmehta001
committed
e49cb76
Make activity cleanup non-throwing
bmehta001
committed
ab40f93
Merge origin/main into runtime fixes
bmehta001
committed
f6853b6
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
ba35371
Add direct test standard library includes
bmehta001
committed
8d45721
Rollback batched storage when an insert throws
bmehta001
committed
c5ed4dc

Commits on Aug 8, 2026

Merge remote-tracking branch 'origin/main' into bhamehta/winhttp-default-windows-transport
bmehta001
committed
715800d
Merge branch 'main' into bhamehta/fix-curl-async-self-join
bmehta001
authored
85116f0
Fix WinHTTP duplicate completion during teardown
bmehta001
committed
aa80a93
Merge remote-tracking branch 'origin/bhamehta/winhttp-default-windows-transport' into bhamehta/winhttp-default-windows-transport
bmehta001
committed
6deff3f
Merge upstream main after PR 1511
bmehta001
committed
927515f
Keep WinHTTP callback context alive through close
bmehta001
committed
d952202
Make cancellation stress test deterministic
bmehta001
committed
da1fe11
Avoid fixture socket overflow in cancellation stress test
bmehta001
committed
0303c83
Prepare WinHTTP for bounded cancellation
bmehta001
committed
f03af17
Merge PR 1481 Curl lifetime fix
bmehta001
committed
38d1e21
Align bounded cancellation integration
bmehta001
committed
2a1823c
Prepare request draining for PR 1494
bmehta001
committed
4c8d94c
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
9bd4ae2
Merge latest Microsoft main
bmehta001
committed
dd09470

Commits on Aug 9, 2026

Handle nil Apple responses during cancellation
bmehta001
committed
62471df
Fix teardown deadlock when flush is skipped during pause

bmehta001
and
Copilot
committed
8b38be1
Merge remote-tracking branch 'origin/bhamehta/winhttp-default-windows-transport' into bhamehta/winhttp-default-windows-transport
bmehta001
committed
9d1b3ec
Keep Apple requests alive through cancellation callbacks
bmehta001
committed
afb12aa
Fix process-terminating fastfail in oneds_memcpy_s on MSVC

bmehta001
and
Copilot
committed
8d3b67a
Fix SQLite batch accounting and benchmark
bmehta001
committed
c3c1ce3
Select curl HTTP version at runtime instead of forcing HTTP/2

bmehta001
and
Copilot
committed
0104294
Prevent SIGPIPE from killing the test process on peer reset

bmehta001
and
Copilot
committed
c457bb6
Always release SQLite storage during shutdown

bmehta001
and
Copilot
committed
1056ed7
Fix WinHTTP shutdown deadlock when a send fails synchronously

bmehta001
and
Copilot
committed
933ad80
Use stable worker identity for self-cancellation
bmehta001
committed
880c5df
Bound offline storage flush batches
bmehta001
committed
660aa2a
Bound offline flush batches to prevent CI timeouts
bmehta001
committed
21b645f
Drain late WinHTTP requests during shutdown
bmehta001
committed
a97db6d
Relax database session timestamp test timing
bmehta001
committed
5fd5d90

Commits on Aug 10, 2026

Select one Win32 HTTP transport in CMake
bmehta001
committed
226b0b7
Make Annex K overlap checks overflow-safe
bmehta001
committed
2bb62b6
Remove formatter exclusion and validate curl response info
bmehta001
committed
568daa2
Fix WinHTTP certificate validation
bmehta001
committed
b3b1870
Check Curl option configuration failures
bmehta001
committed
d981d63
Harden WinHTTP response handling
bmehta001
committed
78bc0c9
Harden transport response and handle cleanup
bmehta001
committed
a3df0d5
Wait for asynchronous kill-switch drops
bmehta001
committed
abcf98f
Allow slower functional test responses
bmehta001
committed
2cdd5f5
Restore diagnostic functional test timeouts
bmehta001
committed
b4609d3
Preserve WinHTTP setup failures
bmehta001
committed
3e72773
Keep WinHTTP responses when optional headers are unavailable
bmehta001
committed
c0f5967
Apply WinHTTP root checks only to HTTPS
bmehta001
committed
f77202a
Reuse Curl callback byte count
bmehta001
committed
81bd9cd
Match Curl callback signatures
bmehta001
committed
9c980fa
Harden final Windows transport review fixes
bmehta001
committed
d9de71a
Select one legacy Windows transport
bmehta001
committed
6296de7
Wire WinHTTP through consumers
bmehta001
committed
c26517f
Fix SampleCppMini project paths
bmehta001
committed
4191dea
Fix standalone sample paths and warning errors
bmehta001
committed
5056f9d
Clean up SampleCppMini build settings
bmehta001
committed
dee384a

Commits on Aug 11, 2026

Avoid unused-port cancellation test hangs
bmehta001
committed
4d3ef4c
Inject offline storage dependencies for testable recovery
bmehta001
committed
3b27ec1
De-duplicate SampleCppMini linker dependencies
bmehta001
committed
8d7b3ff
Use shared unused-parameter macro
bmehta001
committed
d3f64a3
Use explicit fixture base URL
bmehta001
committed
80f19de
Serialize WinHTTP handle operations
bmehta001
committed
5b6e163
Guard legacy Curl socket conversion
bmehta001
committed
9ddb81e
Treat socket poll errors as failures
bmehta001
committed
7afef1c
Close callback and legacy lifetime gaps
bmehta001
committed
6633a14
Preserve Curl option setup order
bmehta001
committed
3298439
Pair Curl callback options with userdata
bmehta001
committed
929caf6
Fix teardown cancellation wait semantics
bmehta001
committed
77773fa
Prevent teardown races and duplicate offline retries
bmehta001
committed
d552f09
Avoid test config construction UB
bmehta001
committed
73dfea6

Commits on Aug 12, 2026

Harden Curl async request completion

bmehta001
and
Copilot
committed
44d3eee
Harden Windows HTTP cancellation lifetimes

bmehta001
and
Copilot
committed
b39a383
Default Windows builds to WinHTTP

bmehta001
and
Copilot
committed
fd4ebb5
Reject invalid SQLite event latencies

bmehta001
and
Copilot
committed
c3faeac
Harden teardown, storage, and callback lifetimes
bmehta001
committed
54f115f

Commits on Aug 13, 2026

Serialize deferred task and offline flush teardown
bmehta001
committed
f1b482f
Harden Windows transport callback teardown
bmehta001
committed
875d151
Fail fast across both Windows HTTP transports
bmehta001
committed
47ca55b
Honor HTTP completion contracts on Apple and Curl
bmehta001
committed
104a67d
Preserve offline records after flush failures
bmehta001
committed
ea2e022
Require the canonical SQLite provider option
bmehta001
committed
b9865d3
Focus WinInet CI on production builds
bmehta001
committed
56eb592
Document HTTP response request correlation
bmehta001
committed
e932e93
Wait for deferred task destruction in PAL test
bmehta001
committed
845542d
Drop the legacy SQLite option guard
bmehta001
committed
f4794c2

Commits on Aug 17, 2026

Restore SampleCppMini deployment behavior
bmehta001
committed
667d989
Propagate SQLite persistence failures
bmehta001
committed
851c4b4
Keep SQLite failure tests warning-clean
bmehta001
committed
b804004
Serialize offline flush lifecycle
bmehta001
committed
33d0503
Release worker lock before cancellation waits
bmehta001
committed
76a7eb9
Evaluate WinInet certificate policy after TLS
bmehta001
committed
71acd20
Clarify HTTP request ownership
bmehta001
committed
f3c1f20
Harden Apple HTTP terminal completion
bmehta001
committed
58007b6
Quiesce Curl operations before client teardown
bmehta001
committed
c908b53

Commits on Aug 18, 2026

Order Curl lifecycle events around cancellation
bmehta001
committed
1fe6f75
Scope HTTP ownership to built-in transports
bmehta001
committed
ebbc6de
Compile payload decoder tests under MSBuild
bmehta001
committed
5373f64

Commits on Aug 22, 2026

Harden cancellation for fleet rollout
bmehta001
committed
dc28dc2
Document C API cancellation contract
bmehta001
committed
6f0d6c2

Commits on Aug 28, 2026

Commits on Aug 30, 2026

Preserve memory-only records during flush

bmehta001
and
Copilot
committed
2a9cd8f
Merge branch 'main' of ssh://github.com/microsoft/cpp_client_telemetry into copilot-pr-1520-fix
bmehta001
committed
7bbdda2

Commits on Aug 31, 2026

Harden transport certificate and cancellation handling
bmehta001
committed
ca544f4
Remove unnecessary implementation friendships

bmehta001
and
Copilot
committed
705b193
Handle stale kqueue events in HTTP tests
bmehta001
committed
3253fe5
Merge concurrent PR updates before test fixes
bmehta001
committed
9a7b37c
Prevent SIGPIPE in HTTP cancellation tests
bmehta001
committed
5bd98d8

Commits on Sep 1, 2026

Eliminate Android JNI compiler warnings

bmehta001
and
Copilot
committed
a45f0d6
Match Windows linkage to the selected transport
bmehta001
committed
c82e48c

Commits on Sep 2, 2026

Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
10ca012
Complete transport handoffs before callbacks
bmehta001
committed
e707f7c
Merge concurrent PR updates before review fixes
bmehta001
committed
cfd9480
Support no-exception transport teardown
bmehta001
committed
c4c8a5f
Bound curl connection establishment
bmehta001
committed
8762b34

Commits on Sep 4, 2026

Prevent cancellation callback loss

bmehta001
and
Copilot
committed
75b35c3
Nit
bmehta001
authored
356f2ee
Prevent dropped HTTP callbacks from blocking shutdown
bmehta001
committed
d407c67
Merge remote WinInet review update
bmehta001
committed
405d1a6
Make Apple setup cancellation win terminal race
bmehta001
committed
26dfa1f
Drain PAL test tasks before fatal failures
bmehta001
committed
84f4a02
Avoid HTTP handoff deadlocks and test races
bmehta001
committed
ecb3e06
Evaluate event filters outside the collection lock
bmehta001
committed
c37049e

Commits on Sep 7, 2026

Push changes
bmehta001
committed
987939a

Commits on Sep 13, 2026

Simplify Curl callback accounting
bmehta001
committed
6d05f60

Commits on Sep 14, 2026

Avoid session sidecars for in-memory storage
bmehta001
committed
02bf939
Merge branch 'main' into bhamehta/avoid-in-memory-session-sidecar
bmehta001
authored
3cadd03
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
d56455b
Preserve session telemetry with in-memory storage
bmehta001
committed
89ebcc5
Remove hot-path filter and Curl copies

bmehta001
and
Copilot
committed
1744f7d
Simplify
bmehta001
authored
732a465
Complete in-memory path simplification
bmehta001
committed
f453ca9
Merge remote-tracking branch 'msft/main' into bhamehta/avoid-in-memory-session-sidecar
bmehta001
committed
3c4cc67
Repair CI after SQLite target migration
bmehta001
committed
6bc46bf

Commits on Sep 15, 2026

Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
02685e9

Commits on Sep 16, 2026

Gate WinInet uploads on MS-root validation
bmehta001
committed
0ed32f9

Commits on Sep 17, 2026

Merge current main into runtime fixes

bmehta001
and
Copilot
committed
9e54c3b
Merge current main into transport hardening

bmehta001
and
Copilot
committed
3fac64a
Merge runtime fixes into transport hardening

bmehta001
and
Copilot
committed
9247ad0
Repair CI after SQLite target migration
bmehta001
committed
74b1632
Fix merge-induced dispatcher and Apple test failures
bmehta001
committed
300d381
Merge CI compatibility repairs from #1429
bmehta001
committed
7edd933
Merge branch 'main' into bhamehta/avoid-in-memory-session-sidecar
bmehta001
authored
edbafd1
Merge in-memory session sidecar fix from #1535
bmehta001
committed
33b7bab
Restore durable storage functional coverage

bmehta001
and
Copilot
committed
5ffc8e7
Address final transport review findings
bmehta001
committed
63d3618
Complete final transport review fixes
bmehta001
committed
0165474
Preserve memory-only events during flush
bmehta001
committed
ccf5896
android: make native telemetry validation reliable
bmehta001
committed
5c749b9
tests: restore deterministic retry-limit validation
bmehta001
committed
aaefc84

Commits on Sep 18, 2026

Retarget managed wrapper to .NET Framework 4.8

bmehta001
and
Copilot
committed
e38eb85
Restore EventFilterCollection emptiness check

bmehta001
and
Copilot
committed
3694997