box_value constructor: Replace param::hstring with hstring

[justanotheranonymoususer]

Partial fix for #1527.

Other places remain unfixed, example:

unbox_value_or(boxed, ReturnsStringView());

Or any other param::hstring usage.

[Charles Milette (sylveon)]

Ryan Shepherd (@DefaultRyan) This PR is a good one - box_value will always do a copy of the hstring so we might as well skip the param::hstring here.

[Ryan Shepherd (DefaultRyan)]

This breaks boxing of string-like types such as std::wstring and std::wstring_view via conversion to param::hstring.

I think we can still do this with a little more finesse. One idea of the top of my head is to have an exact hstring overload, and an overload for string-like types that are convertible to param::hstring. For the second overload, we don't actually create a param::hstring, but explicitly construct a fully-fledged hstring instead.

[justanotheranonymoususer]

I tried to fix, can you run tests?

[Ryan Shepherd (DefaultRyan)]

I tried to fix, can you run tests?

Did you know you can run the tests locally? That break would have been caught there and saved you some time. :)

[justanotheranonymoususer]

I was filling lucky. Should pass now, and I even added tests.

[justanotheranonymoususer]

Ryan Shepherd (@DefaultRyan) it's green now, are we good?

[justanotheranonymoususer]

thx for approving, can you also merge?