Skip to content

fix: ensure non-TTY agents dont hang - #172

Merged
Simon Knott (Skn0tt) merged 4 commits into
microsoft:mainfrom
Skn0tt:agents
Apr 2, 2026
Merged

fix: ensure non-TTY agents dont hang#172
Simon Knott (Skn0tt) merged 4 commits into
microsoft:mainfrom
Skn0tt:agents

Conversation

@Skn0tt

@Skn0ttSimon Knott (Skn0tt) commented Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Closesmicrosoft/playwright#39986:

  • prevents createFiles from hanging in quiet mode
  • add --test-dir flag, which was only configurable interactively before

@Skn0ttSimon Knott (Skn0tt) changed the title fix: fix: ensure non-TTY agents dont hangApr 2, 2026
dgozman
Dmitry Gozman (dgozman) approved these changes Apr 2, 2026
View reviewed changes
Comment threadsrc/generator.ts Outdated
Comment threadsrc/cli.ts Outdated
@Skn0ttSimon Knott (Skn0tt) mentioned this pull request Apr 2, 2026
Closed
karlhorky
Karl Horky (karlhorky) reviewed Apr 2, 2026
View reviewed changes
Comment threadsrc/cli.ts
@@ -34,6 +34,7 @@ program
.option('--quiet', 'do not ask for interactive input prompts')
.option('--gha', 'install GitHub Actions')

@karlhorkyKarl Horky (karlhorky)Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simon Knott (@Skn0tt) I think there's still not a --no-gha flag for non-interactive rejection of GitHub Actions workflow files, as I mentioned here:

@Skn0ttSimon Knott (Skn0tt)Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's needed, GitHub Actions workflow files are off unless --gha is passed. So --no-gha is the default.

@karlhorkyKarl Horky (karlhorky)Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that requires the --quiet flag, which hides the defaults

it's less obvious what this does:

pnpm create playwright --browser=chromium --test-dir=playwright --quiet

it would be easier to understand if you can just exhaustively pass in all options (this would break after your PR):

pnpm create playwright --browser=chromium --test-dir=playwright --no-gha

we're getting into the same conversation territory in the new PR, so I'll continue over here:

@karlhorkyKarl Horky (karlhorky)Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issues #39986 and #39987 weren't actually resolved by this PR

There may be an option to complete this over here:

@Skn0tt
Simon Knott (Skn0tt) merged commit c0f2d83 into microsoft:mainApr 2, 2026
13 checks passed
@karlhorkyKarl Horky (karlhorky) mentioned this pull request Apr 2, 2026
Open
This was referenced Jun 26, 2026
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozmanDmitry Gozman (dgozman)dgozman approved these changes
+1 more reviewer
@karlhorkyKarl Horky (karlhorky)karlhorky left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Skn0ttSimon Knott (Skn0tt)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: create-playwright should ensure non-interactive setup for AI agents

3 participants

@Skn0tt@karlhorky@dgozman