Skip to content

Suppress warning on exit by properly closing pydevd socket#1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 2 commits into from
Feb 5, 2025
Merged

Suppress warning on exit by properly closing pydevd socket #1826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47f1f4e
Fix #1812, first try
bersbersbers Feb 4, 2025
73966ab
Prevent tries to close socket multiple times
bersbersbers Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/debugpy/_vendored/pydevd/pydevd.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -726,6 +726,8 @@ def __init__(self, set_as_global=True):

self._local_thread_trace_func = threading.local()

self._client_socket = None

self._server_socket_ready_event = ThreadingEvent()
self._server_socket_name = None

Expand DownExpand Up@@ -1504,6 +1506,7 @@ def initialize_network(self, sock, terminate_on_socket_close=True):
def connect(self, host, port):
if host:
s = start_client(host, port)
self._client_socket = s
else:
s = start_server(port)

Expand DownExpand Up@@ -2551,6 +2554,10 @@ def dispose_and_kill_all_pydevd_threads(self, wait=True, timeout=0.5):
except:
pass
finally:
if self._client_socket:
self._client_socket.close()
self._client_socket = None

pydev_log.debug("PyDB.dispose_and_kill_all_pydevd_threads: finished")

def prepare_to_run(self):
Expand Down