Skip to content

Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 2 commits into from
May 14, 2026
Merged

Prevent invalid scopes request from crashing debug session #2026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26a54bc
Prevent invalid scopes request from crashing debug session
pdepetro May 12, 2026
811da01
Add logging for invalid scopes requests
pdepetro May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
frame_id = request.arguments.frameId

variables_reference = frame_id
scopes = [
Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
]
try:
scopes = [
Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),

@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]

[verified]

Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),

@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]

[verified]

]
except (ValueError, TypeError):
pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
scopes = []
except Exception:
pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
scopes = []
body = ScopesResponseBody(scopes)
scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down
32 changes: 32 additions & 0 deletions src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

result = processor.on_scopes_request(None, request)
response = result.as_dict

assert response["success"] is True
scopes = response["body"]["scopes"]
assert len(scopes) == 2
assert scopes[0]["name"] == "Locals"
assert scopes[0]["presentationHint"] == "locals"
assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
request = pydevd_schema.ScopesRequest(

@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
-26

frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]

[verified]

@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.

@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().

pydevd_schema.ScopesArguments(frameId="not_a_number")
)

result = processor.on_scopes_request(None, request)
response = result.as_dict

assert response["success"] is True
assert response["body"]["scopes"] == []
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Prevent invalid scopes request from crashing debug session by pdepetro · Pull Request #2026 · microsoft/debugpy · GitHub
Skip to content
Prevent invalid scopes request from crashing debug session#2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Rich Chiodo (rchiodo)
merged 2 commits into

from

May 14, 2026
 Merged


Prevent invalid scopes request from crashing debug session
#2026
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
26a54bc

Prevent invalid scopes request from crashing debug session


pdepetro May 12, 2026
811da01

Add logging for invalid scopes requests


pdepetro May 12, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


15 changes: 11 additions & 4 deletions
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1109,10 +1109,17 @@ def on_scopes_request(self, py_db, request):
 frame_id = request.arguments.frameId

 variables_reference = frame_id
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
 ]
 try:
 scopes = [
 Scope("Locals", ScopeRequest(int(variables_reference), "locals"), False, presentationHint="locals"),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:
except Exception is too broad. The PR description identifies ValueError from int() as the failure mode — catch (ValueError, TypeError) instead. The current catch will silently swallow any future bug in Scope() or ScopeRequest() constructors (e.g., AttributeError, KeyError), making those bugs invisible. All three technical reviewers flagged this independently. [unverified]
[verified]
 Scope("Globals", ScopeRequest(int(variables_reference), "globals"), False),
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

The except block has no logging. When this triggers in production, there's zero diagnostic trail — the user sees an empty Variables panel with no explanation. Add at minimum pydev_log.info('Invalid frameId %r in scopes request', variables_reference) so developers can trace why variables aren't showing. The Advocate notes the codebase has precedent for logging in exception handlers (e.g., line 534 uses pydev_log.exception). [unverified]
[verified]
 ]
 except (ValueError, TypeError):
 pydev_log.info("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 except Exception:
 pydev_log.exception("Failed to create scopes for frame id: %s", frame_id)
 scopes = []
 body = ScopesResponseBody(scopes)
 scopes_response = pydevd_base_schema.build_response(request, kwargs={"body": body})
 return NetCommand(CMD_RETURN, 0, scopes_response, is_json=True)
Expand Down

32 changes: 32 additions & 0 deletions
src/debugpy/_vendored/pydevd/tests_python/test_pydevd_process_net_command_json.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
def test_on_scopes_request_with_valid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(pydevd_schema.ScopesArguments(frameId=1))

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 scopes = response["body"]["scopes"]
 assert len(scopes) == 2
 assert scopes[0]["name"] == "Locals"
 assert scopes[0]["presentationHint"] == "locals"
 assert scopes[1]["name"] == "Globals"


def test_on_scopes_request_with_invalid_frame_id():
 from _pydevd_bundle._debug_adapter import pydevd_schema, pydevd_base_schema
 from _pydevd_bundle.pydevd_process_net_command_json import PyDevJsonCommandProcessor

 processor = PyDevJsonCommandProcessor(pydevd_base_schema.from_json)
 request = pydevd_schema.ScopesRequest(
@rchiodoRich Chiodo (rchiodo)May 12, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot generated:

-26
frameId="not_a_number" tests a scenario that likely can't occur via the DAP protocol (which defines frameId as integer). The more realistic failure mode is a valid integer that references a stale/dead frame (e.g., frameId=999999). Consider adding a test for that case — it would exercise a more likely production failure path. [unverified]
[verified]
@pdepetroPhilip DePetro (pdepetro)May 12, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

999999 is a valid int, so it wouldn't exercise what we're preventing here, which would be a non-integer value.
@pdepetroPhilip DePetro (pdepetro)May 13, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific issue we've seen is that the client can send a scopes request using a DAP id that corresponds to a thread instead of a frame. The DAP to id translation converts that to something like pid_1996270_id_140192610058896 which raises an exception when passed to int().
 pydevd_schema.ScopesArguments(frameId="not_a_number")
 )

 result = processor.on_scopes_request(None, request)
 response = result.as_dict

 assert response["success"] is True
 assert response["body"]["scopes"] == []
Loading